Uh oh!
There was an error while loading. Please reload this page.
[DNNL] Add support of QNN primitives for DNNL runtime - #9618
Conversation
masahi
commented
Jan 9, 2022
Please update this PR. |
Signed-off-by: Alexander Peskov <peskovnn@gmail.com>
Signed-off-by: Alexander Peskov <peskovnn@gmail.com>
Signed-off-by: Alexander Peskov <peskovnn@gmail.com>
Signed-off-by: Alexander Peskov <peskovnn@gmail.com>
Signed-off-by: Alexander Peskov <peskovnn@gmail.com>
Signed-off-by: Alexander Peskov <peskovnn@gmail.com>
Signed-off-by: Alexander Peskov <peskovnn@gmail.com>
Signed-off-by: Alexander Peskov <peskovnn@gmail.com>
Signed-off-by: Alexander Peskov <peskovnn@gmail.com>
Signed-off-by: Alexander Peskov <peskovnn@gmail.com>
Signed-off-by: Alexander Peskov <peskovnn@gmail.com>
Signed-off-by: Alexander Peskov <peskovnn@gmail.com>
Signed-off-by: Alexander Peskov <peskovnn@gmail.com>
apeskov
commented
Jan 14, 2022
@masahi PR is updated. You may continue review. |
apeskov
commented
Jan 14, 2022
@tmoreau89@gfursin Just FYI. |
tmoreau89
commented
Jan 18, 2022
Thanks @apeskov - I'm also looping in @mbs-octoml on the review of this PR |
If that's the case, I want this PR to be split into smaller ones. It's hard to review 3K PR with lots of moving pieces. Indeed 3K is too big for just introducing int8 support. |
masahi
left a comment
There was a problem hiding this comment.
At least changes in dnnl_json_runtime.cc and dnnl_node_helper.h are relatively unrelated to int8. Please send them first.
Also we use CamelCase throughout the codebase, so please follow the convention.
areusch
commented
Apr 8, 2022
masahi
commented
Apr 9, 2022
Closing, feel free to reopen. |
The main value of that change is enable qnn.conv2d and qnn.dense primitive for DNNL base json runtime.
Some of these changes is useful for all type of workloads, not only int8 specific.
Together with that there was performed some refactoring of internal infrastructure of DNNL plugin. The main int8 unrelated changes are: