Skip to content

[RELAY] [AST] Add virtual_device as a first class field in Relay - #9641

Merged
tqchen merged 5 commits into
apache:mainfrom
electriclilies:first-class-scope
Dec 10, 2021
Merged

[RELAY] [AST] Add virtual_device as a first class field in Relay#9641
tqchen merged 5 commits into
apache:mainfrom
electriclilies:first-class-scope

Conversation

@electriclilies

@electriclilieselectriclilies commented Dec 2, 2021

Copy link
Copy Markdown
Contributor

This PR adds virtual_device (SEScope) as a first class field in Relay. This is an implementation of apache/tvm-rfcs#45 please take a look the RFC for the motivation, implementation, future work, etc.

@mbs-octoml@jroesch@mikepapadim

@electriclilieselectriclilies changed the title Add virtual_device as a first class field in Relay[RELAY] [AST] Add virtual_device as a first class field in RelayDec 2, 2021
mbs-octoml
mbs-octoml approved these changes Dec 2, 2021
View reviewed changes

@mbs-octomlmbs-octoml left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Lily, this can't come soon enough as I spent yesterday tracking down more accidentally-lost on_device annotations!

Comment threadinclude/tvm/relay/expr.h Outdated
@electriclilieselectriclilies mentioned this pull request Dec 6, 2021
Closed
@electriclilies

electriclilies commented Dec 6, 2021

Copy link
Copy Markdown
ContributorAuthor

@comaniac Could you take a look at this? It's my implementation of apache/tvm-rfcs#45. Thanks!

@electriclilieselectriclilies mentioned this pull request Dec 6, 2021
Closed
comaniac
comaniac reviewed Dec 7, 2021
View reviewed changes

@comaniaccomaniac left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM. Just some docstring errors.

Comment threadinclude/tvm/ir/expr.h Outdated
Comment threadinclude/tvm/relay/expr.h Outdated
Comment threadinclude/tvm/relay/expr.h Outdated
Comment threadinclude/tvm/relay/expr.h Outdated
Comment threadinclude/tvm/relay/expr.h
Comment threadinclude/tvm/relay/expr.h Outdated
Comment threadinclude/tvm/relay/expr.h Outdated
@electriclilies
electricliliesforce-pushed the first-class-scope branch 2 times, most recently from fa8466d to 1637380CompareDecember 8, 2021 21:41
@electriclilies

electriclilies commented Dec 8, 2021•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

@comaniac Thanks, updated the comments and docstrings! I think this is good to go in once CI is green.

comaniac
comaniac approved these changes Dec 8, 2021
View reviewed changes

@comaniaccomaniac left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tqchen
tqchen merged commit bd361b9 into apache:mainDec 10, 2021
@tqchen

tqchen commented Dec 10, 2021

Copy link
Copy Markdown
Member

THanks @electriclilies for the contribution. Thanks @comaniac@mbs-octoml for reviewing. This PR is now merged

ylc pushed a commit to ylc/tvm that referenced this pull request Jan 7, 2022
@electriclilies@ylc
[RELAY] [AST] Add virtual_device as a first class field in Relay (apa…
9b6d322
…che#9641)
yangulei pushed a commit to yangulei/tvm that referenced this pull request Jan 11, 2022
@electriclilies@yangulei
[RELAY] [AST] Add virtual_device as a first class field in Relay (apa…
a676e1b
…che#9641)
yangulei pushed a commit to yangulei/tvm that referenced this pull request Jan 12, 2022
@electriclilies@yangulei
[RELAY] [AST] Add virtual_device as a first class field in Relay (apa…
77c9b92
…che#9641)
ylc pushed a commit to ylc/tvm that referenced this pull request Jan 13, 2022
@electriclilies@ylc
[RELAY] [AST] Add virtual_device as a first class field in Relay (apa…
04ecf56
…che#9641)
qsqqsqqsq-intellif pushed a commit to qsqqsqqsq-intellif/tvm that referenced this pull request Apr 29, 2022
@electricliliesbaoxinqi
[RELAY] [AST] Add virtual_device as a first class field in Relay (apa…
14e0e14
…che#9641)
@driazatidriazati mentioned this pull request Jul 14, 2022
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@comaniaccomaniaccomaniac approved these changes
@anijain2305anijain2305Awaiting requested review from anijain2305
@icemelonicemelonAwaiting requested review from icemelon
@jroeschjroeschAwaiting requested review from jroesch
@junrushaojunrushaoAwaiting requested review from junrushao
@jwfrommjwfrommAwaiting requested review from jwfromm
@MarisaKirisameMarisaKirisameAwaiting requested review from MarisaKirisame
@mbrookhartmbrookhartAwaiting requested review from mbrookhart
@slyubomirskyslyubomirskyAwaiting requested review from slyubomirsky
@tqchentqchenAwaiting requested review from tqchen
@vinx13vinx13Awaiting requested review from vinx13
@wweicwweicAwaiting requested review from wweic
@yzhliuyzhliuAwaiting requested review from yzhliu
@zhiicszhiicsAwaiting requested review from zhiics
@ZihengJiangZihengJiangAwaiting requested review from ZihengJiang
+1 more reviewer
@mbs-octomlmbs-octomlmbs-octoml approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

status: accepted

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@electriclilies@tqchen@comaniac@mbs-octoml