Skip to content

[microNPU][2c] Add performance modelling to cascader - #9778

Merged
manupak merged 3 commits into
apache:mainfrom
mbaret:ethosu-cascader-4
Jan 17, 2022
Merged

[microNPU][2c] Add performance modelling to cascader#9778
manupak merged 3 commits into
apache:mainfrom
mbaret:ethosu-cascader-4

Conversation

@jacobbohlin

@jacobbohlinjacobbohlin commented Dec 20, 2021

Copy link
Copy Markdown
Contributor

RFC: apache/tvm-rfcs#37
Issue: #9429

NOTE: This PR builds on top of #9469 and #9471 and therefore includes those changes. This PR will remain as 'draft' until both dependencies are merged.

The algorithm described in the RFC uses two metrics for pareto culling, performance and memory usage. This commit addresses the former and introduces the basis of performance estimation for the Parts. It also includes performance estimation code that is specific to ethosu_conv2d.

The output of the performance model is only meant to be consumed by the cascader.

@jacobbohlin

jacobbohlin commented Dec 20, 2021

Copy link
Copy Markdown
ContributorAuthor

@mbaret@manupa-arm@NicolaLancellotti

@jacobbohlinjacobbohlin mentioned this pull request Dec 21, 2021
Merged
@mbaret
mbaretforce-pushed the ethosu-cascader-4 branch 2 times, most recently from 77a5b22 to 366aa80CompareDecember 22, 2021 10:54
@mbaret
mbaretforce-pushed the ethosu-cascader-4 branch 2 times, most recently from 1124baf to 35d9164CompareJanuary 4, 2022 15:14
@mbaretmbaret mentioned this pull request Jan 5, 2022
Closed
12 tasks
@jacobbohlinjacobbohlin mentioned this pull request Jan 5, 2022
Merged
@jacobbohlin
jacobbohlinforce-pushed the ethosu-cascader-4 branch 2 times, most recently from 6366031 to 426d0aeCompareJanuary 11, 2022 14:36
@jacobbohlin
jacobbohlin marked this pull request as ready for review January 11, 2022 14:42
mbaret
mbaret reviewed Jan 12, 2022
View reviewed changes
Comment threadsrc/contrib/ethosu/cascader/parts/ethosu.cc
Comment on lines 71 to 121
for (size_t i = 0; i < block_shape.size(); i++) {
if (!is_rolling) {
num_blocks *= output_stripe_config->GetShape()[i] * output_stripe_config->GetStripes()[i] /
if (buffer_mode == BufferMode::RECOMPUTE) {
num_blocks *= static_cast<float>(output_stripe_config->GetShape()[i] *
output_stripe_config->GetStripes()[i]) /
block_shape[i];
} else {
num_blocks *= output_stripe_config->GetExtent()[i] / block_shape[i];
num_blocks *= static_cast<float>(output_stripe_config->GetExtent()[i]) / block_shape[i];
}
}

@mbaretmbaretJan 12, 2022

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to mention that this logic is placeholder and will be replaced in a later patch.

@mbaret

mbaret commented Jan 12, 2022

Copy link
Copy Markdown
Contributor

Just a quick note on the test coverage of this feature. The results of the performance model are not explicitly tested against the FVP because we don’t have performance instrumentation available in CI. We will however be testing this component downstream where such instrumentation is available.

@jacobbohlin
[microNPU][2c] Initial Performance Model
3a030d2
* Added the pre-computed performance modelling per block.
* Added the aggregation of cycles given a stripe config.
* Implemented the op-specific performance code for conv2d.
* Created a DeviceConfig class to hold constant performance related data
that is dependent on the accelerator configuration
* Added generation of all valid block configs. This is pre-computed and
given as an argument when constructing EthosuParts.
* Implemented selection of the block config that gives the least amount
of data read given a StripeConfig.
@jacobbohlin
Add test guards
13f2eb6
@jacobbohlin
Extended block config testing
e1daf76
@mbaret

mbaret commented Jan 17, 2022

Copy link
Copy Markdown
Contributor

cc @manupa-arm could you take a look and merge if everything's OK? Thanks

manupak
manupak approved these changes Jan 17, 2022
View reviewed changes

@manupakmanupak left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@manupak
manupak merged commit 133bb9c into apache:mainJan 17, 2022
@manupak

manupak commented Jan 17, 2022

Copy link
Copy Markdown
Contributor

Thanks! @jacobbohlin@mbaret

yuanfz98 pushed a commit to yuanfz98/tvm that referenced this pull request Jan 24, 2022
@jacobbohlin@yuanfz98
[microNPU][2c] Add performance modelling to cascader (apache#9778)
e34e9e6
* [microNPU][2c] Initial Performance Model
* Added the pre-computed performance modelling per block.
* Added the aggregation of cycles given a stripe config.
* Implemented the op-specific performance code for conv2d.
* Created a DeviceConfig class to hold constant performance related data
that is dependent on the accelerator configuration
* Added generation of all valid block configs. This is pre-computed and
given as an argument when constructing EthosuParts.
* Implemented selection of the block config that gives the least amount
of data read given a StripeConfig.
* Add test guards
* Extended block config testing
crazydemo pushed a commit to crazydemo/tvm that referenced this pull request Jan 27, 2022
@jacobbohlinIvy
[microNPU][2c] Add performance modelling to cascader (apache#9778)
1f10874
* [microNPU][2c] Initial Performance Model
* Added the pre-computed performance modelling per block.
* Added the aggregation of cycles given a stripe config.
* Implemented the op-specific performance code for conv2d.
* Created a DeviceConfig class to hold constant performance related data
that is dependent on the accelerator configuration
* Added generation of all valid block configs. This is pre-computed and
given as an argument when constructing EthosuParts.
* Implemented selection of the block config that gives the least amount
of data read given a StripeConfig.
* Add test guards
* Extended block config testing
ylc pushed a commit to ylc/tvm that referenced this pull request Feb 16, 2022
@jacobbohlin@ylc
[microNPU][2c] Add performance modelling to cascader (apache#9778)
3ad10b4
* [microNPU][2c] Initial Performance Model
* Added the pre-computed performance modelling per block.
* Added the aggregation of cycles given a stripe config.
* Implemented the op-specific performance code for conv2d.
* Created a DeviceConfig class to hold constant performance related data
that is dependent on the accelerator configuration
* Added generation of all valid block configs. This is pre-computed and
given as an argument when constructing EthosuParts.
* Implemented selection of the block config that gives the least amount
of data read given a StripeConfig.
* Add test guards
* Extended block config testing
@driazatidriazati mentioned this pull request Jul 14, 2022
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mbaretmbaretmbaret approved these changes
@manupakmanupakmanupak approved these changes
@anijain2305anijain2305Awaiting requested review from anijain2305
@areuschareuschAwaiting requested review from areusch
@comaniaccomaniacAwaiting requested review from comaniac
@icemelonicemelonAwaiting requested review from icemelon
@jroeschjroeschAwaiting requested review from jroesch
@junrushaojunrushaoAwaiting requested review from junrushao
@jwfrommjwfrommAwaiting requested review from jwfromm
@MarisaKirisameMarisaKirisameAwaiting requested review from MarisaKirisame
@mbrookhartmbrookhartAwaiting requested review from mbrookhart
@merrymercymerrymercyAwaiting requested review from merrymercy
@slyubomirskyslyubomirskyAwaiting requested review from slyubomirsky
@tqchentqchenAwaiting requested review from tqchen
@vinx13vinx13Awaiting requested review from vinx13
@wweicwweicAwaiting requested review from wweic
@yzhliuyzhliuAwaiting requested review from yzhliu
@zhiicszhiicsAwaiting requested review from zhiics
@ZihengJiangZihengJiangAwaiting requested review from ZihengJiang

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jacobbohlin@mbaret@manupak
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
[microNPU][2c] Add performance modelling to cascader by jacobbohlin · Pull Request #9778 · apache/tvm · GitHub
Skip to content
[microNPU][2c] Add performance modelling to cascader - #9778
Merged
manupak merged 3 commits into
apache:mainfrom 
mbaret:ethosu-cascader-4
Jan 17, 2022
Merged
[microNPU][2c] Add performance modelling to cascader#9778
manupak merged 3 commits into
apache:mainfrom 
mbaret:ethosu-cascader-4
Conversation
@jacobbohlin
@jacobbohlinjacobbohlin
commented
Dec 20, 2021

Copy link


Copy Markdown

Contributor
RFC: apache/tvm-rfcs#37

Issue: #9429
NOTE: This PR builds on top of #9469 and #9471 and therefore includes those changes. This PR will remain as 'draft' until both dependencies are merged.
The algorithm described in the RFC uses two metrics for pareto culling, performance and memory usage. This commit addresses the former and introduces the basis of performance estimation for the Parts. It also includes performance estimation code that is specific to ethosu_conv2d.
The output of the performance model is only meant to be consumed by the cascader.
@jacobbohlin
jacobbohlin
commented
Dec 20, 2021

Copy link


Copy Markdown

ContributorAuthor
@mbaret@manupa-arm@NicolaLancellotti
@jacobbohlinjacobbohlin
mentioned this pull request
Dec 21, 2021
 Merged

@mbaret
mbaretforce-pushed
the
ethosu-cascader-4
branch
2 times, most recently
from
77a5b22 to
366aa80CompareDecember 22, 2021 10:54
@mbaret
mbaretforce-pushed
the
ethosu-cascader-4
branch
2 times, most recently
from
1124baf to
35d9164CompareJanuary 4, 2022 15:14
@mbaretmbaret
mentioned this pull request
Jan 5, 2022

Closed

12 tasks
@jacobbohlinjacobbohlin
mentioned this pull request
Jan 5, 2022
 Merged

@jacobbohlin
jacobbohlinforce-pushed
the
ethosu-cascader-4
branch
2 times, most recently
from
6366031 to
426d0aeCompareJanuary 11, 2022 14:36
@jacobbohlin
jacobbohlin
marked this pull request as ready for review
January 11, 2022 14:42
mbaret
mbaret
reviewed
Jan 12, 2022
View reviewed changes
Comment threadsrc/contrib/ethosu/cascader/parts/ethosu.cc

Comment on lines

71
 to 
121

 for (size_t i = 0; i < block_shape.size(); i++) {
 if (!is_rolling) {
 num_blocks *= output_stripe_config->GetShape()[i] * output_stripe_config->GetStripes()[i] /
 if (buffer_mode == BufferMode::RECOMPUTE) {
 num_blocks *= static_cast<float>(output_stripe_config->GetShape()[i] *
 output_stripe_config->GetStripes()[i]) /
 block_shape[i];
 } else {
 num_blocks *= output_stripe_config->GetExtent()[i] / block_shape[i];
 num_blocks *= static_cast<float>(output_stripe_config->GetExtent()[i]) / block_shape[i];
 }
 }
@mbaretmbaretJan 12, 2022

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to mention that this logic is placeholder and will be replaced in a later patch.
@mbaret
mbaret
commented
Jan 12, 2022

Copy link


Copy Markdown

Contributor
Just a quick note on the test coverage of this feature. The results of the performance model are not explicitly tested against the FVP because we don’t have performance instrumentation available in CI. We will however be testing this component downstream where such instrumentation is available.
@jacobbohlin
[microNPU][2c] Initial Performance Model
3a030d2
* Added the pre-computed performance modelling per block.
* Added the aggregation of cycles given a stripe config.
* Implemented the op-specific performance code for conv2d.
* Created a DeviceConfig class to hold constant performance related data
that is dependent on the accelerator configuration
* Added generation of all valid block configs. This is pre-computed and
given as an argument when constructing EthosuParts.
* Implemented selection of the block config that gives the least amount
of data read given a StripeConfig.
@jacobbohlin
Add test guards
13f2eb6
@jacobbohlin
Extended block config testing
e1daf76
@mbaret
mbaret
commented
Jan 17, 2022

Copy link


Copy Markdown

Contributor
cc @manupa-arm could you take a look and merge if everything's OK? Thanks
manupak
manupak
approved these changes
Jan 17, 2022
View reviewed changes
@manupakmanupak
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@manupak
manupak
merged commit 133bb9c
into
apache:mainJan 17, 2022
@manupak
manupak
commented
Jan 17, 2022

Copy link


Copy Markdown

Contributor
Thanks! @jacobbohlin@mbaret
yuanfz98 pushed a commit
to yuanfz98/tvm
that referenced
this pull request
Jan 24, 2022
@jacobbohlin@yuanfz98
[microNPU][2c] Add performance modelling to cascader (apache#9778)
e34e9e6
* [microNPU][2c] Initial Performance Model
* Added the pre-computed performance modelling per block.
* Added the aggregation of cycles given a stripe config.
* Implemented the op-specific performance code for conv2d.
* Created a DeviceConfig class to hold constant performance related data
that is dependent on the accelerator configuration
* Added generation of all valid block configs. This is pre-computed and
given as an argument when constructing EthosuParts.
* Implemented selection of the block config that gives the least amount
of data read given a StripeConfig.
* Add test guards
* Extended block config testing
crazydemo pushed a commit
to crazydemo/tvm
that referenced
this pull request
Jan 27, 2022
@jacobbohlinIvy
[microNPU][2c] Add performance modelling to cascader (apache#9778)
1f10874
* [microNPU][2c] Initial Performance Model
* Added the pre-computed performance modelling per block.
* Added the aggregation of cycles given a stripe config.
* Implemented the op-specific performance code for conv2d.
* Created a DeviceConfig class to hold constant performance related data
that is dependent on the accelerator configuration
* Added generation of all valid block configs. This is pre-computed and
given as an argument when constructing EthosuParts.
* Implemented selection of the block config that gives the least amount
of data read given a StripeConfig.
* Add test guards
* Extended block config testing
ylc pushed a commit
to ylc/tvm
that referenced
this pull request
Feb 16, 2022
@jacobbohlin@ylc
[microNPU][2c] Add performance modelling to cascader (apache#9778)
3ad10b4
* [microNPU][2c] Initial Performance Model
* Added the pre-computed performance modelling per block.
* Added the aggregation of cycles given a stripe config.
* Implemented the op-specific performance code for conv2d.
* Created a DeviceConfig class to hold constant performance related data
that is dependent on the accelerator configuration
* Added generation of all valid block configs. This is pre-computed and
given as an argument when constructing EthosuParts.
* Implemented selection of the block config that gives the least amount
of data read given a StripeConfig.
* Add test guards
* Extended block config testing
@driazatidriazati
mentioned this pull request
Jul 14, 2022

Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@mbaretmbaretmbaret approved these changes
@manupakmanupakmanupak approved these changes
@anijain2305anijain2305Awaiting requested review from anijain2305
@areuschareuschAwaiting requested review from areusch
@comaniaccomaniacAwaiting requested review from comaniac
@icemelonicemelonAwaiting requested review from icemelon
@jroeschjroeschAwaiting requested review from jroesch
@junrushaojunrushaoAwaiting requested review from junrushao
@jwfrommjwfrommAwaiting requested review from jwfromm
@MarisaKirisameMarisaKirisameAwaiting requested review from MarisaKirisame
@mbrookhartmbrookhartAwaiting requested review from mbrookhart
@merrymercymerrymercyAwaiting requested review from merrymercy
@slyubomirskyslyubomirskyAwaiting requested review from slyubomirsky
@tqchentqchenAwaiting requested review from tqchen
@vinx13vinx13Awaiting requested review from vinx13
@wweicwweicAwaiting requested review from wweic
@yzhliuyzhliuAwaiting requested review from yzhliu
@zhiicszhiicsAwaiting requested review from zhiics
@ZihengJiangZihengJiangAwaiting requested review from ZihengJiang

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@jacobbohlin@mbaret@manupak

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
[microNPU][2c] Add performance modelling to cascader by jacobbohlin · Pull Request #9778 · apache/tvm · GitHub
Skip to content
[microNPU][2c] Add performance modelling to cascader - #9778
Merged
manupak merged 3 commits into
apache:mainfrom 
mbaret:ethosu-cascader-4
Jan 17, 2022
Merged
[microNPU][2c] Add performance modelling to cascader#9778
manupak merged 3 commits into
apache:mainfrom 
mbaret:ethosu-cascader-4
Conversation
@jacobbohlin
@jacobbohlinjacobbohlin
commented
Dec 20, 2021

Copy link


Copy Markdown

Contributor
RFC: apache/tvm-rfcs#37

Issue: #9429
NOTE: This PR builds on top of #9469 and #9471 and therefore includes those changes. This PR will remain as 'draft' until both dependencies are merged.
The algorithm described in the RFC uses two metrics for pareto culling, performance and memory usage. This commit addresses the former and introduces the basis of performance estimation for the Parts. It also includes performance estimation code that is specific to ethosu_conv2d.
The output of the performance model is only meant to be consumed by the cascader.
@jacobbohlin
jacobbohlin
commented
Dec 20, 2021

Copy link


Copy Markdown

ContributorAuthor
@mbaret@manupa-arm@NicolaLancellotti
@jacobbohlinjacobbohlin
mentioned this pull request
Dec 21, 2021
 Merged

@mbaret
mbaretforce-pushed
the
ethosu-cascader-4
branch
2 times, most recently
from
77a5b22 to
366aa80CompareDecember 22, 2021 10:54
@mbaret
mbaretforce-pushed
the
ethosu-cascader-4
branch
2 times, most recently
from
1124baf to
35d9164CompareJanuary 4, 2022 15:14
@mbaretmbaret
mentioned this pull request
Jan 5, 2022

Closed

12 tasks
@jacobbohlinjacobbohlin
mentioned this pull request
Jan 5, 2022
 Merged

@jacobbohlin
jacobbohlinforce-pushed
the
ethosu-cascader-4
branch
2 times, most recently
from
6366031 to
426d0aeCompareJanuary 11, 2022 14:36
@jacobbohlin
jacobbohlin
marked this pull request as ready for review
January 11, 2022 14:42
mbaret
mbaret
reviewed
Jan 12, 2022
View reviewed changes
Comment threadsrc/contrib/ethosu/cascader/parts/ethosu.cc

Comment on lines

71
 to 
121

 for (size_t i = 0; i < block_shape.size(); i++) {
 if (!is_rolling) {
 num_blocks *= output_stripe_config->GetShape()[i] * output_stripe_config->GetStripes()[i] /
 if (buffer_mode == BufferMode::RECOMPUTE) {
 num_blocks *= static_cast<float>(output_stripe_config->GetShape()[i] *
 output_stripe_config->GetStripes()[i]) /
 block_shape[i];
 } else {
 num_blocks *= output_stripe_config->GetExtent()[i] / block_shape[i];
 num_blocks *= static_cast<float>(output_stripe_config->GetExtent()[i]) / block_shape[i];
 }
 }
@mbaretmbaretJan 12, 2022

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to mention that this logic is placeholder and will be replaced in a later patch.
@mbaret
mbaret
commented
Jan 12, 2022

Copy link


Copy Markdown

Contributor
Just a quick note on the test coverage of this feature. The results of the performance model are not explicitly tested against the FVP because we don’t have performance instrumentation available in CI. We will however be testing this component downstream where such instrumentation is available.
@jacobbohlin
[microNPU][2c] Initial Performance Model
3a030d2
* Added the pre-computed performance modelling per block.
* Added the aggregation of cycles given a stripe config.
* Implemented the op-specific performance code for conv2d.
* Created a DeviceConfig class to hold constant performance related data
that is dependent on the accelerator configuration
* Added generation of all valid block configs. This is pre-computed and
given as an argument when constructing EthosuParts.
* Implemented selection of the block config that gives the least amount
of data read given a StripeConfig.
@jacobbohlin
Add test guards
13f2eb6
@jacobbohlin
Extended block config testing
e1daf76
@mbaret
mbaret
commented
Jan 17, 2022

Copy link


Copy Markdown

Contributor
cc @manupa-arm could you take a look and merge if everything's OK? Thanks
manupak
manupak
approved these changes
Jan 17, 2022
View reviewed changes
@manupakmanupak
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@manupak
manupak
merged commit 133bb9c
into
apache:mainJan 17, 2022
@manupak
manupak
commented
Jan 17, 2022

Copy link


Copy Markdown

Contributor
Thanks! @jacobbohlin@mbaret
yuanfz98 pushed a commit
to yuanfz98/tvm
that referenced
this pull request
Jan 24, 2022
@jacobbohlin@yuanfz98
[microNPU][2c] Add performance modelling to cascader (apache#9778)
e34e9e6
* [microNPU][2c] Initial Performance Model
* Added the pre-computed performance modelling per block.
* Added the aggregation of cycles given a stripe config.
* Implemented the op-specific performance code for conv2d.
* Created a DeviceConfig class to hold constant performance related data
that is dependent on the accelerator configuration
* Added generation of all valid block configs. This is pre-computed and
given as an argument when constructing EthosuParts.
* Implemented selection of the block config that gives the least amount
of data read given a StripeConfig.
* Add test guards
* Extended block config testing
crazydemo pushed a commit
to crazydemo/tvm
that referenced
this pull request
Jan 27, 2022
@jacobbohlinIvy
[microNPU][2c] Add performance modelling to cascader (apache#9778)
1f10874
* [microNPU][2c] Initial Performance Model
* Added the pre-computed performance modelling per block.
* Added the aggregation of cycles given a stripe config.
* Implemented the op-specific performance code for conv2d.
* Created a DeviceConfig class to hold constant performance related data
that is dependent on the accelerator configuration
* Added generation of all valid block configs. This is pre-computed and
given as an argument when constructing EthosuParts.
* Implemented selection of the block config that gives the least amount
of data read given a StripeConfig.
* Add test guards
* Extended block config testing
ylc pushed a commit
to ylc/tvm
that referenced
this pull request
Feb 16, 2022
@jacobbohlin@ylc
[microNPU][2c] Add performance modelling to cascader (apache#9778)
3ad10b4
* [microNPU][2c] Initial Performance Model
* Added the pre-computed performance modelling per block.
* Added the aggregation of cycles given a stripe config.
* Implemented the op-specific performance code for conv2d.
* Created a DeviceConfig class to hold constant performance related data
that is dependent on the accelerator configuration
* Added generation of all valid block configs. This is pre-computed and
given as an argument when constructing EthosuParts.
* Implemented selection of the block config that gives the least amount
of data read given a StripeConfig.
* Add test guards
* Extended block config testing
@driazatidriazati
mentioned this pull request
Jul 14, 2022

Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@mbaretmbaretmbaret approved these changes
@manupakmanupakmanupak approved these changes
@anijain2305anijain2305Awaiting requested review from anijain2305
@areuschareuschAwaiting requested review from areusch
@comaniaccomaniacAwaiting requested review from comaniac
@icemelonicemelonAwaiting requested review from icemelon
@jroeschjroeschAwaiting requested review from jroesch
@junrushaojunrushaoAwaiting requested review from junrushao
@jwfrommjwfrommAwaiting requested review from jwfromm
@MarisaKirisameMarisaKirisameAwaiting requested review from MarisaKirisame
@mbrookhartmbrookhartAwaiting requested review from mbrookhart
@merrymercymerrymercyAwaiting requested review from merrymercy
@slyubomirskyslyubomirskyAwaiting requested review from slyubomirsky
@tqchentqchenAwaiting requested review from tqchen
@vinx13vinx13Awaiting requested review from vinx13
@wweicwweicAwaiting requested review from wweic
@yzhliuyzhliuAwaiting requested review from yzhliu
@zhiicszhiicsAwaiting requested review from zhiics
@ZihengJiangZihengJiangAwaiting requested review from ZihengJiang

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@jacobbohlin@mbaret@manupak

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
[microNPU][2c] Add performance modelling to cascader by jacobbohlin · Pull Request #9778 · apache/tvm · GitHub
Skip to content
[microNPU][2c] Add performance modelling to cascader - #9778
Merged
manupak merged 3 commits into
apache:mainfrom 
mbaret:ethosu-cascader-4
Jan 17, 2022
Merged
[microNPU][2c] Add performance modelling to cascader#9778
manupak merged 3 commits into
apache:mainfrom 
mbaret:ethosu-cascader-4
Conversation
@jacobbohlin
@jacobbohlinjacobbohlin
commented
Dec 20, 2021

Copy link


Copy Markdown

Contributor
RFC: apache/tvm-rfcs#37

Issue: #9429
NOTE: This PR builds on top of #9469 and #9471 and therefore includes those changes. This PR will remain as 'draft' until both dependencies are merged.
The algorithm described in the RFC uses two metrics for pareto culling, performance and memory usage. This commit addresses the former and introduces the basis of performance estimation for the Parts. It also includes performance estimation code that is specific to ethosu_conv2d.
The output of the performance model is only meant to be consumed by the cascader.
@jacobbohlin
jacobbohlin
commented
Dec 20, 2021

Copy link


Copy Markdown

ContributorAuthor
@mbaret@manupa-arm@NicolaLancellotti
@jacobbohlinjacobbohlin
mentioned this pull request
Dec 21, 2021
 Merged

@mbaret
mbaretforce-pushed
the
ethosu-cascader-4
branch
2 times, most recently
from
77a5b22 to
366aa80CompareDecember 22, 2021 10:54
@mbaret
mbaretforce-pushed
the
ethosu-cascader-4
branch
2 times, most recently
from
1124baf to
35d9164CompareJanuary 4, 2022 15:14
@mbaretmbaret
mentioned this pull request
Jan 5, 2022

Closed

12 tasks
@jacobbohlinjacobbohlin
mentioned this pull request
Jan 5, 2022
 Merged

@jacobbohlin
jacobbohlinforce-pushed
the
ethosu-cascader-4
branch
2 times, most recently
from
6366031 to
426d0aeCompareJanuary 11, 2022 14:36
@jacobbohlin
jacobbohlin
marked this pull request as ready for review
January 11, 2022 14:42
mbaret
mbaret
reviewed
Jan 12, 2022
View reviewed changes
Comment threadsrc/contrib/ethosu/cascader/parts/ethosu.cc

Comment on lines

71
 to 
121

 for (size_t i = 0; i < block_shape.size(); i++) {
 if (!is_rolling) {
 num_blocks *= output_stripe_config->GetShape()[i] * output_stripe_config->GetStripes()[i] /
 if (buffer_mode == BufferMode::RECOMPUTE) {
 num_blocks *= static_cast<float>(output_stripe_config->GetShape()[i] *
 output_stripe_config->GetStripes()[i]) /
 block_shape[i];
 } else {
 num_blocks *= output_stripe_config->GetExtent()[i] / block_shape[i];
 num_blocks *= static_cast<float>(output_stripe_config->GetExtent()[i]) / block_shape[i];
 }
 }
@mbaretmbaretJan 12, 2022

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to mention that this logic is placeholder and will be replaced in a later patch.
@mbaret
mbaret
commented
Jan 12, 2022

Copy link


Copy Markdown

Contributor
Just a quick note on the test coverage of this feature. The results of the performance model are not explicitly tested against the FVP because we don’t have performance instrumentation available in CI. We will however be testing this component downstream where such instrumentation is available.
@jacobbohlin
[microNPU][2c] Initial Performance Model
3a030d2
* Added the pre-computed performance modelling per block.
* Added the aggregation of cycles given a stripe config.
* Implemented the op-specific performance code for conv2d.
* Created a DeviceConfig class to hold constant performance related data
that is dependent on the accelerator configuration
* Added generation of all valid block configs. This is pre-computed and
given as an argument when constructing EthosuParts.
* Implemented selection of the block config that gives the least amount
of data read given a StripeConfig.
@jacobbohlin
Add test guards
13f2eb6
@jacobbohlin
Extended block config testing
e1daf76
@mbaret
mbaret
commented
Jan 17, 2022

Copy link


Copy Markdown

Contributor
cc @manupa-arm could you take a look and merge if everything's OK? Thanks
manupak
manupak
approved these changes
Jan 17, 2022
View reviewed changes
@manupakmanupak
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@manupak
manupak
merged commit 133bb9c
into
apache:mainJan 17, 2022
@manupak
manupak
commented
Jan 17, 2022

Copy link


Copy Markdown

Contributor
Thanks! @jacobbohlin@mbaret
yuanfz98 pushed a commit
to yuanfz98/tvm
that referenced
this pull request
Jan 24, 2022
@jacobbohlin@yuanfz98
[microNPU][2c] Add performance modelling to cascader (apache#9778)
e34e9e6
* [microNPU][2c] Initial Performance Model
* Added the pre-computed performance modelling per block.
* Added the aggregation of cycles given a stripe config.
* Implemented the op-specific performance code for conv2d.
* Created a DeviceConfig class to hold constant performance related data
that is dependent on the accelerator configuration
* Added generation of all valid block configs. This is pre-computed and
given as an argument when constructing EthosuParts.
* Implemented selection of the block config that gives the least amount
of data read given a StripeConfig.
* Add test guards
* Extended block config testing
crazydemo pushed a commit
to crazydemo/tvm
that referenced
this pull request
Jan 27, 2022
@jacobbohlinIvy
[microNPU][2c] Add performance modelling to cascader (apache#9778)
1f10874
* [microNPU][2c] Initial Performance Model
* Added the pre-computed performance modelling per block.
* Added the aggregation of cycles given a stripe config.
* Implemented the op-specific performance code for conv2d.
* Created a DeviceConfig class to hold constant performance related data
that is dependent on the accelerator configuration
* Added generation of all valid block configs. This is pre-computed and
given as an argument when constructing EthosuParts.
* Implemented selection of the block config that gives the least amount
of data read given a StripeConfig.
* Add test guards
* Extended block config testing
ylc pushed a commit
to ylc/tvm
that referenced
this pull request
Feb 16, 2022
@jacobbohlin@ylc
[microNPU][2c] Add performance modelling to cascader (apache#9778)
3ad10b4
* [microNPU][2c] Initial Performance Model
* Added the pre-computed performance modelling per block.
* Added the aggregation of cycles given a stripe config.
* Implemented the op-specific performance code for conv2d.
* Created a DeviceConfig class to hold constant performance related data
that is dependent on the accelerator configuration
* Added generation of all valid block configs. This is pre-computed and
given as an argument when constructing EthosuParts.
* Implemented selection of the block config that gives the least amount
of data read given a StripeConfig.
* Add test guards
* Extended block config testing
@driazatidriazati
mentioned this pull request
Jul 14, 2022

Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@mbaretmbaretmbaret approved these changes
@manupakmanupakmanupak approved these changes
@anijain2305anijain2305Awaiting requested review from anijain2305
@areuschareuschAwaiting requested review from areusch
@comaniaccomaniacAwaiting requested review from comaniac
@icemelonicemelonAwaiting requested review from icemelon
@jroeschjroeschAwaiting requested review from jroesch
@junrushaojunrushaoAwaiting requested review from junrushao
@jwfrommjwfrommAwaiting requested review from jwfromm
@MarisaKirisameMarisaKirisameAwaiting requested review from MarisaKirisame
@mbrookhartmbrookhartAwaiting requested review from mbrookhart
@merrymercymerrymercyAwaiting requested review from merrymercy
@slyubomirskyslyubomirskyAwaiting requested review from slyubomirsky
@tqchentqchenAwaiting requested review from tqchen
@vinx13vinx13Awaiting requested review from vinx13
@wweicwweicAwaiting requested review from wweic
@yzhliuyzhliuAwaiting requested review from yzhliu
@zhiicszhiicsAwaiting requested review from zhiics
@ZihengJiangZihengJiangAwaiting requested review from ZihengJiang

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@jacobbohlin@mbaret@manupak

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
[microNPU][2c] Add performance modelling to cascader by jacobbohlin · Pull Request #9778 · apache/tvm · GitHub
Skip to content
[microNPU][2c] Add performance modelling to cascader - #9778
Merged
manupak merged 3 commits into
apache:mainfrom 
mbaret:ethosu-cascader-4
Jan 17, 2022
Merged
[microNPU][2c] Add performance modelling to cascader#9778
manupak merged 3 commits into
apache:mainfrom 
mbaret:ethosu-cascader-4
Conversation
@jacobbohlin
@jacobbohlinjacobbohlin
commented
Dec 20, 2021

Copy link


Copy Markdown

Contributor
RFC: apache/tvm-rfcs#37

Issue: #9429
NOTE: This PR builds on top of #9469 and #9471 and therefore includes those changes. This PR will remain as 'draft' until both dependencies are merged.
The algorithm described in the RFC uses two metrics for pareto culling, performance and memory usage. This commit addresses the former and introduces the basis of performance estimation for the Parts. It also includes performance estimation code that is specific to ethosu_conv2d.
The output of the performance model is only meant to be consumed by the cascader.
@jacobbohlin
jacobbohlin
commented
Dec 20, 2021

Copy link


Copy Markdown

ContributorAuthor
@mbaret@manupa-arm@NicolaLancellotti
@jacobbohlinjacobbohlin
mentioned this pull request
Dec 21, 2021
 Merged

@mbaret
mbaretforce-pushed
the
ethosu-cascader-4
branch
2 times, most recently
from
77a5b22 to
366aa80CompareDecember 22, 2021 10:54
@mbaret
mbaretforce-pushed
the
ethosu-cascader-4
branch
2 times, most recently
from
1124baf to
35d9164CompareJanuary 4, 2022 15:14
@mbaretmbaret
mentioned this pull request
Jan 5, 2022

Closed

12 tasks
@jacobbohlinjacobbohlin
mentioned this pull request
Jan 5, 2022
 Merged

@jacobbohlin
jacobbohlinforce-pushed
the
ethosu-cascader-4
branch
2 times, most recently
from
6366031 to
426d0aeCompareJanuary 11, 2022 14:36
@jacobbohlin
jacobbohlin
marked this pull request as ready for review
January 11, 2022 14:42
mbaret
mbaret
reviewed
Jan 12, 2022
View reviewed changes
Comment threadsrc/contrib/ethosu/cascader/parts/ethosu.cc

Comment on lines

71
 to 
121

 for (size_t i = 0; i < block_shape.size(); i++) {
 if (!is_rolling) {
 num_blocks *= output_stripe_config->GetShape()[i] * output_stripe_config->GetStripes()[i] /
 if (buffer_mode == BufferMode::RECOMPUTE) {
 num_blocks *= static_cast<float>(output_stripe_config->GetShape()[i] *
 output_stripe_config->GetStripes()[i]) /
 block_shape[i];
 } else {
 num_blocks *= output_stripe_config->GetExtent()[i] / block_shape[i];
 num_blocks *= static_cast<float>(output_stripe_config->GetExtent()[i]) / block_shape[i];
 }
 }
@mbaretmbaretJan 12, 2022

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to mention that this logic is placeholder and will be replaced in a later patch.
@mbaret
mbaret
commented
Jan 12, 2022

Copy link


Copy Markdown

Contributor
Just a quick note on the test coverage of this feature. The results of the performance model are not explicitly tested against the FVP because we don’t have performance instrumentation available in CI. We will however be testing this component downstream where such instrumentation is available.
@jacobbohlin
[microNPU][2c] Initial Performance Model
3a030d2
* Added the pre-computed performance modelling per block.
* Added the aggregation of cycles given a stripe config.
* Implemented the op-specific performance code for conv2d.
* Created a DeviceConfig class to hold constant performance related data
that is dependent on the accelerator configuration
* Added generation of all valid block configs. This is pre-computed and
given as an argument when constructing EthosuParts.
* Implemented selection of the block config that gives the least amount
of data read given a StripeConfig.
@jacobbohlin
Add test guards
13f2eb6
@jacobbohlin
Extended block config testing
e1daf76
@mbaret
mbaret
commented
Jan 17, 2022

Copy link


Copy Markdown

Contributor
cc @manupa-arm could you take a look and merge if everything's OK? Thanks
manupak
manupak
approved these changes
Jan 17, 2022
View reviewed changes
@manupakmanupak
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@manupak
manupak
merged commit 133bb9c
into
apache:mainJan 17, 2022
@manupak
manupak
commented
Jan 17, 2022

Copy link


Copy Markdown

Contributor
Thanks! @jacobbohlin@mbaret
yuanfz98 pushed a commit
to yuanfz98/tvm
that referenced
this pull request
Jan 24, 2022
@jacobbohlin@yuanfz98
[microNPU][2c] Add performance modelling to cascader (apache#9778)
e34e9e6
* [microNPU][2c] Initial Performance Model
* Added the pre-computed performance modelling per block.
* Added the aggregation of cycles given a stripe config.
* Implemented the op-specific performance code for conv2d.
* Created a DeviceConfig class to hold constant performance related data
that is dependent on the accelerator configuration
* Added generation of all valid block configs. This is pre-computed and
given as an argument when constructing EthosuParts.
* Implemented selection of the block config that gives the least amount
of data read given a StripeConfig.
* Add test guards
* Extended block config testing
crazydemo pushed a commit
to crazydemo/tvm
that referenced
this pull request
Jan 27, 2022
@jacobbohlinIvy
[microNPU][2c] Add performance modelling to cascader (apache#9778)
1f10874
* [microNPU][2c] Initial Performance Model
* Added the pre-computed performance modelling per block.
* Added the aggregation of cycles given a stripe config.
* Implemented the op-specific performance code for conv2d.
* Created a DeviceConfig class to hold constant performance related data
that is dependent on the accelerator configuration
* Added generation of all valid block configs. This is pre-computed and
given as an argument when constructing EthosuParts.
* Implemented selection of the block config that gives the least amount
of data read given a StripeConfig.
* Add test guards
* Extended block config testing
ylc pushed a commit
to ylc/tvm
that referenced
this pull request
Feb 16, 2022
@jacobbohlin@ylc
[microNPU][2c] Add performance modelling to cascader (apache#9778)
3ad10b4
* [microNPU][2c] Initial Performance Model
* Added the pre-computed performance modelling per block.
* Added the aggregation of cycles given a stripe config.
* Implemented the op-specific performance code for conv2d.
* Created a DeviceConfig class to hold constant performance related data
that is dependent on the accelerator configuration
* Added generation of all valid block configs. This is pre-computed and
given as an argument when constructing EthosuParts.
* Implemented selection of the block config that gives the least amount
of data read given a StripeConfig.
* Add test guards
* Extended block config testing
@driazatidriazati
mentioned this pull request
Jul 14, 2022

Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@mbaretmbaretmbaret approved these changes
@manupakmanupakmanupak approved these changes
@anijain2305anijain2305Awaiting requested review from anijain2305
@areuschareuschAwaiting requested review from areusch
@comaniaccomaniacAwaiting requested review from comaniac
@icemelonicemelonAwaiting requested review from icemelon
@jroeschjroeschAwaiting requested review from jroesch
@junrushaojunrushaoAwaiting requested review from junrushao
@jwfrommjwfrommAwaiting requested review from jwfromm
@MarisaKirisameMarisaKirisameAwaiting requested review from MarisaKirisame
@mbrookhartmbrookhartAwaiting requested review from mbrookhart
@merrymercymerrymercyAwaiting requested review from merrymercy
@slyubomirskyslyubomirskyAwaiting requested review from slyubomirsky
@tqchentqchenAwaiting requested review from tqchen
@vinx13vinx13Awaiting requested review from vinx13
@wweicwweicAwaiting requested review from wweic
@yzhliuyzhliuAwaiting requested review from yzhliu
@zhiicszhiicsAwaiting requested review from zhiics
@ZihengJiangZihengJiangAwaiting requested review from ZihengJiang

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@jacobbohlin@mbaret@manupak

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
[microNPU][2c] Add performance modelling to cascader by jacobbohlin · Pull Request #9778 · apache/tvm · GitHub
Skip to content
[microNPU][2c] Add performance modelling to cascader - #9778
Merged
manupak merged 3 commits into
apache:mainfrom 
mbaret:ethosu-cascader-4
Jan 17, 2022
Merged
[microNPU][2c] Add performance modelling to cascader#9778
manupak merged 3 commits into
apache:mainfrom 
mbaret:ethosu-cascader-4
Conversation
@jacobbohlin
@jacobbohlinjacobbohlin
commented
Dec 20, 2021

Copy link


Copy Markdown

Contributor
RFC: apache/tvm-rfcs#37

Issue: #9429
NOTE: This PR builds on top of #9469 and #9471 and therefore includes those changes. This PR will remain as 'draft' until both dependencies are merged.
The algorithm described in the RFC uses two metrics for pareto culling, performance and memory usage. This commit addresses the former and introduces the basis of performance estimation for the Parts. It also includes performance estimation code that is specific to ethosu_conv2d.
The output of the performance model is only meant to be consumed by the cascader.
@jacobbohlin
jacobbohlin
commented
Dec 20, 2021

Copy link


Copy Markdown

ContributorAuthor
@mbaret@manupa-arm@NicolaLancellotti
@jacobbohlinjacobbohlin
mentioned this pull request
Dec 21, 2021
 Merged

@mbaret
mbaretforce-pushed
the
ethosu-cascader-4
branch
2 times, most recently
from
77a5b22 to
366aa80CompareDecember 22, 2021 10:54
@mbaret
mbaretforce-pushed
the
ethosu-cascader-4
branch
2 times, most recently
from
1124baf to
35d9164CompareJanuary 4, 2022 15:14
@mbaretmbaret
mentioned this pull request
Jan 5, 2022

Closed

12 tasks
@jacobbohlinjacobbohlin
mentioned this pull request
Jan 5, 2022
 Merged

@jacobbohlin
jacobbohlinforce-pushed
the
ethosu-cascader-4
branch
2 times, most recently
from
6366031 to
426d0aeCompareJanuary 11, 2022 14:36
@jacobbohlin
jacobbohlin
marked this pull request as ready for review
January 11, 2022 14:42
mbaret
mbaret
reviewed
Jan 12, 2022
View reviewed changes
Comment threadsrc/contrib/ethosu/cascader/parts/ethosu.cc

Comment on lines

71
 to 
121

 for (size_t i = 0; i < block_shape.size(); i++) {
 if (!is_rolling) {
 num_blocks *= output_stripe_config->GetShape()[i] * output_stripe_config->GetStripes()[i] /
 if (buffer_mode == BufferMode::RECOMPUTE) {
 num_blocks *= static_cast<float>(output_stripe_config->GetShape()[i] *
 output_stripe_config->GetStripes()[i]) /
 block_shape[i];
 } else {
 num_blocks *= output_stripe_config->GetExtent()[i] / block_shape[i];
 num_blocks *= static_cast<float>(output_stripe_config->GetExtent()[i]) / block_shape[i];
 }
 }
@mbaretmbaretJan 12, 2022

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to mention that this logic is placeholder and will be replaced in a later patch.
@mbaret
mbaret
commented
Jan 12, 2022

Copy link


Copy Markdown

Contributor
Just a quick note on the test coverage of this feature. The results of the performance model are not explicitly tested against the FVP because we don’t have performance instrumentation available in CI. We will however be testing this component downstream where such instrumentation is available.
@jacobbohlin
[microNPU][2c] Initial Performance Model
3a030d2
* Added the pre-computed performance modelling per block.
* Added the aggregation of cycles given a stripe config.
* Implemented the op-specific performance code for conv2d.
* Created a DeviceConfig class to hold constant performance related data
that is dependent on the accelerator configuration
* Added generation of all valid block configs. This is pre-computed and
given as an argument when constructing EthosuParts.
* Implemented selection of the block config that gives the least amount
of data read given a StripeConfig.
@jacobbohlin
Add test guards
13f2eb6
@jacobbohlin
Extended block config testing
e1daf76
@mbaret
mbaret
commented
Jan 17, 2022

Copy link


Copy Markdown

Contributor
cc @manupa-arm could you take a look and merge if everything's OK? Thanks
manupak
manupak
approved these changes
Jan 17, 2022
View reviewed changes
@manupakmanupak
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@manupak
manupak
merged commit 133bb9c
into
apache:mainJan 17, 2022
@manupak
manupak
commented
Jan 17, 2022

Copy link


Copy Markdown

Contributor
Thanks! @jacobbohlin@mbaret
yuanfz98 pushed a commit
to yuanfz98/tvm
that referenced
this pull request
Jan 24, 2022
@jacobbohlin@yuanfz98
[microNPU][2c] Add performance modelling to cascader (apache#9778)
e34e9e6
* [microNPU][2c] Initial Performance Model
* Added the pre-computed performance modelling per block.
* Added the aggregation of cycles given a stripe config.
* Implemented the op-specific performance code for conv2d.
* Created a DeviceConfig class to hold constant performance related data
that is dependent on the accelerator configuration
* Added generation of all valid block configs. This is pre-computed and
given as an argument when constructing EthosuParts.
* Implemented selection of the block config that gives the least amount
of data read given a StripeConfig.
* Add test guards
* Extended block config testing
crazydemo pushed a commit
to crazydemo/tvm
that referenced
this pull request
Jan 27, 2022
@jacobbohlinIvy
[microNPU][2c] Add performance modelling to cascader (apache#9778)
1f10874
* [microNPU][2c] Initial Performance Model
* Added the pre-computed performance modelling per block.
* Added the aggregation of cycles given a stripe config.
* Implemented the op-specific performance code for conv2d.
* Created a DeviceConfig class to hold constant performance related data
that is dependent on the accelerator configuration
* Added generation of all valid block configs. This is pre-computed and
given as an argument when constructing EthosuParts.
* Implemented selection of the block config that gives the least amount
of data read given a StripeConfig.
* Add test guards
* Extended block config testing
ylc pushed a commit
to ylc/tvm
that referenced
this pull request
Feb 16, 2022
@jacobbohlin@ylc
[microNPU][2c] Add performance modelling to cascader (apache#9778)
3ad10b4
* [microNPU][2c] Initial Performance Model
* Added the pre-computed performance modelling per block.
* Added the aggregation of cycles given a stripe config.
* Implemented the op-specific performance code for conv2d.
* Created a DeviceConfig class to hold constant performance related data
that is dependent on the accelerator configuration
* Added generation of all valid block configs. This is pre-computed and
given as an argument when constructing EthosuParts.
* Implemented selection of the block config that gives the least amount
of data read given a StripeConfig.
* Add test guards
* Extended block config testing
@driazatidriazati
mentioned this pull request
Jul 14, 2022

Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@mbaretmbaretmbaret approved these changes
@manupakmanupakmanupak approved these changes
@anijain2305anijain2305Awaiting requested review from anijain2305
@areuschareuschAwaiting requested review from areusch
@comaniaccomaniacAwaiting requested review from comaniac
@icemelonicemelonAwaiting requested review from icemelon
@jroeschjroeschAwaiting requested review from jroesch
@junrushaojunrushaoAwaiting requested review from junrushao
@jwfrommjwfrommAwaiting requested review from jwfromm
@MarisaKirisameMarisaKirisameAwaiting requested review from MarisaKirisame
@mbrookhartmbrookhartAwaiting requested review from mbrookhart
@merrymercymerrymercyAwaiting requested review from merrymercy
@slyubomirskyslyubomirskyAwaiting requested review from slyubomirsky
@tqchentqchenAwaiting requested review from tqchen
@vinx13vinx13Awaiting requested review from vinx13
@wweicwweicAwaiting requested review from wweic
@yzhliuyzhliuAwaiting requested review from yzhliu
@zhiicszhiicsAwaiting requested review from zhiics
@ZihengJiangZihengJiangAwaiting requested review from ZihengJiang

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@jacobbohlin@mbaret@manupak

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
[microNPU][2c] Add performance modelling to cascader by jacobbohlin · Pull Request #9778 · apache/tvm · GitHub
Skip to content
[microNPU][2c] Add performance modelling to cascader - #9778
Merged
manupak merged 3 commits into
apache:mainfrom 
mbaret:ethosu-cascader-4
Jan 17, 2022
Merged
[microNPU][2c] Add performance modelling to cascader#9778
manupak merged 3 commits into
apache:mainfrom 
mbaret:ethosu-cascader-4
Conversation
@jacobbohlin
@jacobbohlinjacobbohlin
commented
Dec 20, 2021

Copy link


Copy Markdown

Contributor
RFC: apache/tvm-rfcs#37

Issue: #9429
NOTE: This PR builds on top of #9469 and #9471 and therefore includes those changes. This PR will remain as 'draft' until both dependencies are merged.
The algorithm described in the RFC uses two metrics for pareto culling, performance and memory usage. This commit addresses the former and introduces the basis of performance estimation for the Parts. It also includes performance estimation code that is specific to ethosu_conv2d.
The output of the performance model is only meant to be consumed by the cascader.
@jacobbohlin
jacobbohlin
commented
Dec 20, 2021

Copy link


Copy Markdown

ContributorAuthor
@mbaret@manupa-arm@NicolaLancellotti
@jacobbohlinjacobbohlin
mentioned this pull request
Dec 21, 2021
 Merged

@mbaret
mbaretforce-pushed
the
ethosu-cascader-4
branch
2 times, most recently
from
77a5b22 to
366aa80CompareDecember 22, 2021 10:54
@mbaret
mbaretforce-pushed
the
ethosu-cascader-4
branch
2 times, most recently
from
1124baf to
35d9164CompareJanuary 4, 2022 15:14
@mbaretmbaret
mentioned this pull request
Jan 5, 2022

Closed

12 tasks
@jacobbohlinjacobbohlin
mentioned this pull request
Jan 5, 2022
 Merged

@jacobbohlin
jacobbohlinforce-pushed
the
ethosu-cascader-4
branch
2 times, most recently
from
6366031 to
426d0aeCompareJanuary 11, 2022 14:36
@jacobbohlin
jacobbohlin
marked this pull request as ready for review
January 11, 2022 14:42
mbaret
mbaret
reviewed
Jan 12, 2022
View reviewed changes
Comment threadsrc/contrib/ethosu/cascader/parts/ethosu.cc

Comment on lines

71
 to 
121

 for (size_t i = 0; i < block_shape.size(); i++) {
 if (!is_rolling) {
 num_blocks *= output_stripe_config->GetShape()[i] * output_stripe_config->GetStripes()[i] /
 if (buffer_mode == BufferMode::RECOMPUTE) {
 num_blocks *= static_cast<float>(output_stripe_config->GetShape()[i] *
 output_stripe_config->GetStripes()[i]) /
 block_shape[i];
 } else {
 num_blocks *= output_stripe_config->GetExtent()[i] / block_shape[i];
 num_blocks *= static_cast<float>(output_stripe_config->GetExtent()[i]) / block_shape[i];
 }
 }
@mbaretmbaretJan 12, 2022

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to mention that this logic is placeholder and will be replaced in a later patch.
@mbaret
mbaret
commented
Jan 12, 2022

Copy link


Copy Markdown

Contributor
Just a quick note on the test coverage of this feature. The results of the performance model are not explicitly tested against the FVP because we don’t have performance instrumentation available in CI. We will however be testing this component downstream where such instrumentation is available.
@jacobbohlin
[microNPU][2c] Initial Performance Model
3a030d2
* Added the pre-computed performance modelling per block.
* Added the aggregation of cycles given a stripe config.
* Implemented the op-specific performance code for conv2d.
* Created a DeviceConfig class to hold constant performance related data
that is dependent on the accelerator configuration
* Added generation of all valid block configs. This is pre-computed and
given as an argument when constructing EthosuParts.
* Implemented selection of the block config that gives the least amount
of data read given a StripeConfig.
@jacobbohlin
Add test guards
13f2eb6
@jacobbohlin
Extended block config testing
e1daf76
@mbaret
mbaret
commented
Jan 17, 2022

Copy link


Copy Markdown

Contributor
cc @manupa-arm could you take a look and merge if everything's OK? Thanks
manupak
manupak
approved these changes
Jan 17, 2022
View reviewed changes
@manupakmanupak
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@manupak
manupak
merged commit 133bb9c
into
apache:mainJan 17, 2022
@manupak
manupak
commented
Jan 17, 2022

Copy link


Copy Markdown

Contributor
Thanks! @jacobbohlin@mbaret
yuanfz98 pushed a commit
to yuanfz98/tvm
that referenced
this pull request
Jan 24, 2022
@jacobbohlin@yuanfz98
[microNPU][2c] Add performance modelling to cascader (apache#9778)
e34e9e6
* [microNPU][2c] Initial Performance Model
* Added the pre-computed performance modelling per block.
* Added the aggregation of cycles given a stripe config.
* Implemented the op-specific performance code for conv2d.
* Created a DeviceConfig class to hold constant performance related data
that is dependent on the accelerator configuration
* Added generation of all valid block configs. This is pre-computed and
given as an argument when constructing EthosuParts.
* Implemented selection of the block config that gives the least amount
of data read given a StripeConfig.
* Add test guards
* Extended block config testing
crazydemo pushed a commit
to crazydemo/tvm
that referenced
this pull request
Jan 27, 2022
@jacobbohlinIvy
[microNPU][2c] Add performance modelling to cascader (apache#9778)
1f10874
* [microNPU][2c] Initial Performance Model
* Added the pre-computed performance modelling per block.
* Added the aggregation of cycles given a stripe config.
* Implemented the op-specific performance code for conv2d.
* Created a DeviceConfig class to hold constant performance related data
that is dependent on the accelerator configuration
* Added generation of all valid block configs. This is pre-computed and
given as an argument when constructing EthosuParts.
* Implemented selection of the block config that gives the least amount
of data read given a StripeConfig.
* Add test guards
* Extended block config testing
ylc pushed a commit
to ylc/tvm
that referenced
this pull request
Feb 16, 2022
@jacobbohlin@ylc
[microNPU][2c] Add performance modelling to cascader (apache#9778)
3ad10b4
* [microNPU][2c] Initial Performance Model
* Added the pre-computed performance modelling per block.
* Added the aggregation of cycles given a stripe config.
* Implemented the op-specific performance code for conv2d.
* Created a DeviceConfig class to hold constant performance related data
that is dependent on the accelerator configuration
* Added generation of all valid block configs. This is pre-computed and
given as an argument when constructing EthosuParts.
* Implemented selection of the block config that gives the least amount
of data read given a StripeConfig.
* Add test guards
* Extended block config testing
@driazatidriazati
mentioned this pull request
Jul 14, 2022

Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@mbaretmbaretmbaret approved these changes
@manupakmanupakmanupak approved these changes
@anijain2305anijain2305Awaiting requested review from anijain2305
@areuschareuschAwaiting requested review from areusch
@comaniaccomaniacAwaiting requested review from comaniac
@icemelonicemelonAwaiting requested review from icemelon
@jroeschjroeschAwaiting requested review from jroesch
@junrushaojunrushaoAwaiting requested review from junrushao
@jwfrommjwfrommAwaiting requested review from jwfromm
@MarisaKirisameMarisaKirisameAwaiting requested review from MarisaKirisame
@mbrookhartmbrookhartAwaiting requested review from mbrookhart
@merrymercymerrymercyAwaiting requested review from merrymercy
@slyubomirskyslyubomirskyAwaiting requested review from slyubomirsky
@tqchentqchenAwaiting requested review from tqchen
@vinx13vinx13Awaiting requested review from vinx13
@wweicwweicAwaiting requested review from wweic
@yzhliuyzhliuAwaiting requested review from yzhliu
@zhiicszhiicsAwaiting requested review from zhiics
@ZihengJiangZihengJiangAwaiting requested review from ZihengJiang

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@jacobbohlin@mbaret@manupak

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();
[microNPU][2c] Add performance modelling to cascader by jacobbohlin · Pull Request #9778 · apache/tvm · GitHub
Skip to content
[microNPU][2c] Add performance modelling to cascader - #9778
Merged
manupak merged 3 commits into
apache:mainfrom 
mbaret:ethosu-cascader-4
Jan 17, 2022
Merged
[microNPU][2c] Add performance modelling to cascader#9778
manupak merged 3 commits into
apache:mainfrom 
mbaret:ethosu-cascader-4
Conversation
@jacobbohlin
@jacobbohlinjacobbohlin
commented
Dec 20, 2021

Copy link


Copy Markdown

Contributor
RFC: apache/tvm-rfcs#37

Issue: #9429
NOTE: This PR builds on top of #9469 and #9471 and therefore includes those changes. This PR will remain as 'draft' until both dependencies are merged.
The algorithm described in the RFC uses two metrics for pareto culling, performance and memory usage. This commit addresses the former and introduces the basis of performance estimation for the Parts. It also includes performance estimation code that is specific to ethosu_conv2d.
The output of the performance model is only meant to be consumed by the cascader.
@jacobbohlin
jacobbohlin
commented
Dec 20, 2021

Copy link


Copy Markdown

ContributorAuthor
@mbaret@manupa-arm@NicolaLancellotti
@jacobbohlinjacobbohlin
mentioned this pull request
Dec 21, 2021
 Merged

@mbaret
mbaretforce-pushed
the
ethosu-cascader-4
branch
2 times, most recently
from
77a5b22 to
366aa80CompareDecember 22, 2021 10:54
@mbaret
mbaretforce-pushed
the
ethosu-cascader-4
branch
2 times, most recently
from
1124baf to
35d9164CompareJanuary 4, 2022 15:14
@mbaretmbaret
mentioned this pull request
Jan 5, 2022

Closed

12 tasks
@jacobbohlinjacobbohlin
mentioned this pull request
Jan 5, 2022
 Merged

@jacobbohlin
jacobbohlinforce-pushed
the
ethosu-cascader-4
branch
2 times, most recently
from
6366031 to
426d0aeCompareJanuary 11, 2022 14:36
@jacobbohlin
jacobbohlin
marked this pull request as ready for review
January 11, 2022 14:42
mbaret
mbaret
reviewed
Jan 12, 2022
View reviewed changes
Comment threadsrc/contrib/ethosu/cascader/parts/ethosu.cc

Comment on lines

71
 to 
121

 for (size_t i = 0; i < block_shape.size(); i++) {
 if (!is_rolling) {
 num_blocks *= output_stripe_config->GetShape()[i] * output_stripe_config->GetStripes()[i] /
 if (buffer_mode == BufferMode::RECOMPUTE) {
 num_blocks *= static_cast<float>(output_stripe_config->GetShape()[i] *
 output_stripe_config->GetStripes()[i]) /
 block_shape[i];
 } else {
 num_blocks *= output_stripe_config->GetExtent()[i] / block_shape[i];
 num_blocks *= static_cast<float>(output_stripe_config->GetExtent()[i]) / block_shape[i];
 }
 }
@mbaretmbaretJan 12, 2022

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to mention that this logic is placeholder and will be replaced in a later patch.
@mbaret
mbaret
commented
Jan 12, 2022

Copy link


Copy Markdown

Contributor
Just a quick note on the test coverage of this feature. The results of the performance model are not explicitly tested against the FVP because we don’t have performance instrumentation available in CI. We will however be testing this component downstream where such instrumentation is available.
@jacobbohlin
[microNPU][2c] Initial Performance Model
3a030d2
* Added the pre-computed performance modelling per block.
* Added the aggregation of cycles given a stripe config.
* Implemented the op-specific performance code for conv2d.
* Created a DeviceConfig class to hold constant performance related data
that is dependent on the accelerator configuration
* Added generation of all valid block configs. This is pre-computed and
given as an argument when constructing EthosuParts.
* Implemented selection of the block config that gives the least amount
of data read given a StripeConfig.
@jacobbohlin
Add test guards
13f2eb6
@jacobbohlin
Extended block config testing
e1daf76
@mbaret
mbaret
commented
Jan 17, 2022

Copy link


Copy Markdown

Contributor
cc @manupa-arm could you take a look and merge if everything's OK? Thanks
manupak
manupak
approved these changes
Jan 17, 2022
View reviewed changes
@manupakmanupak
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@manupak
manupak
merged commit 133bb9c
into
apache:mainJan 17, 2022
@manupak
manupak
commented
Jan 17, 2022

Copy link


Copy Markdown

Contributor
Thanks! @jacobbohlin@mbaret
yuanfz98 pushed a commit
to yuanfz98/tvm
that referenced
this pull request
Jan 24, 2022
@jacobbohlin@yuanfz98
[microNPU][2c] Add performance modelling to cascader (apache#9778)
e34e9e6
* [microNPU][2c] Initial Performance Model
* Added the pre-computed performance modelling per block.
* Added the aggregation of cycles given a stripe config.
* Implemented the op-specific performance code for conv2d.
* Created a DeviceConfig class to hold constant performance related data
that is dependent on the accelerator configuration
* Added generation of all valid block configs. This is pre-computed and
given as an argument when constructing EthosuParts.
* Implemented selection of the block config that gives the least amount
of data read given a StripeConfig.
* Add test guards
* Extended block config testing
crazydemo pushed a commit
to crazydemo/tvm
that referenced
this pull request
Jan 27, 2022
@jacobbohlinIvy
[microNPU][2c] Add performance modelling to cascader (apache#9778)
1f10874
* [microNPU][2c] Initial Performance Model
* Added the pre-computed performance modelling per block.
* Added the aggregation of cycles given a stripe config.
* Implemented the op-specific performance code for conv2d.
* Created a DeviceConfig class to hold constant performance related data
that is dependent on the accelerator configuration
* Added generation of all valid block configs. This is pre-computed and
given as an argument when constructing EthosuParts.
* Implemented selection of the block config that gives the least amount
of data read given a StripeConfig.
* Add test guards
* Extended block config testing
ylc pushed a commit
to ylc/tvm
that referenced
this pull request
Feb 16, 2022
@jacobbohlin@ylc
[microNPU][2c] Add performance modelling to cascader (apache#9778)
3ad10b4
* [microNPU][2c] Initial Performance Model
* Added the pre-computed performance modelling per block.
* Added the aggregation of cycles given a stripe config.
* Implemented the op-specific performance code for conv2d.
* Created a DeviceConfig class to hold constant performance related data
that is dependent on the accelerator configuration
* Added generation of all valid block configs. This is pre-computed and
given as an argument when constructing EthosuParts.
* Implemented selection of the block config that gives the least amount
of data read given a StripeConfig.
* Add test guards
* Extended block config testing
@driazatidriazati
mentioned this pull request
Jul 14, 2022

Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@mbaretmbaretmbaret approved these changes
@manupakmanupakmanupak approved these changes
@anijain2305anijain2305Awaiting requested review from anijain2305
@areuschareuschAwaiting requested review from areusch
@comaniaccomaniacAwaiting requested review from comaniac
@icemelonicemelonAwaiting requested review from icemelon
@jroeschjroeschAwaiting requested review from jroesch
@junrushaojunrushaoAwaiting requested review from junrushao
@jwfrommjwfrommAwaiting requested review from jwfromm
@MarisaKirisameMarisaKirisameAwaiting requested review from MarisaKirisame
@mbrookhartmbrookhartAwaiting requested review from mbrookhart
@merrymercymerrymercyAwaiting requested review from merrymercy
@slyubomirskyslyubomirskyAwaiting requested review from slyubomirsky
@tqchentqchenAwaiting requested review from tqchen
@vinx13vinx13Awaiting requested review from vinx13
@wweicwweicAwaiting requested review from wweic
@yzhliuyzhliuAwaiting requested review from yzhliu
@zhiicszhiicsAwaiting requested review from zhiics
@ZihengJiangZihengJiangAwaiting requested review from ZihengJiang

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@jacobbohlin@mbaret@manupak