[Fix] Fix flaky test of #9952 by wrongtest-intellif · Pull Request #9958 · apache/tvm

wrongtest-intellif · 2022-01-18T12:53:55Z

MasterJH5574 · 2022-01-18T13:03:56Z

Thanks @wrongtest for the fix! If you can make sure the indeterminism doesn't happen again, please also kindly revert this hot fix PR (#9956) by removing the "skip" mark and the pytest import.

cc @junrushao1994 @Hzfengsy

MasterJH5574

LGTM. Please take a look at my comment, thanks!

MasterJH5574 · 2022-01-18T13:06:34Z

+ for (const Var& var : cand_vars) {
+ if (!var_set.count(var)) {
+ vars.push_back(var);
+ var_set.insert(var);
+ }
+ }


Personally I recommend using std::find(vars.begin(), vars.end(), var) != vars.end() instead of using a var_set for looking up, because usually we don't have few variables and the map doesn't bring performance improvement :-)

std::find(vars.begin(), vars.end(), var) != vars.end()
Thanks for the advice~ I would change to O(n) search and commit to retrigger CI again.

junrushao

Thanks for fixing this!

* fix to stablize the var orders when solve bounds in region analysis * change to std::find_if since num of vars is generally small

wrongtest-intellif · 2022-01-18T12:53:55Z

fix#9952

MasterJH5574 · 2022-01-18T13:03:56Z

Thanks @wrongtest for the fix! If you can make sure the indeterminism doesn't happen again, please also kindly revert this hot fix PR (#9956) by removing the "skip" mark and the pytest import.

cc @junrushao1994 @Hzfengsy

MasterJH5574

LGTM. Please take a look at my comment, thanks!

MasterJH5574 · 2022-01-18T13:06:34Z

+ for (const Var& var : cand_vars) {
+ if (!var_set.count(var)) {
+ vars.push_back(var);
+ var_set.insert(var);
+ }
+ }


Personally I recommend using std::find(vars.begin(), vars.end(), var) != vars.end() instead of using a var_set for looking up, because usually we don't have few variables and the map doesn't bring performance improvement :-)

std::find(vars.begin(), vars.end(), var) != vars.end()
Thanks for the advice~ I would change to O(n) search and commit to retrigger CI again.

junrushao

Thanks for fixing this!

* fix to stablize the var orders when solve bounds in region analysis * change to std::find_if since num of vars is generally small

wrongtest-intellif · 2022-01-18T12:53:55Z

fix#9952

MasterJH5574 · 2022-01-18T13:03:56Z

Thanks @wrongtest for the fix! If you can make sure the indeterminism doesn't happen again, please also kindly revert this hot fix PR (#9956) by removing the "skip" mark and the pytest import.

cc @junrushao1994 @Hzfengsy

MasterJH5574

LGTM. Please take a look at my comment, thanks!

MasterJH5574 · 2022-01-18T13:06:34Z

+ for (const Var& var : cand_vars) {
+ if (!var_set.count(var)) {
+ vars.push_back(var);
+ var_set.insert(var);
+ }
+ }


Personally I recommend using std::find(vars.begin(), vars.end(), var) != vars.end() instead of using a var_set for looking up, because usually we don't have few variables and the map doesn't bring performance improvement :-)

std::find(vars.begin(), vars.end(), var) != vars.end()
Thanks for the advice~ I would change to O(n) search and commit to retrigger CI again.

junrushao

Thanks for fixing this!

* fix to stablize the var orders when solve bounds in region analysis * change to std::find_if since num of vars is generally small

wrongtest-intellif · 2022-01-18T12:53:55Z

fix#9952

MasterJH5574 · 2022-01-18T13:03:56Z

Thanks @wrongtest for the fix! If you can make sure the indeterminism doesn't happen again, please also kindly revert this hot fix PR (#9956) by removing the "skip" mark and the pytest import.

cc @junrushao1994 @Hzfengsy

MasterJH5574

LGTM. Please take a look at my comment, thanks!

MasterJH5574 · 2022-01-18T13:06:34Z

+ for (const Var& var : cand_vars) {
+ if (!var_set.count(var)) {
+ vars.push_back(var);
+ var_set.insert(var);
+ }
+ }


Personally I recommend using std::find(vars.begin(), vars.end(), var) != vars.end() instead of using a var_set for looking up, because usually we don't have few variables and the map doesn't bring performance improvement :-)

std::find(vars.begin(), vars.end(), var) != vars.end()
Thanks for the advice~ I would change to O(n) search and commit to retrigger CI again.

junrushao

Thanks for fixing this!

* fix to stablize the var orders when solve bounds in region analysis * change to std::find_if since num of vars is generally small

wrongtest-intellif · 2022-01-18T12:53:55Z

fix#9952

MasterJH5574 · 2022-01-18T13:03:56Z

Thanks @wrongtest for the fix! If you can make sure the indeterminism doesn't happen again, please also kindly revert this hot fix PR (#9956) by removing the "skip" mark and the pytest import.

cc @junrushao1994 @Hzfengsy

MasterJH5574

LGTM. Please take a look at my comment, thanks!

MasterJH5574 · 2022-01-18T13:06:34Z

+ for (const Var& var : cand_vars) {
+ if (!var_set.count(var)) {
+ vars.push_back(var);
+ var_set.insert(var);
+ }
+ }


Personally I recommend using std::find(vars.begin(), vars.end(), var) != vars.end() instead of using a var_set for looking up, because usually we don't have few variables and the map doesn't bring performance improvement :-)

std::find(vars.begin(), vars.end(), var) != vars.end()
Thanks for the advice~ I would change to O(n) search and commit to retrigger CI again.

junrushao

Thanks for fixing this!

* fix to stablize the var orders when solve bounds in region analysis * change to std::find_if since num of vars is generally small

wrongtest-intellif · 2022-01-18T12:53:55Z

fix#9952

MasterJH5574 · 2022-01-18T13:03:56Z

Thanks @wrongtest for the fix! If you can make sure the indeterminism doesn't happen again, please also kindly revert this hot fix PR (#9956) by removing the "skip" mark and the pytest import.

cc @junrushao1994 @Hzfengsy

MasterJH5574

LGTM. Please take a look at my comment, thanks!

MasterJH5574 · 2022-01-18T13:06:34Z

+ for (const Var& var : cand_vars) {
+ if (!var_set.count(var)) {
+ vars.push_back(var);
+ var_set.insert(var);
+ }
+ }


Personally I recommend using std::find(vars.begin(), vars.end(), var) != vars.end() instead of using a var_set for looking up, because usually we don't have few variables and the map doesn't bring performance improvement :-)

std::find(vars.begin(), vars.end(), var) != vars.end()
Thanks for the advice~ I would change to O(n) search and commit to retrigger CI again.

junrushao

Thanks for fixing this!

* fix to stablize the var orders when solve bounds in region analysis * change to std::find_if since num of vars is generally small

wrongtest-intellif · 2022-01-18T12:53:55Z

fix#9952

MasterJH5574 · 2022-01-18T13:03:56Z

Thanks @wrongtest for the fix! If you can make sure the indeterminism doesn't happen again, please also kindly revert this hot fix PR (#9956) by removing the "skip" mark and the pytest import.

cc @junrushao1994 @Hzfengsy

MasterJH5574

LGTM. Please take a look at my comment, thanks!

MasterJH5574 · 2022-01-18T13:06:34Z

+ for (const Var& var : cand_vars) {
+ if (!var_set.count(var)) {
+ vars.push_back(var);
+ var_set.insert(var);
+ }
+ }


Personally I recommend using std::find(vars.begin(), vars.end(), var) != vars.end() instead of using a var_set for looking up, because usually we don't have few variables and the map doesn't bring performance improvement :-)

std::find(vars.begin(), vars.end(), var) != vars.end()
Thanks for the advice~ I would change to O(n) search and commit to retrigger CI again.

junrushao

Thanks for fixing this!

* fix to stablize the var orders when solve bounds in region analysis * change to std::find_if since num of vars is generally small

wrongtest-intellif · 2022-01-18T12:53:55Z

fix#9952

MasterJH5574 · 2022-01-18T13:03:56Z

Thanks @wrongtest for the fix! If you can make sure the indeterminism doesn't happen again, please also kindly revert this hot fix PR (#9956) by removing the "skip" mark and the pytest import.

cc @junrushao1994 @Hzfengsy

MasterJH5574

LGTM. Please take a look at my comment, thanks!

MasterJH5574 · 2022-01-18T13:06:34Z

+ for (const Var& var : cand_vars) {
+ if (!var_set.count(var)) {
+ vars.push_back(var);
+ var_set.insert(var);
+ }
+ }


Personally I recommend using std::find(vars.begin(), vars.end(), var) != vars.end() instead of using a var_set for looking up, because usually we don't have few variables and the map doesn't bring performance improvement :-)

std::find(vars.begin(), vars.end(), var) != vars.end()
Thanks for the advice~ I would change to O(n) search and commit to retrigger CI again.

junrushao

Thanks for fixing this!

* fix to stablize the var orders when solve bounds in region analysis * change to std::find_if since num of vars is generally small

wrongtest-intellif requested review from Hzfengsy, ZihengJiang, junrushao, kparzysz-quic, masahi, tqchen and vinx13 as code owners January 18, 2022 12:53

wrongtest-intellif mentioned this pull request Jan 18, 2022
[CI Problem] Flaky Test: tests/python/unittest/test_meta_schedule_schedule_rule_auto_inline.py::test_inline_into_cache#9952
Closed

fix to stablize the var orders when solve bounds in region analysis
a67f850

wrongtest-intellif force-pushed the fix_random_vars_order_in_region_analysis branch from 66852ba to a67f850Compare January 18, 2022 13:00

wrongtest-intellif requested review from areusch, comaniac, icemelon, jroesch, merrymercy and yzhliu as code owners January 18, 2022 13:00

MasterJH5574 approved these changes Jan 18, 2022
View reviewed changes

junrushao approved these changes Jan 18, 2022
View reviewed changes

change to std::find_if since num of vars is generally small
44f1e79

junrushao merged commit 611b430 into apache:mainJan 19, 2022

yuanfz98 pushed a commit to yuanfz98/tvm that referenced this pull request Jan 24, 2022
[Fix] Fix flaky test ofapache#9952(apache#9958)
910d4ee
* fix to stablize the var orders when solve bounds in region analysis * change to std::find_if since num of vars is generally small

crazydemo pushed a commit to crazydemo/tvm that referenced this pull request Jan 27, 2022
[Fix] Fix flaky test ofapache#9952(apache#9958)
75c3248
* fix to stablize the var orders when solve bounds in region analysis * change to std::find_if since num of vars is generally small

ylc pushed a commit to ylc/tvm that referenced this pull request Feb 16, 2022
[Fix] Fix flaky test ofapache#9952(apache#9958)
251c819
* fix to stablize the var orders when solve bounds in region analysis * change to std::find_if since num of vars is generally small