Uh oh!
There was an error while loading. Please reload this page.
[BYOC-DNNL] add support for more ops and fusion patterns - #9995
Conversation
tmoreau89
commented
Jan 20, 2022
CC @apeskov and @mbs-octoml |
crazydemo
commented
Feb 7, 2022
Hi, @apeskov and @mbs-octoml. Could you please take some time to review this PR? Look forward to your comments. |
mbs-octoml
commented
Feb 7, 2022
@mikepapadim can you take a look at a this one, thanks. |
mikepapadim
commented
Feb 7, 2022
I ll take a look! |
crazydemo
commented
Feb 14, 2022
Hi @mikepapadim, do you have any comments? |
crazydemo
commented
Feb 16, 2022
@tmoreau89@mbs-octoml@mikepapadim@masahi Could you please help me review this PR? |
masahi
commented
Feb 16, 2022
I can merge this after you pass CI. |
crazydemo
commented
Feb 16, 2022
|
crazydemo
commented
Feb 16, 2022
Hi @masahi , I wonder which version of OneDNN is used for CI. |
masahi
commented
Feb 16, 2022
tvm/docker/install/ubuntu_install_dnnl.sh Line 24 in 8131364 Probably too old, we should update that first. |
crazydemo
commented
Feb 16, 2022
I will try to update to |
Note that changing the docker script won't immediately update the CI environment (so the build will fail again).You need to send that change separately first like #10179. I can take care of actually updating the ci image. |
crazydemo
commented
Feb 16, 2022
Do I need to submit an RFC, or just submit an independent PR? |
masahi
commented
Feb 16, 2022
No need for another rfc. |
vpirogov
commented
Feb 16, 2022
The latest oneDNN release is v2.5.2 |
crazydemo
commented
Feb 16, 2022
Yes, the latest release version is v2.5.2, but only v2.2 has dnnl_lnx_2.2.0_cpu_gomp.tgz |
crazydemo
commented
Feb 16, 2022
vpirogov
commented
Feb 16, 2022
@crazydemo, right, we stopped publishing binary releases on Github after v2.2. Binaries for later versions are available on conda-forge. |
crazydemo
commented
Feb 16, 2022
@vpirogov Thank you so much! I will update the CI to the latest version. |
crazydemo
commented
Feb 18, 2022
hi @masahi , how can I restart the ci check? |
masahi
commented
Feb 18, 2022
So this is how it works.
CI update is an involved process. So please wait until at least tomorrow. |
crazydemo
commented
Feb 18, 2022
Got it! Thank you for all your help and explanation! |
masahi
commented
Feb 18, 2022
@crazydemo it's ready now. |
Uh oh!
There was an error while loading. Please reload this page.
masahi
commented
Feb 21, 2022
@crazydemo please look at the CI issues. |
Enabled OP List: