Uh oh!
There was an error while loading. Please reload this page.
typo - #1000
Closed
OutOfBedlam wants to merge 6 commits into
Closed
Conversation
jongyoul
commented
Jun 12, 2016
Member
@OutOfBedlam Thanks for the fix. LGTM. The failure of CI looks irrelevant. |
corneadoug
commented
Jun 13, 2016
Contributor
Merging if there is no more discussions |
corneadoug
commented
Jun 14, 2016
Contributor
@OutOfBedlam Could you reverse the last commit? I can't merge it now. |
Member
Last 3 commits needs to be removed by using git interactive rebase, as it's been taken care of under #1009 then this branch can be rebased on latest master. 👍 for what @corneadoug suggests - using separate branch other then master, and rebase it frequetnly on to of the master is a good idea to avoid such commits in future. It would also be great to have more descriptive PR title like |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR for?
bin/zeppelin.sh - typo fix