Skip to content

[MINOR] Small ui modification in notebook actionbar - #1006

Closed
minahlee wants to merge 4 commits into
apache:masterfrom
minahlee:minor/ui_improve
Closed

[MINOR] Small ui modification in notebook actionbar#1006
minahlee wants to merge 4 commits into
apache:masterfrom
minahlee:minor/ui_improve

Conversation

@minahlee

@minahleeminahlee commented Jun 13, 2016•
edited
Loading

Copy link
Copy Markdown
Member

What is this PR for?

Small ui improvements

  • Change keyboard shortcut icon
  • Modify commit container style
  • Change table asc/desc icon
  • Change interpreter create button font

What type of PR is it?

Improvement

Screenshots (if appropriate)

Before
screen shot 2016-06-13 at 12 55 41 pm

After
screen shot 2016-06-13 at 12 55 54 pm

Before
screen shot 2016-06-13 at 1 07 15 pm

After
screen shot 2016-06-13 at 1 07 26 pm

Before
screen shot 2016-06-18 at 11 08 20 am

After
screen shot 2016-06-21 at 2 17 38 am

Before
screen shot 2016-06-14 at 4 43 58 pm

After
screen shot 2016-06-14 at 4 43 20 pm

Before
screen shot 2016-06-14 at 9 38 05 pm

After
screen shot 2016-06-14 at 9 37 34 pm

Questions:

  • Does the licenses files need update? No
  • Is there breaking changes for older versions? No
  • Does this needs documentation? Screenshot needs to be updated

@minahleeminahlee changed the title [MINOR] Small modification in notebook actionbar[MINOR] Small ui modification in notebook actionbarJun 13, 2016
@khalidhuseynov

khalidhuseynov commented Jun 13, 2016

Copy link
Copy Markdown
Member

thanks for fixing this UI issues! LGTM

@corneadoug

corneadoug commented Jun 14, 2016

Copy link
Copy Markdown
Contributor

LGTM

1 similar comment
@astroshim

astroshim commented Jun 14, 2016

Copy link
Copy Markdown
Contributor

LGTM

@AhyoungRyu

AhyoungRyu commented Jun 14, 2016

Copy link
Copy Markdown
Contributor

LGTM 👍

@minahlee

minahlee commented Jun 14, 2016

Copy link
Copy Markdown
MemberAuthor

I made one more change in table ascending, descending icon. Please review.

@AhyoungRyu

AhyoungRyu commented Jun 15, 2016

Copy link
Copy Markdown
Contributor

@minahlee Tested it and looks good :)

@corneadoug

corneadoug commented Jun 15, 2016

Copy link
Copy Markdown
Contributor

Merging if there is no more discussions

@minahlee

minahlee commented Jun 18, 2016•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

Rebased master and updated screenshot in description.

@minahlee
minahleeforce-pushed the minor/ui_improve branch 2 times, most recently from 085d290 to 25629a6CompareJune 21, 2016 04:49
@minahlee

minahlee commented Jun 21, 2016•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

Selenium test passes after rebasing master. Merging if there is no more discussion

asfgit pushed a commit that referenced this pull request Jun 22, 2016
@minahlee
[MINOR] Small ui modification in notebook actionbar
0c51490
### What is this PR for?
Small ui improvements
- Change keyboard shortcut icon
- Modify commit container style
- Change table asc/desc icon
- Change interpreter create button font
### What type of PR is it?
Improvement
### Screenshots (if appropriate)
**Before**
<img width="165" alt="screen shot 2016-06-13 at 12 55 41 pm" src="https://cloud.githubusercontent.com/assets/8503346/16021450/aebc14dc-3167-11e6-91d2-32fa8cd607af.png">
**After**
<img width="164" alt="screen shot 2016-06-13 at 12 55 54 pm" src="https://cloud.githubusercontent.com/assets/8503346/16021451/b159c86a-3167-11e6-9311-b59cfffb3f6b.png">
**Before**
<img width="254" alt="screen shot 2016-06-13 at 1 07 15 pm" src="https://cloud.githubusercontent.com/assets/8503346/16021480/d23661e2-3167-11e6-90f9-44340d5efe8f.png">
**After**
<img width="252" alt="screen shot 2016-06-13 at 1 07 26 pm" src="https://cloud.githubusercontent.com/assets/8503346/16021482/d4cf92ac-3167-11e6-95a0-1eb28d0ed325.png">
**Before**
<img width="82" alt="screen shot 2016-06-18 at 11 08 20 am" src="https://cloud.githubusercontent.com/assets/8503346/16172808/03295cec-3545-11e6-953a-c2c9a48ca841.png">
**After**
<img width="82" alt="screen shot 2016-06-21 at 2 17 38 am" src="https://cloud.githubusercontent.com/assets/8503346/16224348/86c3f73e-3756-11e6-8b50-a4654d738d18.png">
**Before**
<img width="383" alt="screen shot 2016-06-14 at 4 43 58 pm" src="https://cloud.githubusercontent.com/assets/8503346/16063627/60bb32de-324f-11e6-88a3-318575dcafc2.png">
**After**
<img width="384" alt="screen shot 2016-06-14 at 4 43 20 pm" src="https://cloud.githubusercontent.com/assets/8503346/16063628/653316ba-324f-11e6-92ca-b559b62e234c.png">
**Before**
<img width="113" alt="screen shot 2016-06-14 at 9 38 05 pm" src="https://cloud.githubusercontent.com/assets/8503346/16068142/54f5f6d6-3278-11e6-977a-1902a274c1f1.png">
**After**
<img width="105" alt="screen shot 2016-06-14 at 9 37 34 pm" src="https://cloud.githubusercontent.com/assets/8503346/16068144/59344c70-3278-11e6-8038-ff3775cc432a.png">
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? Screenshot needs to be updated
Author: Mina Lee <minalee@apache.org>
Closes#1006 from minahlee/minor/ui_improve and squashes the following commits:
dc6dbe8 [Mina Lee] Change interpreter create button font
72ff26e [Mina Lee] Change table asc desc icon
bbca1ba [Mina Lee] Refine version control action UI
68619f8 [Mina Lee] Change keyboard shortcut icon
(cherry picked from commit fd715c8)
Signed-off-by: Mina Lee <minalee@apache.org>
@minahlee
minahlee deleted the minor/ui_improve branch June 23, 2016 05:46
@minahleeminahlee mentioned this pull request Jun 26, 2016
Closed
asfgit pushed a commit that referenced this pull request Jun 27, 2016
@AhyoungRyu@minahlee
[DOC] Update doc image in Explore Zeppelin UI page
09f0ebd
### What is this PR for?
There were several changes in Zeppelin UI after #860, #1006, #1013, #1081 so update screenshot of documents accordingly.
### What type of PR is it?
Documentation
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
Author: AhyoungRyu <fbdkdud93@hanmail.net>
Author: Mina Lee <mina.hyeji.lee@gmail.com>
Author: Mina Lee <minalee@apache.org>
Closes#1089 from minahlee/doc/ZEPPELIN-1002 and squashes the following commits:
b237caf [Mina Lee] Merge pull request #1 from AhyoungRyu/doc/ZEPPELIN-1002/again
b18544a [AhyoungRyu] Update screenshot images in interpreters.md
add97fb [AhyoungRyu] Update screenshot images in notebookashomepage.md
cdaeb30 [AhyoungRyu] Update screenshot images in index.md
b21444a [AhyoungRyu] Update screenshot images in notebook_authorization.md
b23f7e4 [AhyoungRyu] Update screenshot images in dependencymanagement.md
e7a85f3 [AhyoungRyu] Update screenshot images in lens.md
cecd161 [AhyoungRyu] Update screenshot images in ignite.md
9f8cb71 [AhyoungRyu] Update screenshot images in elasticsearch.md
0c9a688 [AhyoungRyu] Hide dynamicinterpreterloading.md temporarily
a17f31f [Mina Lee] Update doc image in Explore Zeppelin UI page
asfgit pushed a commit that referenced this pull request Jun 27, 2016
@AhyoungRyu@minahlee
[DOC] Update doc image in Explore Zeppelin UI page
961e2a7
### What is this PR for?
There were several changes in Zeppelin UI after #860, #1006, #1013, #1081 so update screenshot of documents accordingly.
### What type of PR is it?
Documentation
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
Author: AhyoungRyu <fbdkdud93@hanmail.net>
Author: Mina Lee <mina.hyeji.lee@gmail.com>
Author: Mina Lee <minalee@apache.org>
Closes#1089 from minahlee/doc/ZEPPELIN-1002 and squashes the following commits:
b237caf [Mina Lee] Merge pull request #1 from AhyoungRyu/doc/ZEPPELIN-1002/again
b18544a [AhyoungRyu] Update screenshot images in interpreters.md
add97fb [AhyoungRyu] Update screenshot images in notebookashomepage.md
cdaeb30 [AhyoungRyu] Update screenshot images in index.md
b21444a [AhyoungRyu] Update screenshot images in notebook_authorization.md
b23f7e4 [AhyoungRyu] Update screenshot images in dependencymanagement.md
e7a85f3 [AhyoungRyu] Update screenshot images in lens.md
cecd161 [AhyoungRyu] Update screenshot images in ignite.md
9f8cb71 [AhyoungRyu] Update screenshot images in elasticsearch.md
0c9a688 [AhyoungRyu] Hide dynamicinterpreterloading.md temporarily
a17f31f [Mina Lee] Update doc image in Explore Zeppelin UI page
(cherry picked from commit 09f0ebd)
Signed-off-by: Mina Lee <minalee@apache.org>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@minahlee@khalidhuseynov@corneadoug@astroshim@AhyoungRyu