Uh oh!
There was an error while loading. Please reload this page.
[Zeppelin-1022] Apply new mechanism to LivyInterpreter - #1028
[Zeppelin-1022] Apply new mechanism to LivyInterpreter#1028prabhjyotsingh wants to merge 5 commits into
Conversation
prabhjyotsingh
commented
Jun 16, 2016
CI fails for unrelated changes |
Looks good to me @prabhjyotsingh if we could point what is the reason of CI failure and link to either PR or existing JIRA issue that handles it - that could help improving our infrastructure a lot \cc @jongyoul as an author of new interpreter registration system for a reivew |
| String confData = gson.toJson(conf); | ||
| String json = executeHTTP(property.getProperty("zeppelin.livy.url") + "/sessions", | ||
| String json = executeHTTP(property.getProperty("livy.host.url") + "/sessions", |
There was a problem hiding this comment.
my thought would be this:
- any property needed by Zeppelin (such as to communicate with another server), it should start with "zeppelin.*"
- any property not used by Zeppelin but by a separate server or framework (eg. spark), it should start with "spark.*"
- the reason is the interpreter can then pass-through properties as-is, for example, spark interpreter can pass all "spark." property to SparkConf (and skip all the zeppelin. ones!)
I think we try to roughly follow that pattern (at least as much as I have seen)
There was a problem hiding this comment.
Fair point, I'll revert this change.
jongyoul
commented
Jun 17, 2016
I've tested it. LGTM |
236854d to
f578a34Compareprabhjyotsingh
commented
Jun 17, 2016
@bzz I was referring to #1034, ZEPPELIN-1009. @jongyoul Thank you for testing it out. |
r-kamath
commented
Jun 17, 2016
@prabhjyotsingh LGTM
Thanks |
prabhjyotsingh
commented
Jun 17, 2016
Will merge this if no more discussion. |
What is this PR for?
Apply new mechanism to LivyInterpreter
What type of PR is it?
[Improvement]
Todos
What is the Jira issue?
Questions: