Skip to content

[ZEPPELIN-1039] updated CreateNewButton Testcase in ParagraphAction - #1053

Closed
cloverhearts wants to merge 1 commit into
apache:masterfrom
cloverhearts:fixed/paragraphActionsIT-AutomaticallyintpTag
Closed

[ZEPPELIN-1039] updated CreateNewButton Testcase in ParagraphAction #1053
cloverhearts wants to merge 1 commit into
apache:masterfrom
cloverhearts:fixed/paragraphActionsIT-AutomaticallyintpTag

Conversation

@cloverhearts

Copy link
Copy Markdown
Member

What is this PR for?

dec31d6
After updating the code, and test cases fail.
The code was modified to add code to the test.

The interpreter automatically name is added, and therefore empty para graph is not generated.

testCreateNewButton(org.apache.zeppelin.integration.ParagraphActionsIT) Time elapsed: 11.069 sec <<< FAILURE!
java.lang.AssertionError: Paragraph is created above
Expected: ""
but: was "%spark "
at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:20)
at org.junit.Assert.assertThat(Assert.java:865)
at org.junit.rules.ErrorCollector$1.call(ErrorCollector.java:65)
at org.junit.rules.ErrorCollector.checkSucceeds(ErrorCollector.java:78)
at org.junit.rules.ErrorCollector.checkThat(ErrorCollector.java:63)
at org.apache.zeppelin.integration.ParagraphActionsIT.testCreateNewButton(ParagraphActionsIT.java:95)
testCreateNewButton(org.apache.zeppelin.integration.ParagraphActionsIT) Time elapsed: 11.069 sec <<< FAILURE!
java.lang.AssertionError: Paragraph is created below
Expected: ""
but: was "%spark "
at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:20)
at org.junit.Assert.assertThat(Assert.java:865)
at org.junit.rules.ErrorCollector$1.call(ErrorCollector.java:65)
at org.junit.rules.ErrorCollector.checkSucceeds(ErrorCollector.java:78)
at org.junit.rules.ErrorCollector.checkThat(ErrorCollector.java:63)
at org.apache.zeppelin.integration.ParagraphActionsIT.testCreateNewButton(ParagraphActionsIT.java:105)

What type of PR is it?

Bug Fix

Todos

  • - Updated Test case (createNewButton - ParagraphActionsIT.java)

What is the Jira issue?

https://issues.apache.org/jira/browse/ZEPPELIN-1039

Questions:

  • Does the licenses files need update? no
  • Is there breaking changes for older versions? no
  • Does this needs documentation? no

This was referenced Jun 21, 2016
@Leemoonsoo

Copy link
Copy Markdown
Member

+1 for merge

@minahlee

Copy link
Copy Markdown
Member

Merging it as hotfix

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@cloverhearts@Leemoonsoo@minahlee