Skip to content

[ZEPPELIN-1045] Apply new mechanism to PythonInterpreter - #1063

Closed
minahlee wants to merge 2 commits into
apache:masterfrom
minahlee:ZEPPELIN-1045
Closed

[ZEPPELIN-1045] Apply new mechanism to PythonInterpreter#1063
minahlee wants to merge 2 commits into
apache:masterfrom
minahlee:ZEPPELIN-1045

Conversation

@minahlee

Copy link
Copy Markdown
Member

What is this PR for?

This PR is applying new interpreter register mechanism to python interpreter.

What type of PR is it?

Improvement

What is the Jira issue?

ZEPPELIN-1045

Questions:

  • Does the licenses files need update? No
  • Is there breaking changes for older versions? No
  • Does this needs documentation? No

@minahlee

Copy link
Copy Markdown
MemberAuthor

\cc @bzz@jongyoul for review

@bzz

bzz commented Jun 22, 2016

Copy link
Copy Markdown
Member

Looks great to me, thank you @minahlee !

Will merge, if there is no more discussion

@bzz

bzz commented Jun 22, 2016

Copy link
Copy Markdown
Member

BTW while we are here, how do you think shall we also set zeppelin.python.maxResult to 1000 in properties, propagate it to PythonInterpreter.java and document it (as with other interpreters)?

@minahlee

Copy link
Copy Markdown
MemberAuthor

@bzz Good suggestion! This will be useful to display dataframe in table view. I addressed it in 66b8f73

@bzz

bzz commented Jun 23, 2016

Copy link
Copy Markdown
Member

Looks awesome to me, thank you!

I think it's ready to merge, if there is no further discussion

@minahlee
minahlee deleted the ZEPPELIN-1045 branch July 22, 2016 10:15
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@minahlee@bzz