Skip to content

ZEPPELIN-1063: fix flaky python interpreter test - #1094

Closed
bzz wants to merge 5 commits into
apache:masterfrom
bzz:fix/python-tests/ZEPPELIN-1063
Closed

ZEPPELIN-1063: fix flaky python interpreter test#1094
bzz wants to merge 5 commits into
apache:masterfrom
bzz:fix/python-tests/ZEPPELIN-1063

Conversation

@bzz

@bzzbzz commented Jun 27, 2016

Copy link
Copy Markdown
Member

What is this PR for?

fix flaky python interpreter test

What type of PR is it?

Bug Fix

Todos

  • cleanup test code
  • fix flaky open port check

What is the Jira issue?

ZEPPELIN-1063

How should this be tested?

mvn "-Dtest=org.apache.zeppelin.python.PythonInterpreterTest" test -pl python

Questions:

  • Does the licenses files need update? No
  • Is there breaking changes for older versions? No
  • Does this needs documentation? No

@bzzbzz changed the title ZEPPELIN-1063: fix flaky python interpreter testWIP - ZEPPELIN-1063: fix flaky python interpreter testJun 27, 2016
@bzz
bzzforce-pushed the fix/python-tests/ZEPPELIN-1063 branch from 0de5320 to 67a2fe6CompareJune 27, 2016 12:23
@bzzbzz changed the title WIP - ZEPPELIN-1063: fix flaky python interpreter testZEPPELIN-1063: fix flaky python interpreter testJun 27, 2016
@bzz

bzz commented Jun 27, 2016

Copy link
Copy Markdown
MemberAuthor

Ready to be merged, \cc @minahlee@prabhjyotsingh for review.

Current CI failure is being taken care of under #1092

@bzz
bzzforce-pushed the fix/python-tests/ZEPPELIN-1063 branch from 67a2fe6 to b9de5a2CompareJune 27, 2016 15:28
@bzz

bzz commented Jun 27, 2016

Copy link
Copy Markdown
MemberAuthor

Rebased on latest master, after #1092 got merged

@bzz

bzz commented Jun 28, 2016

Copy link
Copy Markdown
MemberAuthor

CI fails on Integration tests, and failure looks different from #1091 and #1092

Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 143.455 sec - in org.apache.zeppelin.integration.ZeppelinIT
Results :
Tests in error: ParagraphActionsIT.testClearOutputButton:285->AbstractZeppelinIT.waitForParagraph:70->AbstractZeppelinIT.pollingWait:96 » Timeout
Tests run: 15, Failures: 0, Errors: 1, Skipped: 0

@prabhjyotsingh any chance you you seen this before?

@bzz

bzz commented Jun 28, 2016

Copy link
Copy Markdown
MemberAuthor

CI failure is not related and logged under ZEPPELIN-1073
Merging if there is no further disucssion

@bzz
bzz deleted the fix/python-tests/ZEPPELIN-1063 branch June 28, 2016 10:09
@prabhjyotsingh

Copy link
Copy Markdown
Contributor

Yes, I've seen this, this happens when spark takes longer that 60sec to start up.
Will open up a new jira and fix this as well.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@bzz@prabhjyotsingh