Uh oh!
There was an error while loading. Please reload this page.
[ZEPPELIN-1082] Restore Interpreter page layout change - #1106
Closed
minahlee wants to merge 1 commit into
Closed
Conversation
prabhjyotsingh
commented
Jun 29, 2016
Contributor
Tested, LGTM! |
AhyoungRyu
commented
Jun 29, 2016
Contributor
LGTM 👍 |
astroshim
commented
Jun 29, 2016
Contributor
LGTM |
1 similar comment
corneadoug
commented
Jun 30, 2016
Contributor
LGTM |
prabhjyotsingh
commented
Jun 30, 2016
Contributor
Merging this if no more discussion. |
asfgit pushed a commit
that referenced
this pull request
Jul 2, 2016
### What is this PR for? Apply margin-bottom: 20px on `box` class by removing `home` class ### What type of PR is it? Bug Fix ### What is the Jira issue? [ZEPPELIN-1082](https://issues.apache.org/jira/browse/ZEPPELIN-1082) ### Screenshots (if appropriate) **Before** <img width="1280" alt="screen shot 2016-06-28 at 11 56 16 pm" src="https://cloud.githubusercontent.com/assets/8503346/16443219/554778b6-3d8c-11e6-884f-8a7024e5d3d1.png"> **After** <img width="1280" alt="screen shot 2016-06-28 at 11 56 48 pm" src="https://cloud.githubusercontent.com/assets/8503346/16443239/6142ccc4-3d8c-11e6-914f-87f523bf8275.png"> ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No Author: Mina Lee <minalee@apache.org> Closes#1106 from minahlee/ZEPPELIN-1082 and squashes the following commits: fcace59 [Mina Lee] Remove home class to make space between boxes (cherry picked from commit 3ae7d24) Signed-off-by: Mina Lee <minalee@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR for?
Apply margin-bottom: 20px on
boxclass by removinghomeclassWhat type of PR is it?
Bug Fix
What is the Jira issue?
ZEPPELIN-1082
Screenshots (if appropriate)
Before
After
Questions: