Skip to content

[DOC][MINOR] Add shell interpreter docs to _navigation.html - #1138

Closed
AhyoungRyu wants to merge 4 commits into
apache:masterfrom
AhyoungRyu:improve/shell-docs
Closed

[DOC][MINOR] Add shell interpreter docs to _navigation.html#1138
AhyoungRyu wants to merge 4 commits into
apache:masterfrom
AhyoungRyu:improve/shell-docs

Conversation

@AhyoungRyu

@AhyoungRyuAhyoungRyu commented Jul 6, 2016

Copy link
Copy Markdown
Contributor

What is this PR for?

After #1087 merged, a new docs shell.md was added. But in the docs website, still Shell interpreter link points to pleasecontribute.html. So I changed this link, applied TOC and added more descriptions.

What type of PR is it?

Documentation

Todos

  • - Change pleasecontribute.html -> shell.html
  • - Apply TOC(table of contents)
  • - Add more description to shell.md

Questions:

  • Does the licenses files need update? no
  • Is there breaking changes for older versions? no
  • Does this needs documentation? no

Comment threaddocs/interpreter/shell.md Outdated
Note: Currently each command runs as Zeppelin user.

### Example
> **Note :** Currently each command runs as Zeppelin user.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perhaps it could help to explain "Zeppelin user" as "the user Zeppelin server is running as" (or similar)?

@felixcheung

Copy link
Copy Markdown
Member

LGTM

@fvaleri

Copy link
Copy Markdown
Contributor

@felixcheung agree.
@AhyoungRyu thanks for the integration.

@AhyoungRyu

Copy link
Copy Markdown
ContributorAuthor

@felixcheung I updated shell.md as you suggested :)
I also applied TOC(Table of Contents) to rest-credential.md which is from #1030.

@felixcheung

Copy link
Copy Markdown
Member

LGTM

PhilippGrulich pushed a commit to SWC-SENSE/zeppelin that referenced this pull request Aug 8, 2016
### What is this PR for?
After apache#1087 merged, a new docs `shell.md` was added. But in the docs website, still Shell interpreter link points to `pleasecontribute.html`. So I changed this link, applied TOC and added more descriptions.
### What type of PR is it?
Documentation
### Todos
* [x] - Change `pleasecontribute.html` -> `shell.html`
* [x] - Apply TOC(table of contents)
* [x] - Add more description to `shell.md`
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
Author: AhyoungRyu <fbdkdud93@hanmail.net>
Closesapache#1138 from AhyoungRyu/improve/shell-docs and squashes the following commits:
69d567d [AhyoungRyu] Address @felixcheung feedback
fca76a6 [AhyoungRyu] Apply TOC to rest-credential.md
c8e988b [AhyoungRyu] Change docs group manual -> interpreter
a0bf1d5 [AhyoungRyu] Add shell.html to _navigation.html
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@AhyoungRyu@felixcheung@fvaleri