Uh oh!
There was an error while loading. Please reload this page.
[ZEPPELIN-1179] Append scala version to maven artifacts - #1186
Closed
lresende wants to merge 3 commits into
Closed
Conversation
lresende
commented
Jul 15, 2016
MemberAuthor
This assumes that #747 is merged. |
minahlee
commented
Jul 20, 2016
Member
CI failures seems irrelevant. LGTM merging if there is no more discussion |
minahlee
commented
Jul 20, 2016
Member
I have one question before merging, is there any special reason that ignite doesn't have |
lresende
commented
Jul 20, 2016
MemberAuthor
@minahlee Good catch, let me fix that. |
lresendeforce-pushed
the
scala-version
branch
3 times, most recently
from
July 21, 2016 21:58
4625ff1 to
139e968Comparelresendeforce-pushed
the
scala-version
branch
3 times, most recently
from
July 22, 2016 00:10
8800191 to
05c86d2Comparelresende
commented
Jul 22, 2016
MemberAuthor
@minahlee I have included the missing modules, and also updated the build to change the artifact version to _2.11 when performing the build based on Scala 2.11. The build is still failing with the 10 minutes issue and other issue that seems not related. |
minahlee
commented
Jul 22, 2016
Member
Looks good to me. Merge if there is no more discussion |
asfgit pushed a commit
that referenced
this pull request
Jul 22, 2016
Now that we have support for both Scala 2.10 and 2.11 we need to append Scala version to the maven artifact id in order to properly publish artifacts for both Scala releases. [Improvement] [ZEPPELIN-1179](https://issues.apache.org/jira/browse/ZEPPELIN-1179) Author: Luciano Resende <lresende@apache.org> Closes#1186 from lresende/scala-version and squashes the following commits: 27ec9fe [Luciano Resende] [ZEPPELIN-1179] Properly set scala version during builds 4594607 [Luciano Resende] [ZEPPELIN-1179] Append scala version to remaining maven artifacts 7bed3ec [Luciano Resende] [ZEPPELIN-1179] Append scala version to maven artifacts (cherry picked from commit 6bb4b5b) Signed-off-by: Mina Lee <minalee@apache.org> Conflicts: .travis.yml
asfgit pushed a commit
that referenced
this pull request
Jul 24, 2016
…ala 211 artifacts ### What is this PR for? - Update publish_release.sh to publish scala 2.10 and scala 2.11 artifacts to maven repository. - Set build spark version to 2.0 This PR supposed to work once #1186 and #1195 is merged ### What type of PR is it? Improvement ### What is the Jira issue? [ZEPPELIN-1180](https://issues.apache.org/jira/browse/ZEPPELIN-1180) ### Questions: * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? no Author: Mina Lee <minalee@apache.org> Closes#1209 from minahlee/ZEPPELIN-1180 and squashes the following commits: 40e5718 [Mina Lee] Use underscore as word separator in file name for consistency 0a91932 [Mina Lee] Include all module for scala 2.11 artifact build c1d6439 [Mina Lee] publish 2.11 artifact to maven a7918f0 [Mina Lee] Fix mod from 755 to 644 bca1af1 [Mina Lee] Fix indentation
asfgit pushed a commit
that referenced
this pull request
Jul 24, 2016
…ala 211 artifacts ### What is this PR for? - Update publish_release.sh to publish scala 2.10 and scala 2.11 artifacts to maven repository. - Set build spark version to 2.0 This PR supposed to work once #1186 and #1195 is merged ### What type of PR is it? Improvement ### What is the Jira issue? [ZEPPELIN-1180](https://issues.apache.org/jira/browse/ZEPPELIN-1180) ### Questions: * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? no Author: Mina Lee <minalee@apache.org> Closes#1209 from minahlee/ZEPPELIN-1180 and squashes the following commits: 40e5718 [Mina Lee] Use underscore as word separator in file name for consistency 0a91932 [Mina Lee] Include all module for scala 2.11 artifact build c1d6439 [Mina Lee] publish 2.11 artifact to maven a7918f0 [Mina Lee] Fix mod from 755 to 644 bca1af1 [Mina Lee] Fix indentation (cherry picked from commit 1077921) Signed-off-by: Mina Lee <minalee@apache.org>
PhilippGrulich pushed a commit
to SWC-SENSE/zeppelin
that referenced
this pull request
Aug 8, 2016
### What is this PR for? Now that we have support for both Scala 2.10 and 2.11 we need to append Scala version to the maven artifact id in order to properly publish artifacts for both Scala releases. ### What type of PR is it? [Improvement] ### What is the Jira issue? [ZEPPELIN-1179](https://issues.apache.org/jira/browse/ZEPPELIN-1179) Author: Luciano Resende <lresende@apache.org> Closesapache#1186 from lresende/scala-version and squashes the following commits: 27ec9fe [Luciano Resende] [ZEPPELIN-1179] Properly set scala version during builds 4594607 [Luciano Resende] [ZEPPELIN-1179] Append scala version to remaining maven artifacts 7bed3ec [Luciano Resende] [ZEPPELIN-1179] Append scala version to maven artifacts
PhilippGrulich pushed a commit
to SWC-SENSE/zeppelin
that referenced
this pull request
Aug 8, 2016
…ala 211 artifacts ### What is this PR for? - Update publish_release.sh to publish scala 2.10 and scala 2.11 artifacts to maven repository. - Set build spark version to 2.0 This PR supposed to work once apache#1186 and apache#1195 is merged ### What type of PR is it? Improvement ### What is the Jira issue? [ZEPPELIN-1180](https://issues.apache.org/jira/browse/ZEPPELIN-1180) ### Questions: * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? no Author: Mina Lee <minalee@apache.org> Closesapache#1209 from minahlee/ZEPPELIN-1180 and squashes the following commits: 40e5718 [Mina Lee] Use underscore as word separator in file name for consistency 0a91932 [Mina Lee] Include all module for scala 2.11 artifact build c1d6439 [Mina Lee] publish 2.11 artifact to maven a7918f0 [Mina Lee] Fix mod from 755 to 644 bca1af1 [Mina Lee] Fix indentation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR for?
Now that we have support for both Scala 2.10 and 2.11 we need to append Scala version to the maven artifact id in order to properly publish artifacts for both Scala releases.
What type of PR is it?
[Improvement]
What is the Jira issue?
ZEPPELIN-1179