Skip to content

[ ZEPPELIN-1259 ] create ace.editor configuration manager service object - #1256

Closed
cloverhearts wants to merge 7 commits into
apache:masterfrom
cloverhearts:dev/ZEPPELIN-1259
Closed

[ ZEPPELIN-1259 ] create ace.editor configuration manager service object#1256
cloverhearts wants to merge 7 commits into
apache:masterfrom
cloverhearts:dev/ZEPPELIN-1259

Conversation

@cloverhearts

Copy link
Copy Markdown
Member

What is this PR for?

#1218
Establish a foundation to personalize the code editor settings.
Remove and set of ace.editor included in paragraph.controller.js.

What type of PR is it?

Improve

What is the Jira issue?

https://issues.apache.org/jira/browse/ZEPPELIN-1259

Questions:

  • Does the licenses files need update? no
  • Is there breaking changes for older versions? no
  • Does this needs documentation? no

@cloverhearts

Copy link
Copy Markdown
MemberAuthor

@corneadoug
please, can you review for this pr?
i divided to #1218 pr.

cloverheartsand others added 2 commits August 11, 2016 17:31
# Conflicts:
#	zeppelin-web/src/app/notebook/paragraph/paragraph.controller.js
@cloverhearts

Copy link
Copy Markdown
MemberAuthor

ping

@corneadoug

Copy link
Copy Markdown
Contributor

@cloverhearts Sorry for the delay, I will take a look soon.

@cloverhearts

Copy link
Copy Markdown
MemberAuthor

@corneadoug You're welcome, Thank you!

# Conflicts:
#	zeppelin-web/src/app/notebook/paragraph/paragraph.controller.js
# Conflicts:
#	zeppelin-web/src/app/notebook/paragraph/paragraph.controller.js
@cloverhearts

Copy link
Copy Markdown
MemberAuthor

This feature is not mergeable.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@cloverhearts@corneadoug