Uh oh!
There was an error while loading. Please reload this page.
[MINOR] Removed unused profiles from spark/pom.xml - #1301
Conversation
jongyoul
commented
Aug 8, 2016
jongyoul
commented
Aug 8, 2016
Simplification looks great to me! But one thing is not clear - i.e a MapR profiles are not useful any more? IDK but my guess is that they were added there for the reason (compatibility \w MapR build of Hadoop distro) - we should remove those at least with explanation of the reason, why that is done and how it affects people \w those distro, how do you think? Looks like candidate for |
jongyoul
commented
Aug 10, 2016
@bzz Basically, Spark module doesn't have to need hadoop version because we only use Spark repl, core and so on not including specific hadoop version. spark-dependencies only needs specific hadoop version. Thus, specifying hadoop version is not necessary for it. |
bzz
commented
Aug 11, 2016
Thank you for explanation! Makes sense. Looks great to me. May be it's worth to |
zjffdu
commented
Aug 12, 2016
Definitely should remove profile yarn. I got classpath issue when enabling yarn profile. And we need to update the docs accordingly. |
bzz
commented
Aug 16, 2016
jongyoul
commented
Aug 19, 2016
jongyoul
commented
Aug 19, 2016
And about docs, it never change some behaviour. I think another issue linked above is a better point to update docs. |
| <!-- include sparkr in the build --> | ||
| <profile> | ||
| <id>sparkr</id> |
There was a problem hiding this comment.
Is sparkr needed here ? Because I notice there's another sparkr profile in spark-dependencies/pom.xml
There was a problem hiding this comment.
This is because of selecting interpreter-setting.json if/if not we use sparkR and this is because we have two different SparkR versions.
felixcheung
commented
Aug 19, 2016
I thought we do need |
jongyoul
commented
Aug 19, 2016
@felixcheung What I want to remove is duplicated from spark-dependencies/pom.xml. This deletion never hurt current features. It just removes duplicated codes. |
jongyoul
commented
Aug 22, 2016
Merging if there's no more discussion. |
bzz
commented
Aug 26, 2016
Quick question: just to double-check - this should not affect users following published build instructions like https://www.mapr.com/blog/building-apache-zeppelin-mapr-using-spark-under-yarn , right? In a way like in ZEPPELIN-1353 |
jongyoul
commented
Aug 26, 2016
8de6cf8 to
e55e307Comparee55e307 to
10c7bb7Compare
What is this PR for?
Making spark/pom.xml simple
What type of PR is it?
[Refactoring]
Todos
What is the Jira issue?
N/A
How should this be tested?
No test. CI should be green
Screenshots (if appropriate)
Questions: