Uh oh!
There was an error while loading. Please reload this page.
[ZEPPELIN-1399] Refactor automatic interpreter name insert - #1388
[ZEPPELIN-1399] Refactor automatic interpreter name insert#1388minahlee wants to merge 3 commits into
Conversation
Leemoonsoo
commented
Aug 30, 2016
Tested and LGTM. |
corneadoug
commented
Sep 2, 2016
@minahlee For the first case, it is actually the default interpreter. Another example would be using: |
minahlee
commented
Sep 2, 2016
@corneadoug actually I made it empty intentionally. please check out the discussion here |
corneadoug
commented
Sep 2, 2016
@minahlee Making a new line is a good improvement because some interpreters do not handle same line typing. For removing the default interpreter, I don't have a strong opinion. However it could feel weird to have Release 0.6.1 have the default interpreter shown, 0.6.2 not showing it, then 0.6.3 or 0.7.0 have Interpreter always shown again but this time as part of the paragraph (not in text editor) |
minahlee
commented
Sep 2, 2016
I totally agree that we shouldn't make ux change often. But showing default interpreter in text is implemented only in master branch but not in previous release so I think it won't bring much of confusion. |
954127f to
5313f13Compare…ong interpreter name" This reverts commit b89e35e.
minahlee
commented
Sep 7, 2016
CI is green. Merge if there is no more discussuion |
What is this PR for?
Refine automatic interpreter name insert. See below jira issue for detailed description
What type of PR is it?
Improvement | Refactoring
What is the Jira issue?
ZEPPELIN-1399
Screenshots (if appropriate)
Before
After
Before
After
Questions: