Skip to content

[MINOR] Doc fix for spark interpreter - #1398

Closed
zjffdu wants to merge 5 commits into
apache:masterfrom
zjffdu:spark_doc_fix
Closed

[MINOR] Doc fix for spark interpreter#1398
zjffdu wants to merge 5 commits into
apache:masterfrom
zjffdu:spark_doc_fix

Conversation

@zjffdu

Copy link
Copy Markdown
Contributor

What is this PR for?

Several changes on doc of spark interpreter.

  • %spark, %sql, %pyspark only works when spark is the default interpreter group of note. So I update the doc to use the full interpreter name.
  • Add SparkSession for 2.0
  • Also add comments inline with other changes to explain the reason.

What type of PR is it?

[Documentation]

Todos

  • - Task

What is the Jira issue?

  • No jira created.

Questions:

  • Does the licenses files need update? No
  • Is there breaking changes for older versions? No
  • Does this needs documentation? No

<tr>
<th>spark-defaults.conf</th>
<th>SPARK_SUBMIT_OPTIONS</th>
<th>Applicable Interpreter</th>

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAIK, there settings are applicable for all the spark interpreters. So I remove this column.

@zjffdu

Copy link
Copy Markdown
ContributorAuthor

\cc @Leemoonsoo@AhyoungRyu

@AhyoungRyu

Copy link
Copy Markdown
Contributor

@zjffdu Thank you for updating Spark interpreter docs. Looks great I think 👍
While I look through current Spark documentation page to review this PR, I found some typos, grammar errors and removed useless markdown escaping. So I fixed them based on your branch. If you don't mind, could you check zjffdu#1 out?

@zjffduzjffdu closed this Sep 13, 2016
@AhyoungRyu

Copy link
Copy Markdown
Contributor

@zjffdu Did you close this PR on purpose?

@zjffdu

Copy link
Copy Markdown
ContributorAuthor

Sorry @AhyoungRyu I didn't notice you PR is based on my branch and thought you will merge to master directly.

@zjffduzjffdu reopened this Sep 13, 2016
@AhyoungRyu

Copy link
Copy Markdown
Contributor

@zjffdu It's okay :) LGTM 👍

@AhyoungRyu

Copy link
Copy Markdown
Contributor

Merging into master if there are no more discussions

pedrozatta pushed a commit to pedrozatta/zeppelin that referenced this pull request Oct 27, 2016
### What is this PR for?
Several changes on doc of spark interpreter.
* %spark, %sql, %pyspark only works when spark is the default interpreter group of note. So I update the doc to use the full interpreter name.
* Add SparkSession for 2.0
* Also add comments inline with other changes to explain the reason.
### What type of PR is it?
[Documentation]
### Todos
* [ ] - Task
### What is the Jira issue?
* No jira created.
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
Author: AhyoungRyu <fbdkdud93@hanmail.net>
Author: Jeff Zhang <zjffdu@apache.org>
Author: Jeff Zhang <zjffdu@gmail.com>
Closesapache#1398 from zjffdu/spark_doc_fix and squashes the following commits:
ac01f2b [Jeff Zhang] Merge pull request #1 from AhyoungRyu/spark_doc_fix/ahyoung
5fa523f [AhyoungRyu] Fix typos
3c0f678 [AhyoungRyu] Add 'R' and refine a sentence
2336900 [AhyoungRyu] Improve spark.md
40d4b11 [Jeff Zhang] [MINOR] Doc fix for spark interpreter
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@zjffdu@AhyoungRyu