Skip to content

Fix download links - #1410

Closed
bzz wants to merge 6 commits into
apache:gh-pagesfrom
bzz:fix-download-links
Closed

Fix download links#1410
bzz wants to merge 6 commits into
apache:gh-pagesfrom
bzz:fix-download-links

Conversation

@bzz

@bzzbzz commented Sep 7, 2016

Copy link
Copy Markdown
Member

What is this PR for?

In recent changes download links were broken on the project website

What type of PR is it?

Hot Fix

Todos

How should this be tested?

bundle update
JEKYLL_ENV=production bundle exec jekyll serve

Questions:

  • Does the licenses files need update? No
  • Is there breaking changes for older versions? No
  • Does this needs documentation? Yes, it was

@corneadoug

Copy link
Copy Markdown
Contributor

@bzz Tested:

  • Locally
  • With Production Flag
  • With SVN doc folder

LGTM, let's try to get it merged fast since it is a Hot Fix.

Documentation change for that PR is handled in #1405

@AhyoungRyu

Copy link
Copy Markdown
Contributor

Yeah tested too and it works as expected. LGTM 👍
Let's merge this quickly as a Hotfix.

@bzz

bzz commented Sep 7, 2016

Copy link
Copy Markdown
MemberAuthor

Thank you guys for for the prompt reviews!

Merging it in.

@asfgitasfgit closed this in 97810a0Sep 7, 2016
@bzz
bzz deleted the fix-download-links branch September 7, 2016 07:32
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@bzz@corneadoug@AhyoungRyu