Uh oh!
There was an error while loading. Please reload this page.
[gh-pages][ZEPPELIN-990] Add header anchor to gh-pages branch - #1418
Closed
AhyoungRyu wants to merge 3 commits into
Closed
[gh-pages][ZEPPELIN-990] Add header anchor to gh-pages branch#1418AhyoungRyu wants to merge 3 commits into
AhyoungRyu wants to merge 3 commits into
Conversation
Leemoonsoo
commented
Sep 9, 2016
Member
Tested, When i anchor click the link, that goes under the menubar. I think that need to be adjusted. |
ContributorAuthor
@Leemoonsoo Yeah didn't noticed that. Thanks! Could you check the latest change out again? :D |
Leemoonsoo
commented
Sep 10, 2016
Member
Tested and LGTM |
Leemoonsoo
commented
Sep 13, 2016
Member
Merge if there're no further discussions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR for?
I applied header anchor to Zeppelin's docs website with #995 . It'll be good if
gh-pagesalso has this header anchor.What type of PR is it?
Improvement
What is the Jira issue?
ZEPPELIN-990
How should this be tested?
Run this branch locally as described in here and hover the mouse over any titles.
Screenshots (if appropriate)
Questions: