Uh oh!
There was an error while loading. Please reload this page.
[HOT FIX][ZEPPELIN-1144] Fix compilation errors in Notebook.java - #1432
Closed
AhyoungRyu wants to merge 1 commit into
Closed
[HOT FIX][ZEPPELIN-1144] Fix compilation errors in Notebook.java#1432AhyoungRyu wants to merge 1 commit into
AhyoungRyu wants to merge 1 commit into
Conversation
khalidhuseynov
commented
Sep 17, 2016
Member
looks good, thanks for quick fix! |
Leemoonsoo
commented
Sep 17, 2016
Member
LGTM |
AhyoungRyu
commented
Sep 17, 2016
ContributorAuthor
@khalidhuseynov@Leemoonsoo Thanks for the quick verification. Then will merge this one as a hotfix after CI checking! |
AhyoungRyu
commented
Sep 17, 2016
ContributorAuthor
Only Selenium test failed now. I'm merging this as a hotfix. |
prabhjyotsingh
commented
Sep 17, 2016
Contributor
Tested on local, LGTM. |
Contributor
@Leemoonsoo@prabhjyotsingh@AhyoungRyu This make the compilation fails, which affect other PRs. Could you help do a quick fix on it ? |
Contributor
Please ignore my previous comment, just realize this is for fix the compilation issue. |
pedrozatta pushed a commit
to pedrozatta/zeppelin
that referenced
this pull request
Oct 27, 2016
### What is this PR for? After apache#1330 merged, the latest master build failed with below compilation errors. ``` [ERROR] COMPILATION ERROR : [INFO] ------------------------------------------------------------- [ERROR] /Users/ahyoungryu/Dev/zeppelin/zeppelin-zengine/src/main/java/org/apache/zeppelin/notebook/Notebook.java:[553,31] cannot find symbol symbol: method id() location: variable note1 of type org.apache.zeppelin.notebook.Note [ERROR] /Users/ahyoungryu/Dev/zeppelin/zeppelin-zengine/src/main/java/org/apache/zeppelin/notebook/Notebook.java:[557,31] cannot find symbol symbol: method id() location: variable note2 of type org.apache.zeppelin.notebook.Note ``` ### What type of PR is it? Hot Fix ### What is the Jira issue? ### How should this be tested? - Build the latest master branch with `mvn clean package -DskipTests` -> compilation error in `zeppelin-zengine` - Apply this patch and build with `mvn clean package -DskipTests` -> build success You can also check apache#1330 works properly. ### Questions: * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? no Author: AhyoungRyu <fbdkdud93@hanmail.net> Closesapache#1432 from AhyoungRyu/hotfix/ZEPPELIN-1144 and squashes the following commits: 6a3dbd3 [AhyoungRyu] Fix build error in Notebook.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR for?
After #1330 merged, the latest master build failed with below compilation errors.
What type of PR is it?
Hot Fix
What is the Jira issue?
How should this be tested?
mvn clean package -DskipTests-> compilation error inzeppelin-zenginemvn clean package -DskipTests-> build successYou can also check [ZEPPELIN-1144]Zeppelin home page should only list notebooks with read or write permission #1330 works properly.
Questions: