Uh oh!
There was an error while loading. Please reload this page.
[ZEPPELIN-1483] Zeppelin home page list notebooks doesn't show notebook with group permission - #1454
Closed
prabhjyotsingh wants to merge 3 commits into
Closed
[ZEPPELIN-1483] Zeppelin home page list notebooks doesn't show notebook with group permission#1454prabhjyotsingh wants to merge 3 commits into
prabhjyotsingh wants to merge 3 commits into
Conversation
prabhjyotsinghforce-pushed
the
ZEPPELIN-1483
branch
from
September 25, 2016 04:46
f6a5aea to
d3261c4Compareprabhjyotsingh
commented
Sep 26, 2016
ContributorAuthor
Ready for review. |
| import java.io.IOException; | ||
| import java.io.StringReader; | ||
| import java.util.*; | ||
| import java.util.concurrent.TimeUnit; |
Contributor
There was a problem hiding this comment.
Not needed if we include java.util.*
| import org.apache.zeppelin.user.AuthenticationInfo; | ||
| import org.apache.zeppelin.user.Credentials; | ||
| import org.quartz.*; | ||
| import org.quartz.impl.StdSchedulerFactory; |
Contributor
There was a problem hiding this comment.
Not needed if we include org.quartz.*
| import org.slf4j.LoggerFactory; | ||
| import javax.ws.rs.*; | ||
| import javax.ws.rs.core.Response; |
Contributor
There was a problem hiding this comment.
Not needed if we include javax.ws.rs.*
prabhjyotsingh
commented
Sep 26, 2016
ContributorAuthor
Thank you @corneadoug, have fixed it. |
Member
adding group permissions to listed notes makes sense. tested and works as expected. maybe would makes sense to add integration tests to differentiate the cases of user and groups, maybe in different PR as improvement. CI looks irrelevant, LGTM |
prabhjyotsingh
commented
Sep 29, 2016
ContributorAuthor
Merging this if no more discussion. |
# Conflicts: # zeppelin-server/src/main/java/org/apache/zeppelin/socket/NotebookServer.java # zeppelin-zengine/src/test/java/org/apache/zeppelin/notebook/NotebookTest.java
darionyaphet pushed a commit
to darionyaphet/zeppelin
that referenced
this pull request
Oct 27, 2016
…ok with group permission ### What is this PR for? Zeppelin home page list notebooks doesn't show notebook with group permission ### What type of PR is it? [Bug Fix] ### Todos * [x] - consume userAndRole instead of AuthenticationInfo ### What is the Jira issue? * [ZEPPELIN-1483](https://issues.apache.org/jira/browse/ZEPPELIN-1483) ### How should this be tested? In current scenario only those notebook lists that have direct user permission, those with group does not list up, but if user have link to those notebook, it can still be accessed. IMO the notebook with group permission should also be listed in the home screen. ### Screenshots (if appropriate)  ### Questions: * Does the licenses files need update? n/a * Is there breaking changes for older versions? n/a * Does this needs documentation? n/a Author: Prabhjyot Singh <prabhjyotsingh@gmail.com> Author: Prabhjyot Singh <prabhjyotsingh@gmail.org> Closesapache#1454 from prabhjyotsingh/ZEPPELIN-1483 and squashes the following commits: 2484833 [Prabhjyot Singh] Merge remote-tracking branch 'origin/master' into ZEPPELIN-1483 c8d810e [Prabhjyot Singh] organise imports d3261c4 [Prabhjyot Singh] consume userAndRole instead of AuthenticationInfo
pedrozatta pushed a commit
to pedrozatta/zeppelin
that referenced
this pull request
Oct 27, 2016
…ok with group permission ### What is this PR for? Zeppelin home page list notebooks doesn't show notebook with group permission ### What type of PR is it? [Bug Fix] ### Todos * [x] - consume userAndRole instead of AuthenticationInfo ### What is the Jira issue? * [ZEPPELIN-1483](https://issues.apache.org/jira/browse/ZEPPELIN-1483) ### How should this be tested? In current scenario only those notebook lists that have direct user permission, those with group does not list up, but if user have link to those notebook, it can still be accessed. IMO the notebook with group permission should also be listed in the home screen. ### Screenshots (if appropriate)  ### Questions: * Does the licenses files need update? n/a * Is there breaking changes for older versions? n/a * Does this needs documentation? n/a Author: Prabhjyot Singh <prabhjyotsingh@gmail.com> Author: Prabhjyot Singh <prabhjyotsingh@gmail.org> Closesapache#1454 from prabhjyotsingh/ZEPPELIN-1483 and squashes the following commits: 2484833 [Prabhjyot Singh] Merge remote-tracking branch 'origin/master' into ZEPPELIN-1483 c8d810e [Prabhjyot Singh] organise imports d3261c4 [Prabhjyot Singh] consume userAndRole instead of AuthenticationInfo
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR for?
Zeppelin home page list notebooks doesn't show notebook with group permission
What type of PR is it?
[Bug Fix]
Todos
What is the Jira issue?
How should this be tested?
In current scenario only those notebook lists that have direct user permission, those with group does not list up, but if user have link to those notebook, it can still be accessed.
IMO the notebook with group permission should also be listed in the home screen.
Screenshots (if appropriate)
Questions: