Skip to content

[ZEPPELIN-1487] Resolve possible NPEs in storage sync mechanism - #1459

Closed
khalidhuseynov wants to merge 1 commit into
apache:masterfrom
khalidhuseynov:fix/storage-npe
Closed

[ZEPPELIN-1487] Resolve possible NPEs in storage sync mechanism#1459
khalidhuseynov wants to merge 1 commit into
apache:masterfrom
khalidhuseynov:fix/storage-npe

Conversation

@khalidhuseynov

Copy link
Copy Markdown
Member

What is this PR for?

This is to resolve possible NPEs in storage mechanism related to empty subject

What type of PR is it?

Bug Fix

Todos

  • - pass subject instead of null

What is the Jira issue?

ZEPPELIN-1487

How should this be tested?

storage tests pass, CI green

Screenshots (if appropriate)

Questions:

  • Does the licenses files need update? no
  • Is there breaking changes for older versions? no
  • Does this needs documentation? no

@khalidhuseynovkhalidhuseynov changed the title pass subject to get method in sync[ZEPPELIN-1487] Resolve possible NPEs in storage sync mechanismSep 26, 2016
@khalidhuseynov
khalidhuseynovforce-pushed the fix/storage-npe branch 3 times, most recently from 6c79617 to ba7a0c9CompareSeptember 27, 2016 05:02
@khalidhuseynov

Copy link
Copy Markdown
MemberAuthor

ping

@Leemoonsoo

Copy link
Copy Markdown
Member

LGTM and merge if there're no more discussions.

@khalidhuseynov
khalidhuseynov deleted the fix/storage-npe branch October 18, 2016 03:14
darionyaphet pushed a commit to darionyaphet/zeppelin that referenced this pull request Oct 27, 2016
### What is this PR for?
This is to resolve possible NPEs in storage mechanism related to empty subject
### What type of PR is it?
Bug Fix
### Todos
* [x] - pass `subject` instead of `null`
### What is the Jira issue?
[ZEPPELIN-1487](https://issues.apache.org/jira/browse/ZEPPELIN-1487)
### How should this be tested?
storage tests pass, CI green
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
Author: Khalid Huseynov <khalidhnv@gmail.com>
Closesapache#1459 from khalidhuseynov/fix/storage-npe and squashes the following commits:
1f2dcd3 [Khalid Huseynov] pass subject to get method in sync
pedrozatta pushed a commit to pedrozatta/zeppelin that referenced this pull request Oct 27, 2016
### What is this PR for?
This is to resolve possible NPEs in storage mechanism related to empty subject
### What type of PR is it?
Bug Fix
### Todos
* [x] - pass `subject` instead of `null`
### What is the Jira issue?
[ZEPPELIN-1487](https://issues.apache.org/jira/browse/ZEPPELIN-1487)
### How should this be tested?
storage tests pass, CI green
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
Author: Khalid Huseynov <khalidhnv@gmail.com>
Closesapache#1459 from khalidhuseynov/fix/storage-npe and squashes the following commits:
1f2dcd3 [Khalid Huseynov] pass subject to get method in sync
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@khalidhuseynov@Leemoonsoo