Uh oh!
There was an error while loading. Please reload this page.
[ZEPPELIN-1490] pass subject while persisting note on running status change - #1460
Closed
khalidhuseynov wants to merge 4 commits into
Closed
[ZEPPELIN-1490] pass subject while persisting note on running status change#1460khalidhuseynov wants to merge 4 commits into
khalidhuseynov wants to merge 4 commits into
Conversation
Leemoonsoo
commented
Sep 26, 2016
Member
Could you make CI green? |
khalidhuseynovforce-pushed
the
storage/run-subject-npe
branch
from
September 27, 2016 02:43
8e740ff to
5b336c3Comparekhalidhuseynov
commented
Sep 27, 2016
MemberAuthor
@Leemoonsoo done |
khalidhuseynovforce-pushed
the
storage/run-subject-npe
branch
from
September 29, 2016 03:54
5b336c3 to
0fe1aaaComparekhalidhuseynov
commented
Oct 10, 2016
MemberAuthor
ping |
bzz
commented
Oct 18, 2016
Member
Looks good to me. CI is green now. What do you think, @Leemoonsoo ? |
khalidhuseynov
commented
Oct 18, 2016
MemberAuthor
there could be another option of casting |
assume job to be instance of Paragraph
khalidhuseynov
commented
Oct 18, 2016
MemberAuthor
@Leemoonsoo changed it to extract from incoming job, that should be normally an instance of Paragraph. |
khalidhuseynov
commented
Oct 24, 2016
MemberAuthor
similar approach was used as a part of #1265 to address this issue and is merged already, closing this one |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR for?
This PR makes sure correct subject passed to
note.persist. The subject is obtained from the paragraph levelauthInfobased on the job running.What type of PR is it?
Bug Fix
Todos
What is the Jira issue?
ZEPPELIN-1490
How should this be tested?
CI is green
Screenshots (if appropriate)
Questions: