[Zeppelin 796] Duplicated notebook names should not be allowed

[ghost]

What is this PR for?

When a notebook is created/cloned/imported the title/name of the new notebook should not be duplicate of the existing notebook's title/name

What type of PR is it?

Improvement

Todos

• - Task

What is the Jira issue?

https://issues.apache.org/jira/browse/ZEPPELIN-796

How should this be tested?

1. Create a notebook with name 'Note', Notebook should allow user to create a note
2. When a user try to create/clone/import a notebook with name 'Note', Notebook should not
   allow user to create note.

Screenshots (if appropriate)

Screenshot of error message displayed during create/clone notebook

Screenshot of error message displayed during import notebook

Questions:

• Does the licenses files need update? No
• Is there breaking changes for older versions? No
• Does this needs documentation? No

[felixcheung]

shouldn't it rethrow the exception? would the caller expect an exception like IOException?

[ghost]

For all websocket requests, we are sending responses from notebookServer class. So, i believe as a standard we should handle the response in the same file. So, rethrowing the exception wouldn't serve that purpose.

[khalidhuseynov]

@rajarajan-g why do you think it's a problem having same note title/name with existing one. could you give more context?

[ghost]

@khalidhuseynov : Lets say if i create a note with name 'Note'. If zeppelin allows me to create a new note with name 'Note', then after sometime when i search for one of this note, I am going to get confused here.

[ghost]

Going to reopen the pull request to trigger CI build

[ghost]

CI build is green & success. Please review

[jongyoul]

I think this PR contains wrong changes like JDBC*. Is it correct?

[corneadoug]

@rajarajan-g How do you handle if another user with same notebook name decides to gives you read ability on his notebook?

[ghost]

@jongyoul : Thanks for noticing that. I didn't make those changes. Those changes seems to come from another commit. Need to check that

[ghost]

@corneadoug : Nice catch. I didn't check that scenario. Will let you once, i figure out a way.
Let me check the current implementation too.

[corneadoug]

Well the problem here is that there is really nothing you can do, you are not going to change your Notebook name, or somebody else notebook name because both name are the same

[ghost]

@jongyoul : Hey i was quite busy for sometime.

I was trying to resolve the commit issues that you have pointed out.

but while during rebase i am getting below error

git rebase master
First, rewinding head to replay your work on top of it...
Applying: Code changes for ZEPPELIN-796
Using index info to reconstruct a base tree...
M zeppelin-server/src/main/java/org/apache/zeppelin/socket/NotebookServer.java
M zeppelin-web/src/components/noteName-create/notename.controller.js
M zeppelin-web/src/components/noteName-import/note-import-dialog.html
M zeppelin-web/src/components/noteName-import/notenameImport.controller.js
M zeppelin-web/src/components/websocketEvents/websocketEvents.factory.js
<stdin>:18: trailing whitespace.
* @throws DuplicateNameException <stdin>:40: trailing whitespace.
* @throws DuplicateNameException <stdin>:98: trailing whitespace.
* @throws DuplicateNameException <stdin>:175: trailing whitespace.
<stdin>:187: trailing whitespace.
conn.send(serializeMessage(new Message(OP.ERROR_DIALOG).put("info", warning: squelched 21 whitespace errors
warning: 26 lines add whitespace errors.
Falling back to patching base and 3-way merge...
Auto-merging zeppelin-web/src/components/websocketEvents/websocketEvents.factory.js
CONFLICT (content): Merge conflict in zeppelin-web/src/components/websocketEvents/websocketEvents.factory.js
Auto-merging zeppelin-web/src/components/noteName-import/notenameImport.controller.js
CONFLICT (content): Merge conflict in zeppelin-web/src/components/noteName-import/notenameImport.controller.js
Auto-merging zeppelin-web/src/components/noteName-import/note-import-dialog.html
Auto-merging zeppelin-web/src/components/noteName-create/notename.controller.js
CONFLICT (content): Merge conflict in zeppelin-web/src/components/noteName-create/notename.controller.js
Auto-merging zeppelin-server/src/main/java/org/apache/zeppelin/socket/NotebookServer.java
Failed to merge in the changes.
Patch failed at 0001 Code changes for ZEPPELIN-796
The copy of the patch that failed is found in:
/home/rajarajang/Workspace/stsWorksapce/zeppelin/.git/rebase-apply/patch
When you have resolved this problem, run "git rebase --continue".
If you prefer to skip this patch, run "git rebase --skip" instead.
To check out the original branch and stop rebasing, run "git rebase --abort".

Even though after i resolve the conflicts, again it shows conflict again and not able to remove that unnecessary commit that you pointed out. Please help me out on resolving that issue

Please let me know if anyone has faced this issue and also please let me if there is a way to resolve this issue.

[ghost]

@corneadoug : If a user creates a note with same name, it would do no good to that user itself as it confuses him.

For resolving the scenario, we can pick one of the below ways

1. we should have one unique notebook name across the server.(Not quite a solution)
2. we can follow unique notebook name per user in server.
   In case if a note is shared by the creator with other users, an extra information should be available to user like below in home page of notebook

NoteName(created by user1)

[ghost]

Hi All,
An unknown commit got merged into this PR. I just had this issue while rebasing. I am going to open new PR for the same.So, Closing this PR . Please continue the discussion in the new PR #1536