Uh oh!
There was an error while loading. Please reload this page.
[branch-0.6] Take care of comma/tab escape in csv/tsv download - #1484
Closed
minahlee wants to merge 4 commits into
Closed
[branch-0.6] Take care of comma/tab escape in csv/tsv download#1484minahlee wants to merge 4 commits into
minahlee wants to merge 4 commits into
Conversation
minahleeforce-pushed
the
branch-0.6_ZEPPELIN-1001
branch
from
October 5, 2016 06:36
33d447c to
58fda8eCompareLeemoonsoo
commented
Oct 5, 2016
Member
LGTM |
minahlee
commented
Oct 6, 2016
MemberAuthor
Merging it into branch-0.6 |
asfgit pushed a commit
that referenced
this pull request
Oct 6, 2016
### What is this PR for? This PR backports #1445 to branch-0.6 since using `./dev/test_zeppelin_pr.py` throws alert for backporting it. ### What type of PR is it? Bug Fix Author: meenakshisekar <meenakshi.chandrasekar@imaginea.com> Closes#1484 from minahlee/branch-0.6_ZEPPELIN-1001 and squashes the following commits: 58fda8e [meenakshisekar] Formatting errors corrected for build f5c7f61 [meenakshisekar] Changes committed as per review comments in PR e404075 [meenakshisekar] Altered the code as per PR suggestion 1465 574803c [meenakshisekar] Zeppelin-1001 Modified the data with comma/tab to be surronded by double quotes so that they are escaped.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR for?
This PR backports #1445 to branch-0.6 since using
./dev/test_zeppelin_pr.pythrows alert for backporting it.What type of PR is it?
Bug Fix