Uh oh!
There was an error while loading. Please reload this page.
[ZEPPELIN-1552] Search button goes to next line when display's width shortens. - #1525
Closed
hyonzin wants to merge 3 commits into
Closed
[ZEPPELIN-1552] Search button goes to next line when display's width shortens.#1525hyonzin wants to merge 3 commits into
hyonzin wants to merge 3 commits into
Conversation
tae-jun
commented
Oct 15, 2016
Contributor
LGTM |
Contributor
@hyonzin Thanks for your contribution and good catch :) Just tested and it seems not working as expected in my 13 inch screen. (FYI 13inch -> about 1248px)
So I worked around a bit to fix this. You can check it in my branch. With my change it will be like this.
If you have time, please check this and let me know how it is! :D |
hyonzin
commented
Oct 15, 2016
ContributorAuthor
@AhyoungRyu Thank you for your reply and good suggestion. I checked that in your branch and It seems to work very well! |
AhyoungRyu
commented
Oct 15, 2016
Contributor
@hyonzin Thx for your prompt response! LGTM 👍 |
tae-jun
commented
Oct 15, 2016
Contributor
CI is green light! Merge please @AhyoungRyu ! 😄 |
AhyoungRyu
commented
Oct 16, 2016
Contributor
hyonzin
commented
Oct 16, 2016
ContributorAuthor
@AhyoungRyu@tae-jun Thanks for you verification 😀 |
darionyaphet pushed a commit
to darionyaphet/zeppelin
that referenced
this pull request
Oct 27, 2016
…shortens. ### What is this PR for? In document page(http://zeppelin.apache.org/docs/0.7.0-SNAPSHOT/), the search button goes to next line when display's width shortens. ### What type of PR is it? [Improvement] ### What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-1552 ### Screenshots (if appropriate) <img width="927" alt="2016-10-15 2 04 00" src="https://cloud.githubusercontent.com/assets/6567102/19398321/0d76a1c4-9287-11e6-86e0-9f120c00b143.png"> when (768px ≤ width < 992px) ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No Author: hyonzin <hyeonjin507@gmail.com> Author: AhyoungRyu <ahyoungryu@apache.org> Author: 정현진 <hyeonjin507@gmail.com> Closesapache#1525 from hyonzin/ZEPPELIN-1552 and squashes the following commits: f1d97ef [AhyoungRyu] Fix search icon's placement in small browser 244992d [정현진] Straighten wrong term 97d1bdf [hyonzin] Fix search link button to not goes next line when display's width shortens
pedrozatta pushed a commit
to pedrozatta/zeppelin
that referenced
this pull request
Oct 27, 2016
…shortens. ### What is this PR for? In document page(http://zeppelin.apache.org/docs/0.7.0-SNAPSHOT/), the search button goes to next line when display's width shortens. ### What type of PR is it? [Improvement] ### What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-1552 ### Screenshots (if appropriate) <img width="927" alt="2016-10-15 2 04 00" src="https://cloud.githubusercontent.com/assets/6567102/19398321/0d76a1c4-9287-11e6-86e0-9f120c00b143.png"> when (768px ≤ width < 992px) ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No Author: hyonzin <hyeonjin507@gmail.com> Author: AhyoungRyu <ahyoungryu@apache.org> Author: 정현진 <hyeonjin507@gmail.com> Closesapache#1525 from hyonzin/ZEPPELIN-1552 and squashes the following commits: f1d97ef [AhyoungRyu] Fix search icon's placement in small browser 244992d [정현진] Straighten wrong term 97d1bdf [hyonzin] Fix search link button to not goes next line when display's width shortens
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR for?
In document page(http://zeppelin.apache.org/docs/0.7.0-SNAPSHOT/), the search button goes to next line when display's width shortens.
What type of PR is it?
[Improvement]
What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-1552
Screenshots (if appropriate)
when (768px ≤ width < 992px) ### Questions: - Does the licenses files need update? No - Is there breaking changes for older versions? No - Does this needs documentation? No