Skip to content

[DOCS] Separate "interpreter exec hooks (experimental)" from interpreter overview page - #1768

Closed
AhyoungRyu wants to merge 1 commit into
apache:masterfrom
AhyoungRyu:separate-eventhook-section
Closed

[DOCS] Separate "interpreter exec hooks (experimental)" from interpreter overview page#1768
AhyoungRyu wants to merge 1 commit into
apache:masterfrom
AhyoungRyu:separate-eventhook-section

Conversation

@AhyoungRyu

@AhyoungRyuAhyoungRyu commented Dec 15, 2016

Copy link
Copy Markdown
Contributor

What is this PR for?

After #1470 merged, "(Experimental) Interpreter Execution Hooks" is added under https://zeppelin.apache.org/docs/0.7.0-SNAPSHOT/manual/interpreters.html page. But i think we need to keep this page as simple as possible since it's explaining the basic concept of Zeppelin interpreters. So I separated "(Experimental) Interpreter Execution Hooks" section from interpreters.md and created new page interpreterexechooks.md.
And also fixed some markdown rendering issues.

What type of PR is it?

Documentation

What is the Jira issue?

N/A

How should this be tested?

Please see below screenshots :)

Screenshots (if appropriate)

screen shot 2016-12-15 at 5 05 49 pm]

  • After

dropdown

screen shot 2016-12-15 at 5 05 58 pm

Questions:

  • Does the licenses files need update? no
  • Is there breaking changes for older versions? no
  • Does this needs documentation? no

@AhyoungRyu

Copy link
Copy Markdown
ContributorAuthor

@agoodm Since you added this section, it'll be appreciated if you can review this one :)

@agoodm

Copy link
Copy Markdown
Member

Thanks for the update! I probably should have done this when I made the original PR.

Anyways, LGTM.

@AhyoungRyu

Copy link
Copy Markdown
ContributorAuthor

@agoodm No worries. Thanks!

@soralee

soralee commented Dec 15, 2016

Copy link
Copy Markdown
Contributor

Tested and LGTM!

@AhyoungRyu

Copy link
Copy Markdown
ContributorAuthor

@agoodm@soralee Thanks for your review!

CI failed only in Selenium test like below and it's not related with this docs change.

Results :
Tests in error: ZeppelinIT.testAngularDisplay:157->AbstractZeppelinIT.waitForText:84 » StaleElementReference
Tests run: 18, Failures: 0, Errors: 1, Skipped: 0

Merge into master if there are no further discussions :)

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@AhyoungRyu@agoodm@soralee