Uh oh!
There was an error while loading. Please reload this page.
[BugFix] Tutorial note json format. - #1780
Conversation
AhyoungRyu
commented
Dec 17, 2016
astroshim
commented
Dec 17, 2016
@AhyoungRyu Thank you for review and let me check that problem. |
astroshim
commented
Dec 17, 2016
In my case, It's normal output of results. @AhyoungRyu Did you build this PR? |
AhyoungRyu
commented
Dec 17, 2016
@astroshim I checked again and it's working well. Sorry for any confusions, it was my bad. |
Looks great to me. CI fails here though. I know it's annoying and there were no code changes, so it's definitely not immediately related to this PR but @astroshim, as PR author, could you please post build failure logs reason here, so we can see if it is something that already have a JIRA issue, or a new one should be created? Again, sorry for bothering, but this helps improving CI stability a lot and sets a good example of NOT ignoring the CI failures for other contributors. Thanks in advance! |
astroshim
commented
Dec 21, 2016
@bzz I agree with you and I will follow your word! |
astroshim
commented
Dec 21, 2016
CI has passed after rebase. |
AhyoungRyu
commented
Dec 21, 2016
Nice! Then will merge into master if there are no more comments :) |
astroshim
commented
Dec 21, 2016
@AhyoungRyu Thanks. |


What is this PR for?
Since #1658, the output format had changed but note.json of Tutorials didn't changed.
What type of PR is it?
Bug Fix
How should this be tested?
Please make sure there is no
resultfield in note.json file.Questions: