Uh oh!
There was an error while loading. Please reload this page.
[MINOR] Refactoring Job and Paragraph - #1793
Closed
jongyoul wants to merge 5 commits into
Closed
Conversation
MemberAuthor
This test passed in my local and all others passed. |
jongyoulforce-pushed
the
minor/refactoring-job-paragraph
branch
from
December 24, 2016 17:36
4eff6a6 to
8de238bComparejongyoul
commented
Dec 24, 2016
MemberAuthor
I've rebased after merging #1753 |
jongyoul
commented
Dec 24, 2016
MemberAuthor
Will merge it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR for?
Job class has only two sub classes. I don't think we need Job abstraction class anymore, then I'll move all function of Job into Paragraph and InterpretJob. Paragraph is used into zeppelin-server and InterpretJob is done by remoteInterpreterServer. I think what we disconnect those two different classes is better to maintain each side of codes. This PR moves two variable - result and results - from Job to Paragraph in order to remove Job class. It also based on ZEPPELIN-1594(#1753), thus all reviewers click the last commit and review it.
What type of PR is it?
[Refactoring]
Todos
What is the Jira issue?
N/A
How should this be tested?
All things are same as before
Screenshots (if appropriate)
N/A
Questions: