Skip to content

[MINOR] Fix paragraph id misalignment in dropdown menu - #1811

Closed
cuspymd wants to merge 1 commit into
apache:masterfrom
cuspymd:fix-dropdown-menu
Closed

[MINOR] Fix paragraph id misalignment in dropdown menu#1811
cuspymd wants to merge 1 commit into
apache:masterfrom
cuspymd:fix-dropdown-menu

Conversation

@cuspymd

@cuspymdcuspymd commented Dec 28, 2016

Copy link
Copy Markdown
Contributor

What is this PR for?

Fix paragraph id misalignment in dropdown menu at Chrome/Firefox browser.

What type of PR is it?

[Bug Fix]

Todos

What is the Jira issue?

N/A

How should this be tested?

Open the dropdown menu of a paragraph at Chrome/Firefox browser.

Screenshots (if appropriate)

  • before
    before
  • after
    after

Questions:

  • Does the licenses files need update?
  • Is there breaking changes for older versions?
  • Does this needs documentation?

@AhyoungRyu

Copy link
Copy Markdown
Contributor

Thanks for your contribution. I added clipboard in #1750 but, can't reproduce the text overflow like you attached screenshot. I tested latest master in Chrome / Firefox / Safari.

  • Chrome

screen shot 2016-12-29 at 4 09 51 pm

  • Firefox

screen shot 2016-12-29 at 4 12 13 pm

  • Safari

screen shot 2016-12-29 at 4 12 38 pm

@cuspymd

Copy link
Copy Markdown
ContributorAuthor

Let's try to change the width of browser.
It is reprouced when the width of browser is narrow.

@AhyoungRyu

Copy link
Copy Markdown
Contributor

@cuspymd Thanks. Let me try :)

@AhyoungRyu

Copy link
Copy Markdown
Contributor

@cuspymd I tried to make the browser width narrower and tried to change the paragraph width itself , but still couldn't reproduce.
changeparagraphwidth

Am I missing something?

@soralee

Copy link
Copy Markdown
Contributor

@cuspymd Could you resolve conflict and test again?
I think this problem is gone because this feature is changed.

@cuspymd

Copy link
Copy Markdown
ContributorAuthor

I've checked it is resolved at latest commit.
Thanks for your check.

@cuspymdcuspymd closed this Jan 3, 2017
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@cuspymd@AhyoungRyu@soralee