Skip to content

[DOCS][ZEPPELIN-1586] Add 'Security' section under notebook restapi docs - #1825

Closed
AhyoungRyu wants to merge 2 commits into
apache:masterfrom
AhyoungRyu:ZEPPELIN-1586/docs
Closed

[DOCS][ZEPPELIN-1586] Add 'Security' section under notebook restapi docs#1825
AhyoungRyu wants to merge 2 commits into
apache:masterfrom
AhyoungRyu:ZEPPELIN-1586/docs

Conversation

@AhyoungRyu

@AhyoungRyuAhyoungRyu commented Dec 30, 2016

Copy link
Copy Markdown
Contributor

What is this PR for?

After #1567 merged we can get/set note permission info for a certain note. But this info is not described in anywhere for now. So I added "Security" section under docs/rest-api/rest-notebook.md.

And currently so many operations are placed under one section like below.

So I split them under each Note opersions, Paragraph operations, Cron jobs, and Permission section.

What type of PR is it?

Documentation

What is the Jira issue?

ZEPPELIN-1877

How should this be tested?

Please see the below screenshots :)

Screenshots (if appropriate)

screen shot 2017-01-10 at 5 41 51 pm
screen shot 2017-01-10 at 5 41 59 pm

Questions:

  • Does the licenses files need update? no
  • Is there breaking changes for older versions? no
  • Does this needs documentation? no

@AhyoungRyu

Copy link
Copy Markdown
ContributorAuthor

@anthonycorbacho As a creator of this operations, could you please help review this PR? :D

@AhyoungRyu

Copy link
Copy Markdown
ContributorAuthor

I updated this docs page again since REST API operations need to be listed as CRUD order. And removed unimplemented response code info as well. Please see the updated screenshot images :)

@minahlee

Copy link
Copy Markdown
Member

Nice improvement, LGTM

@AhyoungRyu

Copy link
Copy Markdown
ContributorAuthor

Thanks @minahlee!
Will merge if there are no more comments on this.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@AhyoungRyu@minahlee