Uh oh!
There was an error while loading. Please reload this page.
[DOCS] Remove outdated 'Security Setup' section in SECURITY-README - #1829
[DOCS] Remove outdated 'Security Setup' section in SECURITY-README#1829AhyoungRyu wants to merge 4 commits into
Conversation
Leemoonsoo
commented
Jan 3, 2017
LGTM! |
| 3. Start Zeppelin : bin/zeppelin.sh | ||
| 4. point your browser to http://localhost:8080 | ||
| 5. Login using one of the user/password combinations defined in the conf/shiro.ini file. | ||
| Please check [Shiro authentication in Apache Zeppelin](https://zeppelin.apache.org/docs/snapshot/security/shiroauthentication.html) in our official website for more detailed information(e.g. How to setup the security, How to configure user groups and permissions, and etc). |
There was a problem hiding this comment.
instead of https://zeppelin.apache.org/docs/snapshot
point to https://zeppelin.apache.org/docs/latest
?
There was a problem hiding this comment.
@felixcheung Not sure but, I thought that the readers who will refer this SECURITY-README.md are commonly visiting Zeppelin github repo(it's snapshot version) not Zeppelin itself. So like Zeppelin README.md(you can see "install" and "Build from source" are linked \w snapshot) does, I put snapshot link in here. What do you think? :)
felixcheung
commented
Jan 3, 2017
via email
Hmm, true, it's possible that way.
I just thought its better to point to the latest release, but I can see your point here.
I don't feel strongly either case, so LGTM. |
@felixcheung Yeah I know what you mean. Thanks for your suggestion and review anyway! (CI failure is not relevant with this issue. Docs doesn't have any tests.) |
What is this PR for?
SECURITY-README.md was added by #53 when Shiro auth was implemented for the first time. But I think we need to keep "Security Setup" information in one source; Official docs website and guide ppl to see this official docs page so that
SECURITY-README.mdcan only contain dev related contents (not step by step setup guide).What type of PR is it?
Documentation
What is the Jira issue?
N/A
How should this be tested?
Just clicking "View" would be enough I guess :)
Questions: