Uh oh!
There was an error while loading. Please reload this page.
[ZEPPELIN-17] PySpark Interpreter should allow starting with a specific version of Python - #19
Closed
felixcheung wants to merge 3 commits into
Closed
[ZEPPELIN-17] PySpark Interpreter should allow starting with a specific version of Python#19felixcheung wants to merge 3 commits into
felixcheung wants to merge 3 commits into
Conversation
jongyoul
commented
Apr 1, 2015
Member
LGTM |
1 similar comment
Leemoonsoo
commented
Apr 1, 2015
Member
LGTM |
swkimme
commented
Apr 1, 2015
Contributor
LGTM! |
prabhjyotsingh pushed a commit
to prabhjyotsingh/zeppelin
that referenced
this pull request
Mar 2, 2026
…erxml.jackson.core to 2.16.1 (apache#19) * OSV-3517|PRISMA-2023-0067|CVE-2019-10202 | CVE-2019-10172- org.codehaus.jackson_jackson-core to 2.16.1 * OSV-3517|PRISMA-2023-0067|CVE-2019-10202 | CVE-2019-10172- bumping maven-shade-plugin version to 3.6.0
voidmatcha added a commit
to voidmatcha/zeppelin
that referenced
this pull request
Jun 1, 2026
Three independent race conditions caused intermittent failures in CI
under parallel workers; each is addressed at the source.
1. Per-test login race
Each spec ran a login flow in its own `beforeEach`, so N workers
submitted the form against the same session-cookie endpoint
simultaneously. The shared cookie was overwritten before the
`/api/security/ticket` response settled, leaving roughly one in
four tests authenticated against a stale session.
Fix: dedicated Playwright `setup` project (`e2e/global.setup.ts`)
logs in once, writes `playwright/.auth/user.json`, and every
browser project consumes it via `storageState`. The 29
`performLoginIfRequired(page)` call sites are removed.
2. Angular ngModel race on modal inputs
Ant Design modals autofocus their first input the same tick the
modal opens, while the Angular form is still initializing its
`FormControl`. A plain `locator.fill(value)` set the DOM value
before ngModel was bound, so the form state stayed empty and the
confirm button never enabled. Playwright's prescribed
`pressSequentially` had the same race (verified on a 50-run
matrix).
Fix: `BasePage.fillAndVerifyInput()` retries `click → fill →
dispatchEvent(input, change) → inputValue() === value` via
`expect.toPass({ timeout: 15s, intervals: [200, 500, 1000,
2000] })` until the form actually sees the value.
3. UI state-stability gaps
Modal-dismiss, dropdown-close, theme-switch, and logout-spinner
transitions had no explicit wait; the next action sometimes fired
into a half-rendered DOM.
Fix: targeted waits added at each transition boundary — modal
`state: 'detached'`, dropdown `not.toBeVisible`, theme attribute
poll, logout spinner `not.toBeVisible`.
Other changes are derivatives of #1–apache#3 (factored helpers, JUSTIFIED
comments documenting CSS-:hover and Ant-modal autofocus exceptions,
single-place `workers: 5` in the config). Out-of-scope refactors
proposed during review (REST-based notebook creation in
paragraph-functionality.spec.ts) were deliberately not bundled.
Verified: Playwright `run-playwright-e2e-tests (auth, 3.9)` and
`(anonymous, 3.9)` green across the six most recent fork CI runs;
v1.3.4 e2e-reviewer scanner reports zero apache#19 hits (the previous
`let testNotebookNameSequence = 0;` collision under parallel
workers was eliminated).voidmatcha added a commit
to voidmatcha/zeppelin
that referenced
this pull request
Jun 2, 2026
Three independent race conditions caused intermittent failures in CI
under parallel workers; each is addressed at the source.
1. Per-test login race
Each spec ran a login flow in its own `beforeEach`, so N workers
submitted the form against the same session-cookie endpoint
simultaneously. The shared cookie was overwritten before the
`/api/security/ticket` response settled, leaving roughly one in
four tests authenticated against a stale session.
Fix: dedicated Playwright `setup` project (`e2e/global.setup.ts`)
logs in once, writes `playwright/.auth/user.json`, and every
browser project consumes it via `storageState`. The 29
`performLoginIfRequired(page)` call sites are removed.
2. Angular ngModel race on modal inputs
Ant Design modals autofocus their first input the same tick the
modal opens, while the Angular form is still initializing its
`FormControl`. A plain `locator.fill(value)` set the DOM value
before ngModel was bound, so the form state stayed empty and the
confirm button never enabled. Playwright's prescribed
`pressSequentially` had the same race (verified on a 50-run
matrix).
Fix: `BasePage.fillAndVerifyInput()` retries `click → fill →
dispatchEvent(input, change) → inputValue() === value` via
`expect.toPass({ timeout: 15s, intervals: [200, 500, 1000,
2000] })` until the form actually sees the value.
3. UI state-stability gaps
Modal-dismiss, dropdown-close, theme-switch, and logout-spinner
transitions had no explicit wait; the next action sometimes fired
into a half-rendered DOM.
Fix: targeted waits added at each transition boundary — modal
`state: 'detached'`, dropdown `not.toBeVisible`, theme attribute
poll, logout spinner `not.toBeVisible`.
Other changes are derivatives of #1–apache#3 (factored helpers, JUSTIFIED
comments documenting CSS-:hover and Ant-modal autofocus exceptions,
single-place `workers: 5` in the config). Out-of-scope refactors
proposed during review (REST-based notebook creation in
paragraph-functionality.spec.ts) were deliberately not bundled.
Verified: Playwright `run-playwright-e2e-tests (auth, 3.9)` and
`(anonymous, 3.9)` green across the six most recent fork CI runs;
v1.3.4 e2e-reviewer scanner reports zero apache#19 hits (the previous
`let testNotebookNameSequence = 0;` collision under parallel
workers was eliminated).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add PYSPARK_PYTHON.
We could also add PYSPARK_DRIVER_PYTHON (Zeppelin Interpreter is the driver) but it doesn't seem to be documented, and more importantly running different Python between driver and worker can cause errors.
http://spark.apache.org/docs/1.3.0/configuration.html
http://spark.apache.org/docs/1.3.0/configuration.html#environment-variables