Uh oh!
There was an error while loading. Please reload this page.
[ZEPPELIN-1991] Can't get the PARAGRAPH_APPEND_OUTPUT from the Interpreter. - #1922
Closed
astroshim wants to merge 2 commits into
Closed
[ZEPPELIN-1991] Can't get the PARAGRAPH_APPEND_OUTPUT from the Interpreter.#1922astroshim wants to merge 2 commits into
astroshim wants to merge 2 commits into
Conversation
AhyoungRyu
commented
Jan 21, 2017
Contributor
Thanks for the patch! Tested and works well as you described. |
AhyoungRyu
commented
Jan 21, 2017
Contributor
This patch fixes the issue that I reported in this comment in #1833 . Looks good. LGTM |
AhyoungRyu
commented
Jan 22, 2017
Contributor
Merging into master and branch-0.7 if there are no comments on this. |
asfgit pushed a commit
that referenced
this pull request
Jan 23, 2017
…reter. ### What is this PR for? This PR fixes the problem of streaming events(PARAGRAPH_APPEND_OUTPUT). It's because of the queue was not thread safe. ### What type of PR is it? Bug Fix ### What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-1991 ### How should this be tested? 1. make a spark paragraph 2. run following code on spark paragraph. ``` %spark (1 to 5).foreach{ i=> Thread.sleep(1000) println("Hello " + i) } ``` 3. make a python paragraph 4. run following code on python paragraph. ``` %python.python print("hi1") ``` 5. retry run step 2, and check if streaming working. ### Screenshots (if appropriate) - before  - after  ### Questions: * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? no Author: astroshim <hsshim@zepl.com> Closes#1922 from astroshim/ZEPPELIN-1991 and squashes the following commits: e993585 [astroshim] make scheduler not static 66d3d2f [astroshim] fix to thread safe (cherry picked from commit 4ef4e18) Signed-off-by: ahyoungryu <ahyoungryu@apache.org>
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR for?
This PR fixes the problem of streaming events(PARAGRAPH_APPEND_OUTPUT).
It's because of the queue was not thread safe.
What type of PR is it?
Bug Fix
What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-1991
How should this be tested?
make a spark paragraph
run following code on spark paragraph.
make a python paragraph
run following code on python paragraph.
Screenshots (if appropriate)
before
after
Questions: