Uh oh!
There was an error while loading. Please reload this page.
[ZEPPELIN-2072] Home Screen doesn't work on shiro. - #1990
Closed
soralee wants to merge 1 commit into
Closed
Conversation
Leemoonsoo
commented
Feb 10, 2017
Member
Thanks @soralee for the fix! Merge to master if no further discussions. |
ContributorAuthor
Thanks for taking look @Leemoonsoo 👍 |
asfgit pushed a commit
that referenced
this pull request
Feb 11, 2017
### What is this PR for? The home screen is a notebook for use as homepage. It is the zeppelin.notebook.homescreen variable in `conf/zeppelin-site.xml` or `conf/zeppelin-env.sh`. But currently zeppelin.notebook.homescreen variable doesn't work on shiro until refreshing window. ### What type of PR is it? [Bug Fix] ### What is the Jira issue? * [ZEPPELIN-2072](https://issues.apache.org/jira/browse/ZEPPELIN-2072) ### How should this be tested? 1. Set zeppelin.notebook.homescreen variable in `conf/zeppelin-site.xml` or `conf/zeppelin-env.sh`. 2. Turn on shiro. 3. Start zeppelin-daemon. 4. Login your account and make sure whether homepage is changed or not. ### Screenshots (if appropriate) [ Before ]  [ After ]  ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No Author: soralee <sora0728@zepl.com> Closes#1990 from soralee/ZEPPELIN-2072_homescreen_shiro and squashes the following commits: 35625c4 [soralee] fix homescreen on shiro (cherry picked from commit 896e19e) Signed-off-by: Lee moon soo <moon@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR for?
The home screen is a notebook for use as homepage.
It is the zeppelin.notebook.homescreen variable in
conf/zeppelin-site.xmlorconf/zeppelin-env.sh.But currently zeppelin.notebook.homescreen variable doesn't work on shiro until refreshing window.
What type of PR is it?
[Bug Fix]
What is the Jira issue?
How should this be tested?
conf/zeppelin-site.xmlorconf/zeppelin-env.sh.Screenshots (if appropriate)
[ Before ]
[ After ]
Questions: