Skip to content

[ZEPPELIN-2191] Helium package should be able to import css - #2077

Closed
1ambda wants to merge 1 commit into
apache:masterfrom
1ambda:ZEPPELIN-2191/import-css-in-helium-pkg
Closed

[ZEPPELIN-2191] Helium package should be able to import css#2077
1ambda wants to merge 1 commit into
apache:masterfrom
1ambda:ZEPPELIN-2191/import-css-in-helium-pkg

Conversation

@1ambda

@1ambda1ambda commented Feb 27, 2017

Copy link
Copy Markdown
Member

What is this PR for?

Helium package should be able to import css. For example,

import'jsoneditor/dist/jsoneditor.min.css'/** here */importJSONEditorfrom'jsoneditor/dist/jsoneditor.min.js'

This PR is written based on #2071, so the duplicated commit will be dropped. Please review the commit 505c7db only.

What type of PR is it?

[Improvement]

Todos

  • - denote required packages in package.json
  • - setup webpack.config.js

What is the Jira issue?

ZEPPELIN-2191

How should this be tested?

Should be able to bundle zeppelin-json-spell

Screenshots (if appropriate)

NONE

Questions:

  • Does the licenses files need update? - NO
  • Is there breaking changes for older versions? - NO
  • Does this needs documentation? - NO

@1ambda

Copy link
Copy Markdown
MemberAuthor

@AhyoungRyu

Copy link
Copy Markdown
Contributor

Tested 505c7db commit only with your package, and it works well as expected.
screen shot 2017-02-28 at 6 29 59 pm

(zeppelin-json-spell: super nice package!)

@1ambda

Copy link
Copy Markdown
MemberAuthor

@AhyoungRyu Thanks for cool review 😃

@AhyoungRyu

Copy link
Copy Markdown
Contributor

LGTM 👍

@1ambda
1ambdaforce-pushed the ZEPPELIN-2191/import-css-in-helium-pkg branch from 505c7db to 02ada2cCompareMarch 4, 2017 08:45
@AhyoungRyu

Copy link
Copy Markdown
Contributor

Merge into master if there are no more comments!

@1ambda
1ambdaforce-pushed the ZEPPELIN-2191/import-css-in-helium-pkg branch 2 times, most recently from e2592d3 to d7768eeCompareMarch 6, 2017 04:07
@1ambda

Copy link
Copy Markdown
MemberAuthor

Rebased to resolve conflict.

@1ambda1ambda closed this Mar 6, 2017
@1ambda1ambda reopened this Mar 6, 2017
@asfgitasfgit closed this in 6ef2a08Mar 6, 2017
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@1ambda@AhyoungRyu