Uh oh!
There was an error while loading. Please reload this page.
[MINOR][ZEPPELIN-2154] Enable work in the web dev mode if changing default server port - #2097
Closed
soralee wants to merge 4 commits into
Closed
[MINOR][ZEPPELIN-2154] Enable work in the web dev mode if changing default server port#2097soralee wants to merge 4 commits into
soralee wants to merge 4 commits into
Conversation
| } | ||
| } | ||
| //Exception for when running locally via grunt | ||
| if (port === 3333 || port === 9000) { |
ContributorAuthor
There was a problem hiding this comment.
Yes, as far as i know this port is old web development mode. Thus we don't need 3333 port :)
soraleeforce-pushed
the
ZEPPELIN-2154_port_webDevMode
branch
2 times, most recently
from
March 6, 2017 05:59
2effb98 to
62dde39CompareMember
Tested and works as described. |
soraleeforce-pushed
the
ZEPPELIN-2154_port_webDevMode
branch
from
March 7, 2017 05:13
62dde39 to
e6d1801Comparesoralee
commented
Mar 7, 2017
ContributorAuthor
Thanks for review @1ambda 👍 |
khalidhuseynov
commented
Mar 7, 2017
Member
LGTM |
AhyoungRyu
commented
Mar 7, 2017
Contributor
soralee
commented
Mar 8, 2017
ContributorAuthor
@khalidhuseynov@AhyoungRyu Thanks for review! |
AhyoungRyu
commented
Mar 9, 2017
Contributor
@soralee I just merged this into master but automatically couldn't into |
soralee
commented
Mar 9, 2017
ContributorAuthor
@AhyoungRyu Sure, Thanks! |
asfgit pushed a commit
that referenced
this pull request
Apr 8, 2017
### What is this PR for? If user change `zeppelin.server.port` variable in zeppelin-site.xml, zeppelin doesn't work in web development on `branch-0.7` #2097 PR which is same issue on master branch was already merged to master branch. ### What type of PR is it? [Bug Fix | Improvement | Documentation (README.md)] ### What is the Jira issue? * [ZEPPELIN-2154](https://issues.apache.org/jira/browse/ZEPPELIN-2154) ### How should this be tested? 1. Change `zeppelin.server.port` from 8080 to 8888 (or another port) in `zeppelin-site.xml` 2. Run zeppelin (`bin/zeppelin-daemon.sh start`) 3. Run web development mode under zeppelin-web folder such like `SERVER_PORT=8888 yarn run dev` 4. Connect localhost:9000 ### Screenshots (if appropriate) **[Before]**  **[After]**   ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does thi`sneeds documentation? Yes, `README.md` Author: soralee <sora0728@zepl.com> Closes#2124 from soralee/ZEPPELIN-2154_0.7_server_port and squashes the following commits: 8633842 [soralee] [ZEPPELIN-2154] Support zeppelin.server.port in dev mode (branch-0.7)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR for?
If user change
zeppelin.server.portvariable in zeppelin-site.xml, zeppelin doesn't work in web development.In order for user to run zeppelin correctly, so that user can add
SERVER_PORTas an environment variable when running web application development mode.What type of PR is it?
[Bug Fix | Improvement | Documentation]
What is the Jira issue?
How should this be tested?
zeppelin.server.portfrom 8080 to 8888 (or another port) inzeppelin-site.xmlbin/zeppelin-daemon.sh start)zeppelin-webfolder such likeSERVER_PORT=8888 yarn run devlocalhost:9000Screenshots (if appropriate)
[Before]
[After]
Questions: