Skip to content

[ZEPPELIN-2228] precode for SparkRInterpreter - #2112

Closed
tinkoff-dwh wants to merge 3 commits into
apache:masterfrom
tinkoff-dwh:ZEPPELIN-2228
Closed

[ZEPPELIN-2228] precode for SparkRInterpreter#2112
tinkoff-dwh wants to merge 3 commits into
apache:masterfrom
tinkoff-dwh:ZEPPELIN-2228

Conversation

@tinkoff-dwh

Copy link
Copy Markdown
Contributor

What is this PR for?

Added parameter zeppelin.pyspark.precode to SparkRInterpreter. This is snippet of code which executes when interpreter initialize.

What type of PR is it?

Feature

What is the Jira issue?

https://issues.apache.org/jira/browse/ZEPPELIN-2228

How should this be tested?

  1. Set parameter zeppelin.R.precode precodeVar=1+2
  2. Run
%r
print(precodeVar)

Questions:

  • Does the licenses files need update? no
  • Is there breaking changes for older versions? no
  • Does this needs documentation? no

@tinkoff-dwh

tinkoff-dwh commented Mar 8, 2017

Copy link
Copy Markdown
ContributorAuthor

@tinkoff-dwh

Copy link
Copy Markdown
ContributorAuthor

Ready to review

@dgskv

Copy link
Copy Markdown

LGTM

@echarles

Copy link
Copy Markdown
Member

Would be good to generalize this precode execution to all interprerters, having methods like prerun, postrun... at Interpeter interface level.

@tinkoff-dwh

Copy link
Copy Markdown
ContributorAuthor

@tinkoff-dwh

tinkoff-dwh commented Mar 17, 2017

Copy link
Copy Markdown
ContributorAuthor

CI green, https://travis-ci.org/tinkoff-dwh/zeppelin/builds/208970773 , commit is correct 8323392,
but status failed (tried reopen).

@tinkoff-dwh

Copy link
Copy Markdown
ContributorAuthor

#2221 general solution

@tinkoff-dwh
tinkoff-dwh deleted the ZEPPELIN-2228 branch May 1, 2017 14:05
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@tinkoff-dwh@dgskv@echarles