Uh oh!
There was an error while loading. Please reload this page.
[ZEPPELIN-2179] "clear output" paragraph doesn't work in personalized mode (branch-0.7) - #2116
Closed
1ambda wants to merge 3 commits into
Closed
Conversation
1ambda
commented
Mar 10, 2017
MemberAuthor
@jongyoul Can you help review this? |
| public void broadcastParagraphs(Map<String, Paragraph> userParagraphMap, | ||
| Paragraph defaultParagraph) { | ||
| Paragraph defaultParagraph) { |
Member
There was a problem hiding this comment.
@1ambda Please turn off this setting of vertical alignment.
MemberAuthor
1ambda
commented
Mar 11, 2017
MemberAuthor
@jongyoul If implementation is ok, I will create a PR for the master branch as well. |
Leemoonsoo
commented
Mar 15, 2017
Member
CI failure on |
1ambdaforce-pushed
the
ZEPPELIN-2179/clear-output-doesnt-work-in-person-mode
branch
from
March 15, 2017 20:02
b1e782e to
65d1147CompareMemberAuthor
I'v just rebased, let me comment after fixing CI. |
1ambda
commented
Mar 16, 2017
MemberAuthor
CI passed. @Leemoonsoo |
1ambda
commented
Mar 16, 2017
MemberAuthor
Regarding to the same fix for master branch, I will open another PR. |
jongyoul
approved these changes
Mar 16, 2017
asfgit pushed a commit
that referenced
this pull request
Mar 16, 2017
… mode (branch-0.7) ### What is this PR for? `clear output` (`cmd` + `opt` + `L`) doesn't work in the personalized mode. - CI failure might be related with #2103 ### What type of PR is it? [Bug Fix] ### Todos NONE ### What is the Jira issue? [ZEPPELIN-2179](https://issues.apache.org/jira/browse/ZEPPELIN-2179) ### How should this be tested? 1. Execute a paragraph 2. Click `clear output` button (`CMD` + `OPT` + `L) ### Screenshots (if appropriate) NONE ### Questions: * Does the licenses files need update? - NO * Is there breaking changes for older versions? - NO * Does this needs documentation? - NO Author: 1ambda <1amb4a@gmail.com> Closes#2116 from 1ambda/ZEPPELIN-2179/clear-output-doesnt-work-in-person-mode and squashes the following commits: e2593f6 [1ambda] fix Remove unused param 65d1147 [1ambda] fix: Remove unused parameter 0386c5c [1ambda] fix: Clear personalized paragraph output
jongyoul
commented
Mar 16, 2017
Member
@1ambda I merged this PR into branch-0.7. Please close this PR and make a new PR for master. I've tried to merge it into master but ,as you mentioned, it wouldn't be merged because of conflict. |
1ambda
commented
Mar 16, 2017
MemberAuthor
Thanks @jongyoul! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR for?
clear output(cmd+opt+L) doesn't work in the personalized mode.What type of PR is it?
[Bug Fix]
Todos
NONE
What is the Jira issue?
ZEPPELIN-2179
How should this be tested?
clear outputbutton (CMD+OPT+ `L)Screenshots (if appropriate)
NONE
Questions: