Skip to content

feat: use ZEPPELIN_HOSTNAME to specify hostname - #221

Closed
jonbuffington wants to merge 1 commit into
apache:masterfrom
fuseelements:WIP-hostname-env
Closed

feat: use ZEPPELIN_HOSTNAME to specify hostname#221
jonbuffington wants to merge 1 commit into
apache:masterfrom
fuseelements:WIP-hostname-env

Conversation

@jonbuffington

Copy link
Copy Markdown
Contributor

ZEPPELIN_HOSTNAME supports running Zeppelin in environments where the
hostname of the server does not match the hostname delivered to the
browser. If ZEPPELIN_HOSTNAME is not set, java.net.InetAddress.
getLocalHost().getHostName() is still used to lookup the server's
current hostname.

NotebookServerTests was renamed to NotebookServerTest to permit the
test cases to run using Maven's test goal.

Fixes https://issues.apache.org/jira/browse/ZEPPELIN-231

ZEPPELIN_HOSTNAME supports running Zeppelin in environments where the
hostname of the server does not match the hostname delivered to the
browser. If ZEPPELIN_HOSTNAME is not set, java.net.InetAddress.
getLocalHost().getHostName() is still used to lookup the server's
current hostname.
NotebookServerTests was renamed to NotebookServerTest to permit the
test cases to run using Maven's test goal.
@djoelz

Copy link
Copy Markdown

Thanks for fixing my bug :)
I would prefer this setting live in the ZeppelinConfiguration class and not in an environment variable. This way it is discoverable by anyone.

@jonbuffington

Copy link
Copy Markdown
ContributorAuthor

Appreciate the feedback. Do you have any guidance on using ZeppelinConfiguration instead of an environment variable? I implemented ZEPPELIN_HOSTNAME as an environment variable to ease packaging in a docker image.

@Leemoonsoo

Copy link
Copy Markdown
Member

@djoelz

Copy link
Copy Markdown

@jonbuffington what @Leemoonsoo said. Let me know if you need any help with this as I am responsable for the issue :D

@jonbuffington

Copy link
Copy Markdown
ContributorAuthor

@djoelz Unfortunately, I am booked till this weekend. If you would like to make the changes, it would be appreciated.

@jonbuffington

Copy link
Copy Markdown
ContributorAuthor

@Leemoonsoo Thanks for the pointers!

@djoelz

Copy link
Copy Markdown

@jonbuffington@Leemoonsoo don't worry guys I will make the fix. Will create a separate PR.
Thanks!

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check for host.length > 1?

@Leemoonsoo

Copy link
Copy Markdown
Member

The same issue is also being taken care of, by #235.

@jonbuffington

Copy link
Copy Markdown
ContributorAuthor

I am closing this in favor of #235.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@jonbuffington@djoelz@Leemoonsoo@felixcheung