Uh oh!
There was an error while loading. Please reload this page.
[ZEPPELIN-2479] Fix incorrect tooltip view inside of version control menu - #2306
Closed
khalidhuseynov wants to merge 1 commit into
Closed
[ZEPPELIN-2479] Fix incorrect tooltip view inside of version control menu#2306khalidhuseynov wants to merge 1 commit into
khalidhuseynov wants to merge 1 commit into
Conversation
1ambda
commented
May 2, 2017
Member
Good! It would be nice to use |
khalidhuseynovforce-pushed
the
fix/ZEPPELIN-2479
branch
2 times, most recently
from
May 2, 2017 10:05
a454d54 to
ac4e651Comparekhalidhuseynov
commented
May 2, 2017
MemberAuthor
@1ambda yeah that's better idea, I just pushed the changes and updated image |
1ambda
commented
May 4, 2017
Member
@khalidhuseynov Could you restart the failed travis JOB? |
1ambda
commented
May 4, 2017
Member
CI is green. https://travis-ci.org/khalidhuseynov/zeppelin/builds/227894706 LGTM. |
Leemoonsoo
commented
May 4, 2017
Member
Merge to master and branch-0.7 if no further discussions. |
asfgit pushed a commit
that referenced
this pull request
May 5, 2017
…menu This is to fix incorrect appearance of tooltip inside version control menu Improvement * [x] - fix/remove tooltip [ZEPPELIN-2479](https://issues.apache.org/jira/browse/ZEPPELIN-2479) go to `version control` menu in notebook action bar of note before: <img width="689" alt="screen shot 2017-05-02 at 3 32 23 pm" src="https://cloud.githubusercontent.com/assets/1642088/25606467/62f0901c-2f4c-11e7-95ef-c22f1df410be.png"> after:  * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? no Author: Khalid Huseynov <khalidhnv@gmail.com> Closes#2306 from khalidhuseynov/fix/ZEPPELIN-2479 and squashes the following commits: ac4e651 [Khalid Huseynov] add css class (cherry picked from commit 8e96d8b) Signed-off-by: Lee moon soo <moon@apache.org>
michelemilesi pushed a commit
to icteam-spa/zeppelin
that referenced
this pull request
May 11, 2017
…menu ### What is this PR for? This is to fix incorrect appearance of tooltip inside version control menu ### What type of PR is it? Improvement ### Todos * [x] - fix/remove tooltip ### What is the Jira issue? [ZEPPELIN-2479](https://issues.apache.org/jira/browse/ZEPPELIN-2479) ### How should this be tested? go to `version control` menu in notebook action bar of note ### Screenshots (if appropriate) before: <img width="689" alt="screen shot 2017-05-02 at 3 32 23 pm" src="https://cloud.githubusercontent.com/assets/1642088/25606467/62f0901c-2f4c-11e7-95ef-c22f1df410be.png"> after:  ### Questions: * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? no Author: Khalid Huseynov <khalidhnv@gmail.com> Closesapache#2306 from khalidhuseynov/fix/ZEPPELIN-2479 and squashes the following commits: ac4e651 [Khalid Huseynov] add css class
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR for?
This is to fix incorrect appearance of tooltip inside version control menu
What type of PR is it?
Improvement
Todos
What is the Jira issue?
ZEPPELIN-2479
How should this be tested?
go to
version controlmenu in notebook action bar of noteScreenshots (if appropriate)
before:
after:
Questions: