Uh oh!
There was an error while loading. Please reload this page.
[ZEPPELIN-2516] Set offset, tolerance for navbar, actionbar hiding - #2325
Closed
1ambda wants to merge 1 commit into
Closed
[ZEPPELIN-2516] Set offset, tolerance for navbar, actionbar hiding#23251ambda wants to merge 1 commit into
1ambda wants to merge 1 commit into
Conversation
1ambda
commented
May 10, 2017
MemberAuthor
CI failed but irrelevant. Found the same errors in 4 different PRs
might be related with #2300 |
1ambda
commented
May 13, 2017
MemberAuthor
@soralee please help review this. |
1ambdaforce-pushed
the
ZEPPELIN-2516/set-offset-tolerance
branch
from
May 13, 2017 12:06
6316a51 to
5d9317cCompareLeemoonsoo
commented
May 14, 2017
Member
LGTM and merge to master if no further comment |
soralee
commented
May 14, 2017
Contributor
@1ambda Sorry for my late test! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR for?
Set offset, tolerance for navbar, actionbar hiding. See the attached screenshots.
What type of PR is it?
[Bug Fix]
Todos
NONE
What is the Jira issue?
ZEPPELIN-2516
How should this be tested?
Refer the screenshots.
Screenshots (if appropriate)
Before
After
Questions: