Skip to content

[ZEPPELIN-2545] [ZEPPELIN-2546] SecurityRestApiTest, NotebookSecurityRestApiTest fails on travis - #2344

Closed
Leemoonsoo wants to merge 2 commits into
apache:masterfrom
Leemoonsoo:ZEPPELIN-2545
Closed

[ZEPPELIN-2545] [ZEPPELIN-2546] SecurityRestApiTest, NotebookSecurityRestApiTest fails on travis#2344
Leemoonsoo wants to merge 2 commits into
apache:masterfrom
Leemoonsoo:ZEPPELIN-2545

Conversation

@Leemoonsoo

@LeemoonsooLeemoonsoo commented May 15, 2017

Copy link
Copy Markdown
Member

What is this PR for?

shiro returns multiple JSESSIONID on login request in integration test.

moon$ curl -v -XPOST -H "Origin: http://localhost:8080/api" -H "Host: localhost:8080" --data "userName=admin&password=password1"'http://localhost:8080/api/login'* Trying ::1...
* Connected to localhost (::1) port 8080 (#0)> POST /api/login HTTP/1.1
> Host: localhost:8080
> User-Agent: curl/7.43.0
> Accept: */*> Origin: http://localhost:8080/api
> Content-Length: 33
> Content-Type: application/x-www-form-urlencoded
>* upload completely sent off: 33 out of 33 bytes
< HTTP/1.1 200 OK
< Date: Mon, 15 May 2017 14:24:10 GMT
< Access-Control-Allow-Origin: http://localhost:8080/api
< Access-Control-Allow-Credentials: true< Access-Control-Allow-Headers: authorization,Content-Type
< Access-Control-Allow-Methods: POST, GET, OPTIONS, PUT, HEAD, DELETE
< Date: Monday, May 15, 2017 7:24:10 AM PDT
< Set-Cookie: rememberMe=deleteMe; Path=/; Max-Age=0; Expires=Sun, 14-May-2017 14:24:10 GMT
< Set-Cookie: JSESSIONID=2c0062db-99f0-438c-a5f6-6fdffa4eb7ae; Path=/; HttpOnly
< Set-Cookie: JSESSIONID=deleteMe; Path=/; Max-Age=0; Expires=Sun, 14-May-2017 14:24:10 GMT
< Set-Cookie: JSESSIONID=6bb25285-6cb0-47ea-8bb6-e268110a6034; Path=/; HttpOnly
< Set-Cookie: rememberMe=deleteMe; Path=/; Max-Age=0; Expires=Sun, 14-May-2017 14:24:10 GMT
< Content-Type: application/json
< Date: Mon, 15 May 2017 14:24:10 GMT
< Content-Length: 123
< Server: Jetty(9.2.15.v20160210)
<* Connection #0 to host localhost left intact

Later one is valid JSESSIONID. This PR changes test code to use last JSESSIONID.

What type of PR is it?

Bug Fix

What is the Jira issue?

https://issues.apache.org/jira/browse/ZEPPELIN-2545
https://issues.apache.org/jira/browse/ZEPPELIN-2546

How should this be tested?

After #2342 is merged, this PR will be rebased. Then CI should be green.

Questions:

  • Does the licenses files need update? no
  • Is there breaking changes for older versions? no
  • Does this needs documentation? no

@LeemoonsooLeemoonsoo changed the title [ZEPPELIN-2545] SecurityRestApiTest test fails on travis[ZEPPELIN-2545] SecurityRestApiTest, NotebookSecurityRestApiTest fails on travisMay 15, 2017
@LeemoonsooLeemoonsoo changed the title [ZEPPELIN-2545] SecurityRestApiTest, NotebookSecurityRestApiTest fails on travis[ZEPPELIN-2545] [ZEPPELIN-2546] SecurityRestApiTest, NotebookSecurityRestApiTest fails on travisMay 15, 2017
@1ambda

Copy link
Copy Markdown
Member

LGTM.

@Leemoonsoo

Copy link
Copy Markdown
MemberAuthor

Merge to master if no further comment

@soralee

Copy link
Copy Markdown
Contributor

LGTM!

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@Leemoonsoo@1ambda@soralee