Uh oh!
There was an error while loading. Please reload this page.
ZEPPELIN-1897 REST API - Update paragraph text/title via API - #2604
ZEPPELIN-1897 REST API - Update paragraph text/title via API#2604chilang wants to merge 1 commit into
Conversation
felixcheung
left a comment
There was a problem hiding this comment.
could you update the PR title to say "update paragraph title"
| "status": "OK", | ||
| "message": "", | ||
| "body": { | ||
| "title": "Hellow world", |
There was a problem hiding this comment.
this is the text of the paragraph? do we need to return it?
There was a problem hiding this comment.
@felixcheung Good point. Don't see the need at this point so I've removed the response's body. Docs updated.
chilang
commented
Oct 1, 2017
@felixcheung I've updated the the PR title to be more clear |
felixcheung
left a comment
There was a problem hiding this comment.
this LGTM. since this is updating an existing paragraph there might be other implications that I'm not aware of, I'd like others to review as well
| post.releaseConnection(); | ||
felixcheung
commented
Oct 1, 2017
also, there are some test failures, could you take a look? |
@felixcheung The build seems to be very flaky. |
felixcheung
commented
Oct 3, 2017
ok, agreed that seems unrelated. btw, it would be easier for reviewer to track changes if you do not force push any comment on this PR? I'd wait for a couple of days. |
What is this PR for?
Support updating paragraph text/title via REST API
https://issues.apache.org/jira/browse/ZEPPELIN-1897
What type of PR is it?
Improvement
Todos
What is the Jira issue?
[ZEPPELIN-1897]
How should this be tested?
curl -X PUT http://localhost:8080/api/notebook/NOTE_ID/paragraph/PARAGRAPH_ID -d '{"text": "some updated text"}'Screenshots (if appropriate)
Questions: