Uh oh!
There was an error while loading. Please reload this page.
ZEPPELIN-3106. User impersonation in SPARK is not working - #2705
Conversation
zjffdu
commented
Dec 18, 2017
@prabhjyotsingh Could you help review it ? Thanks |
prabhjyotsingh
commented
Dec 19, 2017
Will try this for both spark and shell interpreter, and post my finding later today. |
| fi | ||
| if [[ -n "${SPARK_SUBMIT}" ]]; then | ||
| if [[ -n "$ZEPPELIN_IMPERSONATE_USER" ]] && [[ "$ZEPPELIN_IMPERSONATE_SPARK_PROXY_USER" != "false" ]]; then |
There was a problem hiding this comment.
By removing this ZEPPELIN_IMPERSONATE_SPARK_PROXY_USER you disable the feature that was introduced with #1840 (# export ZEPPELIN_IMPERSONATE_SPARK_PROXY_USER #Optional, by default is true; can be set to false if you don't want to use --proxy-user option with Spark interpreter when impersonation enabled), is that intended? If so, we will need to update the doc.
| @@ -196,10 +199,10 @@ private boolean isYarnMode() { | |||
| private String toShellFormat(String value) { | |||
| if (value.contains("\'") && value.contains("\"")) { | |||
| if [[ -n "${SPARK_SUBMIT}" ]]; then | ||
| if [[ -n "$ZEPPELIN_IMPERSONATE_USER" ]] && [[ "$ZEPPELIN_IMPERSONATE_SPARK_PROXY_USER" != "false" ]]; then | ||
| INTERPRETER_RUN_COMMAND+=' '` echo ${SPARK_SUBMIT} --class ${ZEPPELIN_SERVER} --driver-class-path \"${ZEPPELIN_INTP_CLASSPATH_OVERRIDES}:${ZEPPELIN_INTP_CLASSPATH}\" --driver-java-options \"${JAVA_INTP_OPTS}\" ${SPARK_SUBMIT_OPTIONS} ${ZEPPELIN_SPARK_CONF} --proxy-user ${ZEPPELIN_IMPERSONATE_USER} ${SPARK_APP_JAR} ${CALLBACK_HOST} ${PORT} ${INTP_PORT}` | ||
| INTERPRETER_RUN_COMMAND+=' '` echo ${SPARK_SUBMIT} --class ${ZEPPELIN_SERVER} --driver-class-path \"${ZEPPELIN_INTP_CLASSPATH_OVERRIDES}:${ZEPPELIN_INTP_CLASSPATH}\" --driver-java-options \"${JAVA_INTP_OPTS}\" ${SPARK_SUBMIT_OPTIONS} ${ZEPPELIN_SPARK_CONF} ${SPARK_APP_JAR} ${CALLBACK_HOST} ${PORT} ${INTP_PORT}` |
There was a problem hiding this comment.
Both if and else are same!
zjffdu
commented
Dec 22, 2017
Thanks @prabhjyotsingh comments has been addressed. And CI passed |
prabhjyotsingh
commented
Dec 22, 2017
Rest, looks good. |
zjffdu
commented
Dec 22, 2017
Thanks, Merge if no more comment |
What is this PR for?
This PR is for trying to fix the impersonation of spark interpreter in master branch. For spark impersonation, we don't need to ssh, just adding
--proxy-useris enough.What type of PR is it?
[Bug Fix]
Todos
What is the Jira issue?
How should this be tested?
Screenshots (if appropriate)
Questions: