Skip to content

ZEPPELIN-3313 z.getInterpreterContext().out().clear() fails to clear table data - #2881

Closed
r-kamath wants to merge 1 commit into
apache:masterfrom
r-kamath:ZEPPELIN-3313
Closed

ZEPPELIN-3313 z.getInterpreterContext().out().clear() fails to clear table data#2881
r-kamath wants to merge 1 commit into
apache:masterfrom
r-kamath:ZEPPELIN-3313

Conversation

@r-kamath

@r-kamathr-kamath commented Mar 19, 2018

Copy link
Copy Markdown
Member

What is this PR for?

z.getInterpreterContext().out().clear() fails to clear table data

What type of PR is it?

Bug Fix

Todos

  • - Fix visualizations in a separate ticket

What is the Jira issue?

ZEPPELIN-3313

How should this be tested?

see jira description

Screenshots (if appropriate)

before

before

after

after

Questions:

  • Does the licenses files need update? no
  • Is there breaking changes for older versions? no
  • Does this needs documentation? no

@zjffdu

zjffdu commented Mar 19, 2018

Copy link
Copy Markdown
Contributor

Thanks @r-kamath , I try another example, but the result seems unstable (sometimes it would display 2 elements), see screenshot.
table_streaming

Another issue is that if I select another chart type, the result would be even more unstable.

table_streaming2

@r-kamath

Copy link
Copy Markdown
MemberAuthor

@zjffdu the issue in the second screenshot will not occur when viz switching is enabled, I'm working on it

@r-kamath

Copy link
Copy Markdown
MemberAuthor

@zjffdu currently data update and refresh timing in ui grid is not guaranteed. This issue persists only when the interval is below 1sec. I modified your example with 2sec delay and the rendering is fine.

However, frequent refreshing of ui table is causing too many
[Violation] 'setTimeout' handler took <N>ms and
[Violation] Added non-passive event listener to a scroll-blocking <some> event. Consider marking event handler as 'passive' to make the page more responsive. See <URL>

About support for Passive Event Listeners: https://stackoverflow.com/a/39187679

@r-kamath

Copy link
Copy Markdown
MemberAuthor

@zjffdu the issue in the second screenshot will not occur when viz switching is enabled, I'm working on it

Patch will be send in a different PR.

@zjffdu

Copy link
Copy Markdown
Contributor

LGTM

@r-kamath

Copy link
Copy Markdown
MemberAuthor

will merge this if there are no more discussions

asfgit pushed a commit that referenced this pull request Mar 29, 2018
…table data
### What is this PR for?
z.getInterpreterContext().out().clear() fails to clear table data
### What type of PR is it?
Bug Fix
### Todos
* [ ] - Fix visualizations in a separate ticket
### What is the Jira issue?
[ZEPPELIN-3313](https://issues.apache.org/jira/browse/ZEPPELIN-3313)
### How should this be tested?
see jira description
### Screenshots (if appropriate)
#### before
![before](https://user-images.githubusercontent.com/2031306/37593485-2585fb74-2b98-11e8-9a21-8dd81a0c4c7d.gif)
#### after
![after](https://user-images.githubusercontent.com/2031306/37593495-2e106ba8-2b98-11e8-9dab-80985b82ccec.gif)
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
Author: Renjith Kamath <renjith.kamath@gmail.com>
Closes#2881 from r-kamath/ZEPPELIN-3313 and squashes the following commits:
d67974e [Renjith Kamath] ZEPPELIN-3313 z.getInterpreterContext().out().clear() fails to clear table data
(cherry picked from commit fd27014)
Signed-off-by: Renjith Kamath <rkamath@apache.org>
jwagun pushed a commit to jwagun/zeppelin that referenced this pull request Apr 23, 2018
…table data
### What is this PR for?
z.getInterpreterContext().out().clear() fails to clear table data
### What type of PR is it?
Bug Fix
### Todos
* [ ] - Fix visualizations in a separate ticket
### What is the Jira issue?
[ZEPPELIN-3313](https://issues.apache.org/jira/browse/ZEPPELIN-3313)
### How should this be tested?
see jira description
### Screenshots (if appropriate)
#### before
![before](https://user-images.githubusercontent.com/2031306/37593485-2585fb74-2b98-11e8-9a21-8dd81a0c4c7d.gif)
#### after
![after](https://user-images.githubusercontent.com/2031306/37593495-2e106ba8-2b98-11e8-9dab-80985b82ccec.gif)
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
Author: Renjith Kamath <renjith.kamath@gmail.com>
Closesapache#2881 from r-kamath/ZEPPELIN-3313 and squashes the following commits:
d67974e [Renjith Kamath] ZEPPELIN-3313 z.getInterpreterContext().out().clear() fails to clear table data
prabhjyotsingh pushed a commit to prabhjyotsingh/zeppelin that referenced this pull request Jul 4, 2018
…table data
z.getInterpreterContext().out().clear() fails to clear table data
Bug Fix
* [ ] - Fix visualizations in a separate ticket
[ZEPPELIN-3313](https://issues.apache.org/jira/browse/ZEPPELIN-3313)
see jira description
![before](https://user-images.githubusercontent.com/2031306/37593485-2585fb74-2b98-11e8-9a21-8dd81a0c4c7d.gif)
![after](https://user-images.githubusercontent.com/2031306/37593495-2e106ba8-2b98-11e8-9dab-80985b82ccec.gif)
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
Author: Renjith Kamath <renjith.kamath@gmail.com>
Closesapache#2881 from r-kamath/ZEPPELIN-3313 and squashes the following commits:
d67974e [Renjith Kamath] ZEPPELIN-3313 z.getInterpreterContext().out().clear() fails to clear table data
(cherry picked from commit fd27014)
Signed-off-by: Renjith Kamath <rkamath@apache.org>
(cherry picked from commit da277b9)
Change-Id: I77d1d1b2f64a5ee52369815d08345b28c96af5d0
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@r-kamath@zjffdu@prabhjyotsingh