Uh oh!
There was an error while loading. Please reload this page.
ZEPPELIN-3391 Incorrect status shown for '%livy2.conf' and %spark2.conf' interpreters - #2915
Closed
r-kamath wants to merge 1 commit into
Closed
ZEPPELIN-3391 Incorrect status shown for '%livy2.conf' and %spark2.conf' interpreters#2915r-kamath wants to merge 1 commit into
r-kamath wants to merge 1 commit into
Conversation
felixcheung
approved these changes
Apr 11, 2018
prabhjyotsingh
approved these changes
Apr 11, 2018
r-kamath
commented
Apr 11, 2018
MemberAuthor
will merge this if there are no more discussions |
Contributor
Thanks @r-kamath , but I don't think this is the right fix. As you can see we have unit test to cover this. https://github.com/apache/zeppelin/blob/master/zeppelin-zengine/src/test/java/org/apache/zeppelin/interpreter/ConfInterpreterTest.java#L62 This should due to something bug else |
r-kamath
commented
Apr 12, 2018
MemberAuthor
@zjffdu thanks for the pointer. I didn't check out the tests. My bad! |
r-kamath
commented
Apr 13, 2018
MemberAuthor
right fix is in #2926 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR for?
Incorrect status shown for '%livy2.conf' and %spark2.conf' interpreters
What type of PR is it?
Bug Fix
What is the Jira issue?
ZEPPELIN-3391
How should this be tested?
Screenshots (if appropriate)
Questions: