Uh oh!
There was an error while loading. Please reload this page.
ZEPPELIN-3405 Zeppelin fails to display the User home page if user belongs to roles with space in its name - #2931
Closed
r-kamath wants to merge 1 commit into
Closed
ZEPPELIN-3405 Zeppelin fails to display the User home page if user belongs to roles with space in its name#2931r-kamath wants to merge 1 commit into
r-kamath wants to merge 1 commit into
Conversation
…longs to roles with space in its name. - escape roles value in login and ticket json response - fix method name typo Change-Id: I5b07d8380d016545689a5c1ba4bf6a624e07b678
zjffdu
commented
Apr 20, 2018
Contributor
LGTM |
r-kamath
commented
Apr 20, 2018
MemberAuthor
will merge this if there are no more discussions |
asfgit pushed a commit
that referenced
this pull request
Apr 20, 2018
…longs to roles with space in its name - escape roles value in login and ticket json response - fix method name typo Fix string escape issue in roles. More details in JIRA description. Bug Fix * [ ] - Task https://issues.apache.org/jira/browse/ZEPPELIN-3405 see JIRA description * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? no Author: Renjith Kamath <rkamath@apache.org> Closes#2931 from r-kamath/ZEPPELIN-3405 and squashes the following commits: 87f8243 [Renjith Kamath] ZEPPELIN-3405 Zeppelin fails to display the User home page if user belongs to roles with space in its name. Change-Id: I58be55c2a663f5dfddeab990654d11e5088de1ec (cherry picked from commit 4013259) Signed-off-by: Renjith Kamath <rkamath@apache.org>
jwagun pushed a commit
to jwagun/zeppelin
that referenced
this pull request
Apr 23, 2018
…longs to roles with space in its name - escape roles value in login and ticket json response - fix method name typo Fix string escape issue in roles. More details in JIRA description. Bug Fix * [ ] - Task https://issues.apache.org/jira/browse/ZEPPELIN-3405 see JIRA description * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? no Author: Renjith Kamath <rkamath@apache.org> Closesapache#2931 from r-kamath/ZEPPELIN-3405 and squashes the following commits: 87f8243 [Renjith Kamath] ZEPPELIN-3405 Zeppelin fails to display the User home page if user belongs to roles with space in its name. Change-Id: I58be55c2a663f5dfddeab990654d11e5088de1ec
weand
commented
Apr 23, 2018
Contributor
@prabhjyotsingh@zjffdu When...
...execution fails with user1 has no permission for spark I'm wondering if there is no test for this use case. When reverting this PR the execution works fine. |
1 task
asfgit pushed a commit
that referenced
this pull request
Apr 25, 2018
hotfix for #2931#2931 (comment) [Hot Fix] * [ ] - Task https://issues.apache.org/jira/browse/ZEPPELIN-3405 see PR description * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? no Author: Renjith Kamath <rkamath@apache.org> Closes#2942 from r-kamath/hotfix_ZEPPELIN-3405 and squashes the following commits: b93c2de [Renjith Kamath] ZEPPELIN-3405 fix permission checks with roles Change-Id: I1ce0d0306dc665b0267042a5e9181a13f136fac1 (cherry picked from commit ad77265) Signed-off-by: Renjith Kamath <rkamath@apache.org>
asfgit pushed a commit
that referenced
this pull request
Apr 25, 2018
hotfix for #2931#2931 (comment) [Hot Fix] * [ ] - Task https://issues.apache.org/jira/browse/ZEPPELIN-3405 see PR description * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? no Author: Renjith Kamath <rkamath@apache.org> Closes#2942 from r-kamath/hotfix_ZEPPELIN-3405 and squashes the following commits: b93c2de [Renjith Kamath] ZEPPELIN-3405 fix permission checks with roles Change-Id: I1ce0d0306dc665b0267042a5e9181a13f136fac1
prabhjyotsingh pushed a commit
to prabhjyotsingh/zeppelin
that referenced
this pull request
Jul 4, 2018
…longs to roles with space in its name - escape roles value in login and ticket json response - fix method name typo Fix string escape issue in roles. More details in JIRA description. Bug Fix * [ ] - Task https://issues.apache.org/jira/browse/ZEPPELIN-3405 see JIRA description * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? no Author: Renjith Kamath <rkamath@apache.org> Closesapache#2931 from r-kamath/ZEPPELIN-3405 and squashes the following commits: 87f8243 [Renjith Kamath] ZEPPELIN-3405 Zeppelin fails to display the User home page if user belongs to roles with space in its name. Change-Id: I58be55c2a663f5dfddeab990654d11e5088de1ec (cherry picked from commit 4013259) Signed-off-by: Renjith Kamath <rkamath@apache.org>
mckartha pushed a commit
to syntechdev/zeppelin
that referenced
this pull request
Aug 9, 2018
…longs to roles with space in its name - escape roles value in login and ticket json response - fix method name typo Fix string escape issue in roles. More details in JIRA description. Bug Fix * [ ] - Task https://issues.apache.org/jira/browse/ZEPPELIN-3405 see JIRA description * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? no Author: Renjith Kamath <rkamath@apache.org> Closesapache#2931 from r-kamath/ZEPPELIN-3405 and squashes the following commits: 87f8243 [Renjith Kamath] ZEPPELIN-3405 Zeppelin fails to display the User home page if user belongs to roles with space in its name. Change-Id: I58be55c2a663f5dfddeab990654d11e5088de1ec
mckartha pushed a commit
to syntechdev/zeppelin
that referenced
this pull request
Aug 9, 2018
hotfix for apache#2931apache#2931 (comment) [Hot Fix] * [ ] - Task https://issues.apache.org/jira/browse/ZEPPELIN-3405 see PR description * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? no Author: Renjith Kamath <rkamath@apache.org> Closesapache#2942 from r-kamath/hotfix_ZEPPELIN-3405 and squashes the following commits: b93c2de [Renjith Kamath] ZEPPELIN-3405 fix permission checks with roles Change-Id: I1ce0d0306dc665b0267042a5e9181a13f136fac1
mckartha pushed a commit
to syntechdev/zeppelin
that referenced
this pull request
Aug 9, 2018
…longs to roles with space in its name - escape roles value in login and ticket json response - fix method name typo Fix string escape issue in roles. More details in JIRA description. Bug Fix * [ ] - Task https://issues.apache.org/jira/browse/ZEPPELIN-3405 see JIRA description * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? no Author: Renjith Kamath <rkamath@apache.org> Closesapache#2931 from r-kamath/ZEPPELIN-3405 and squashes the following commits: 87f8243 [Renjith Kamath] ZEPPELIN-3405 Zeppelin fails to display the User home page if user belongs to roles with space in its name. Change-Id: I58be55c2a663f5dfddeab990654d11e5088de1ec (cherry picked from commit 4013259) Signed-off-by: Renjith Kamath <rkamath@apache.org>
mckartha pushed a commit
to syntechdev/zeppelin
that referenced
this pull request
Aug 9, 2018
hotfix for apache#2931apache#2931 (comment) [Hot Fix] * [ ] - Task https://issues.apache.org/jira/browse/ZEPPELIN-3405 see PR description * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? no Author: Renjith Kamath <rkamath@apache.org> Closesapache#2942 from r-kamath/hotfix_ZEPPELIN-3405 and squashes the following commits: b93c2de [Renjith Kamath] ZEPPELIN-3405 fix permission checks with roles Change-Id: I1ce0d0306dc665b0267042a5e9181a13f136fac1 (cherry picked from commit ad77265) Signed-off-by: Renjith Kamath <rkamath@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR for?
Fix string escape issue in roles. More details in JIRA description.
What type of PR is it?
Bug Fix
Todos
What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-3405
How should this be tested?
see JIRA description
Screenshots (if appropriate)
Questions: