Skip to content

ZEPPELIN-3379. Refactoring of JDBC autocomplete. - #2972

Closed
mebelousov wants to merge 7 commits into
apache:masterfrom
Tinkoff:ZEPPELIN-3379
Closed

ZEPPELIN-3379. Refactoring of JDBC autocomplete.#2972
mebelousov wants to merge 7 commits into
apache:masterfrom
Tinkoff:ZEPPELIN-3379

Conversation

@mebelousov

@mebelousovmebelousov commented May 17, 2018

Copy link
Copy Markdown
Contributor

What is this PR for?

Current implementation of autocomplete allows only completion in schema.table.column scenario. Such scenario exclude tables for default schema.
The PR fixes the scenario with tables in default schema and alias processing.
Also I want to add feature to complete columns for used tables in statement from blank cursor.

The autocomplete was tested for Greenplum 4.3 (PostgreSQL), Oracle 11g, MySQL (Hive Metastore) and Hive.
This PR is reopening of #2970

What type of PR is it?

Improvement

What is the Jira issue?

ZEPPELIN-3379

How should this be tested?

  • Manually
  • Tests pass

Screenshots (if appropriate)

mysql

Questions:

  • Does the licenses files need update? no
  • Is there breaking changes for older versions? no
  • Does this needs documentation? no

@mebelousov

Copy link
Copy Markdown
ContributorAuthor

Will revert when anyone could test this PR.

@anirbanch

Copy link
Copy Markdown

@mebelousov would need this functionality, how can I help?

@mebelousov

Copy link
Copy Markdown
ContributorAuthor

Hi @anirbanch !

I have adopted PR to branch 0.8 and have created patch (can be founded in linked JIRA issue).
You can apply patch and build jars.

On your risks you can

  1. Replace next files (from linked JIRA issue)
    $ZEPPELIN_HOME/interpreter/jdbc/zeppelin-jdbc-0.8.1-SNAPSHOT.jar
    $ZEPPELIN_HOME/interpreter/jdbc/postgresql-native-driver-sql.keywords
    $ZEPPELIN_HOME/lib/interpreter/zeppelin-interpreter-0.8.1-SNAPSHOT.jar
  2. Set "completionSupport" to false in $ZEPPELIN_HOME/interpreter/jdbc/interpreter-setting.json
    also you can add "completionKey": "TAB" to editor key
  3. Run Zeppelin.

@Savalek
Savalek deleted the ZEPPELIN-3379 branch July 5, 2019 06:37
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@mebelousov@anirbanch